[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7531) Syncrepl push delete operation does not recover when slave is unavailable



Hi,

hans.moser@ofd-z.niedersachsen.de schrieb (14.03.2013 17:22 Uhr):
> hyc@symas.com schrieb (14.03.2013 16:24 Uhr):
>> Marc Patermann wrote:
>>> hyc@symas.com schrieb (14.03.2013 15:14 Uhr):
>>>> hans.moser@ofd-z.niedersachsen.de wrote:
>>>>> I think we had situations like this before...
>>>>>
>>>>> How about having a test for this?
>>>>> What is the test which is nearest to this situation where a test could
>>>>> be based on?
>>>> test045. Feel free to submit patches for this test script.
>>> If I'm not mistaken,
>>> - in lines 262-264 the consumer is stopped
>>> - in lines 266-284 changes are made to the provider
>>> - in lines 286-294 the consumer is started again.
>> Sounds reasonable but your line numbers don't match anything in our tree. 
>> Please send an actual patch, e.g. from git format-patch (or just diff -u.)
> Sorry, I was in test054, not test045. But as base 054 seems to be just fine.
> I hope, I did the patch right.
Hm, I was not included. :(
Is there something wrong with the patch?


Marc