[Date Prev][Date Next]
Re: (ITS#7531) Syncrepl push delete operation does not recover when slave is unavailable
- To: openldap-its@OpenLDAP.org
- Subject: Re: (ITS#7531) Syncrepl push delete operation does not recover when slave is unavailable
- From: email@example.com
- Date: Mon, 11 Mar 2013 14:19:17 GMT
- Auto-submitted: auto-generated (OpenLDAP-ITS)
On 03/02/2013 02:59 AM, firstname.lastname@example.org wrote:
> email@example.com wrote:
>> On 02/27/2013 02:48 PM, firstname.lastname@example.org wrote:
>>> On 02/27/2013 12:25 PM, email@example.com wrote:
>>>> Full_Name: Jan Synacek
>>>> Version: RE24 (7b03a58)
>>>> OS: Linux - Fedora 18
>>>> URL: ftp://ftp.openldap.org/incoming/jsynacek-reproducer.tar.gz
>>>> Submission from: (NULL) (18.104.22.168)
>>>> The setup is a master with an ldap backend and a slave consumer. If the master
>>>> is running and slave is not, delete operation results in the master being
>>>> Steps to reproduce:
>>>> 1. Start master.
>>>> 2. Add the example ldif.
>>>> 3. Delete one of the test org units.
>>>> 4. Observe the error.
>>>> I would expect the master to honor the retry setting.
>>> During the reproduction, it may be necessary to first have both master and slave
>>> running, delete a testing test org unit (so the first replication is
>>> successful), stop the slave and then continue to step 3.
> This patch is clearly unacceptable. Your goto obviously skips over two _free()
> invocations, thus introducing a memory leak.
I'm sorry that I didn't notice this before sending the patch.
Software Engineer, Red Hat