[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6247)



On May 1, 2010, at 12:31 PM, daniel@pluta.biz wrote:

> Hi,
>=20
> just some changes and cleanups according the still ongoing discussion =
on=20
> ldapext.

I recommend consideration of this patch be deferred until the =
specification is less of a work-in-a-progress.

>=20
> The patch can be downloaded here:=20
> ftp://ftp.openldap.org/incoming/daniel-pluta-100501.patch
>=20
> Changes:
>    - removed extensible matching rules strictly associated with=20
> dedicated syntaxes
>    - added two universal matching rules instead:
>        - nowMach (equality matching rule)
>        - nowOrdering (ordering matching rule)
>        - these two rules also support extensible match filters

Your comments imply these rules could be used as attribute type equality =
and ordering rules.  I don't believe the met the requirements (see =
X.501) to be used in that manner.  That is, they only make sense as =
extensible matching rules.

>=20
> To publish a correct server current time time-stamp value within =
Root-DSE:
>    - apply the bugfix from ITS#6541
>    - and use -DCTM_G_DIFFERENTIAL_SERVERTIME

#ifdef's should, IMO, be generally avoided.

>=20
>=20
> To extend generalizedTime attribute types to also support "NOW" as=20
> assertion value:
>     - use -DCTM_RFC4517_MR_AV_SYNTAX_VIOLATION

The generalized time syntax is not ours to alter.  Introduction of such =
a change would, it seem, lead to interoperability problems.

>=20
>=20
> Beware of patching conflicts in schema_init.c:
> This patch contains small redundant parts from my parallel =
contribution=20
> in ITS#6532
>=20
> Regards,
> Daniel
>=20
>=20