[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5875) sparc64/gcc-3.3 build fix

On Dec 28, 2008, at 4:52 PM, kurt@openldap.org wrote:

> On a technical note, use of platform macros (sun and gcc versions)
> should be avoided.  Instead, autoconf should be used to detect
> conditions for need to be adapted for.
> On an IPR review, I suspect it would be easier to update to:
>   http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/hash/sha1.c?rev=1.21;content-type=text%2Fplain
> then to try to identify the contributors and get their "okay".

I should note that, from a technical point of view, it might also be  
better to integrate the latest from OpenBSD.  This would hopefully  
provide a SHA1 implementation which works on more platforms than the  
current version, or the current version as modified by Klaus's patch.

-- Kurt