Re: (ITS#3720) back meta sizelimit exceeded

[m.d.t.evans@qmul.ac.uk]

On Thu, 2005-05-12 at 22:36 +0200, Pierangelo Masarati wrote:
> m.d.t.evans@qmul.ac.uk wrote:
> 
> >Full_Name: Martin Evans
> >Version: 2.2.23
> >OS: Solaris 8
> >URL: 
> >Submission from: (NULL) (138.37.8.140)
> >
> >
> >There's some strange looking logic in back_meta/search.c I think it is
> >incorrectly reporting size limit exceeded for some searches. e.g. if you do
> >ldapsearch -z1 with a filter to return only 1 entry from a proxied tree.
> >
> >Heres a patch, which fixes a short term problem that I have. is it reasonable?
> >
> >  
> >
> I confirm the problem, but your analysis appears incorrect.  In fact, 
> your fix works in your case, but in cases where the filter matches 
> exactly two entries it would return both and then sizelimit exceeded for 
> a -z1 sizelimit, which is incorrect.  I believe the test must move 
> somewhere else, and apply if yet another entry is about to be returned 
> by any target.  I'm providing a new fix to both HEAD and RE22.
> 
> In any cases, thanks for reporting and please test.  p.
> 
> 
> 
>     SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax: +390382476497
> 

Hi, thanks for looking at this.

but I don't see the behaviour you suggest...

bash-3.00$ ldapsearch -H ldap://XXXX -x -sone -b"XXXXX" -z1 -LLL "(|
(uid=user1)(uid=user2))"
dn: uid=user1,XXXX
sn: XXXX
objectClass: inetOrgPerson
objectClass: organizationalPerson
objectClass: person
objectClass: top
uid: user1

Size limit exceeded (4)

In fact, I see that setting -z to N returns N entries then gives
sizelimit exceeded.

I'd only tested searches that return entries under the proxied tree
(back-glued in to a local tree) though, not searches that may include
local entries. However, they seem to be behaving oddly too when a
sizelimit is set so I might open another thread for that. In any case, I
will try your patch to search.c first, as it may solve both problems.

Cheers,
Martin.

-- 
-- Dr MDT Evans, Computing Services, Queen Mary, University of London