[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: Patch: Bugs with back-ldap/meta mappings (ITS#1787)

h.b.furuseth@usit.uio.no wrote:
> Full_Name: Hallvard B. Furuseth
> Version: HEAD
> OS: Linux
> URL: http://folk.uio.no/hbf/OpenLDAP/back-ldap.txt
> Submission from: (NULL) (
> The source claims the 'map' attribute has syntax
> map {objectclass | attribute}   {<source> | *}      [<dest> | *]
> while it actually has syntax
> map {objectclass | attribute} [<local name> | *] {<foreign name> | *}
> except that the code is confused about it.  Removed attributes are
> put in both the maps for local and foreign names:
>         # Remove description and present title as description instead
>         map attribute   description
>         map attribute   description title
> -->
>         slapd.conf: line 10: duplicate mapping found (ignored)

I admit attribuet mapping has been sometime unclear in its usage, 
however I never noticed such problems in its usage.  Of course
I didn't use it intensively, only played with it for a while.

Can you clarify the point further, before I commit your patches?
I also note that the patch does not apply cleanly to HEAD code
(possibly due to Howard's recent commits, or mine) and fails
for very simple cases like 

database ldap
uri             "ldap://localhost:9009/";
suffix          "dc=umich,dc=edu"
suffixMassage   "dc=umich,dc=edu" "o=University of Michigan,c=US"
map attribute ou

added to the slapd.conf resulting from test003 results in a sigsegv :)

> Also, map.c:ldap_back_map_attrs() loops forever on removed attributes
> (ie. if one asks ldapsearch for an attribute which has been removed).

Good catch :=)


Dr. Pierangelo Masarati               | voice: +39 02 2399 8309
Dip. Ing. Aerospaziale                | fax:   +39 02 2399 8334
Politecnico di Milano                 |
via La Masa 34, 20156 Milano, Italy   |