Full_Name: Kurt Zeilenga Version: HEAD OS: Mac OS X 10.4.10 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (24.180.46.200) Submitted by: kurt With perl v5.8.8 from macports (recently upgraded) Entering directory `/Users/kurt/Work/devel/servers/slapd/back-perl' /bin/sh ../../..//libtool --tag=disable-shared --mode=compile cc -g -O2 -I../../../include -I../../../include -I.. -I./.. -I/opt/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp -fno-strict-aliasing -pipe -Wdeclaration-after-statement -I/opt/local/include -I/opt/local/lib/perl5/5.8.8/darwin-2level/CORE -I/usr/pkg/include -I/usr/pkg/include/db45 -c init.c cc -g -O2 -I../../../include -I../../../include -I.. -I./.. -I/opt/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp -fno-strict-aliasing -pipe -Wdeclaration-after-statement -I/opt/local/include -I/opt/local/lib/perl5/5.8.8/darwin-2level/CORE -I/usr/pkg/include -I/usr/pkg/include/db45 -c init.c -o init.o init.c:90: error: parse error before 'ConfigReply' init.c: In function 'perl_back_db_init': init.c:92: error: number of arguments doesn't match prototype proto-perl.h:27: error: prototype declaration init.c:93: error: 'be' undeclared (first use in this function) init.c:93: error: (Each undeclared identifier is reported only once init.c:93: error: for each function it appears in.) init.c: At top level: init.c:106: error: parse error before 'ConfigReply' init.c: In function 'perl_back_db_open': init.c:108: error: number of arguments doesn't match prototype proto-perl.h:28: error: prototype declaration init.c:112: error: 'be' undeclared (first use in this function) make[3]: *** [init.lo] Error 1
kurt@OpenLDAP.org wrote: > With perl v5.8.8 from macports (recently upgraded) Works fine here (Linux) > Entering directory `/Users/kurt/Work/devel/servers/slapd/back-perl' > /bin/sh ../../..//libtool --tag=disable-shared --mode=compile cc -g -O2 > -I../../../include -I../../../include -I.. -I./.. -I/opt/local/include > -fno-common -DPERL_DARWIN -no-cpp-precomp -fno-strict-aliasing -pipe > -Wdeclaration-after-statement -I/opt/local/include > -I/opt/local/lib/perl5/5.8.8/darwin-2level/CORE -I/usr/pkg/include > -I/usr/pkg/include/db45 -c init.c > cc -g -O2 -I../../../include -I../../../include -I.. -I./.. > -I/opt/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp > -fno-strict-aliasing -pipe -Wdeclaration-after-statement -I/opt/local/include > -I/opt/local/lib/perl5/5.8.8/darwin-2level/CORE -I/usr/pkg/include > -I/usr/pkg/include/db45 -c init.c -o init.o > init.c:90: error: parse error before 'ConfigReply' > init.c: In function 'perl_back_db_init': > init.c:92: error: number of arguments doesn't match prototype > proto-perl.h:27: error: prototype declaration This was recently (sort of: 2 weeks ago) changed. Are you sure you updated? p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it --------------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Email: pierangelo.masarati@sys-net.it ---------------------------------------
changed notes changed state Open to Feedback
On Aug 22, 2007, at 6:04 PM, ando@sys-net.it wrote: > kurt@OpenLDAP.org wrote: > >> With perl v5.8.8 from macports (recently upgraded) Switching to the MacOS X default perl doesn't help... > Works fine here (Linux) > >> Entering directory `/Users/kurt/Work/devel/servers/slapd/back-perl' >> /bin/sh ../../..//libtool --tag=disable-shared --mode=compile cc - >> g -O2 >> -I../../../include -I../../../include -I.. -I./.. -I/opt/ >> local/include >> -fno-common -DPERL_DARWIN -no-cpp-precomp -fno-strict-aliasing -pipe >> -Wdeclaration-after-statement -I/opt/local/include >> -I/opt/local/lib/perl5/5.8.8/darwin-2level/CORE -I/usr/pkg/include >> -I/usr/pkg/include/db45 -c init.c >> cc -g -O2 -I../../../include -I../../../include -I.. -I./.. >> -I/opt/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp >> -fno-strict-aliasing -pipe -Wdeclaration-after-statement -I/opt/ >> local/include >> -I/opt/local/lib/perl5/5.8.8/darwin-2level/CORE -I/usr/pkg/include >> -I/usr/pkg/include/db45 -c init.c -o init.o >> init.c:90: error: parse error before 'ConfigReply' >> init.c: In function 'perl_back_db_init': >> init.c:92: error: number of arguments doesn't match prototype >> proto-perl.h:27: error: prototype declaration > > This was recently (sort of: 2 weeks ago) changed. Are you sure you > updated? Yes. > > p. > > > > Ing. Pierangelo Masarati > OpenLDAP Core Team > > SysNet s.r.l. > via Dossi, 8 - 27100 Pavia - ITALIA > http://www.sys-net.it > --------------------------------------- > Office: +39 02 23998309 > Mobile: +39 333 4963172 > Email: pierangelo.masarati@sys-net.it > --------------------------------------- > > >
kurt@OpenLDAP.org wrote: >>> Entering directory `/Users/kurt/Work/devel/servers/slapd/back-perl' >>> /bin/sh ../../..//libtool --tag=disable-shared --mode=compile cc - >>> g -O2 >>> -I../../../include -I../../../include -I.. -I./.. -I/opt/ >>> local/include >>> -fno-common -DPERL_DARWIN -no-cpp-precomp -fno-strict-aliasing -pipe >>> -Wdeclaration-after-statement -I/opt/local/include >>> -I/opt/local/lib/perl5/5.8.8/darwin-2level/CORE -I/usr/pkg/include >>> -I/usr/pkg/include/db45 -c init.c >>> cc -g -O2 -I../../../include -I../../../include -I.. -I./.. >>> -I/opt/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp >>> -fno-strict-aliasing -pipe -Wdeclaration-after-statement -I/opt/ >>> local/include >>> -I/opt/local/lib/perl5/5.8.8/darwin-2level/CORE -I/usr/pkg/include >>> -I/usr/pkg/include/db45 -c init.c -o init.o >>> init.c:90: error: parse error before 'ConfigReply' ConfigReply is declared in slapd/config.h; could it be another, system-related config.h is present in an earlier include path? Even though, I see in the above cc command-line -I .. is present... p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it --------------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Email: pierangelo.masarati@sys-net.it ---------------------------------------
On Aug 25, 2007, at 5:35 AM, ando@sys-net.it wrote: > kurt@OpenLDAP.org wrote: > >>>> Entering directory `/Users/kurt/Work/devel/servers/slapd/back-perl' >>>> /bin/sh ../../..//libtool --tag=disable-shared --mode=compile cc - >>>> g -O2 >>>> -I../../../include -I../../../include -I.. -I./.. -I/opt/ >>>> local/include >>>> -fno-common -DPERL_DARWIN -no-cpp-precomp -fno-strict-aliasing - >>>> pipe >>>> -Wdeclaration-after-statement -I/opt/local/include >>>> -I/opt/local/lib/perl5/5.8.8/darwin-2level/CORE -I/usr/pkg/ >>>> include >>>> -I/usr/pkg/include/db45 -c init.c >>>> cc -g -O2 -I../../../include -I../../../include -I.. -I./.. >>>> -I/opt/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp >>>> -fno-strict-aliasing -pipe -Wdeclaration-after-statement -I/opt/ >>>> local/include >>>> -I/opt/local/lib/perl5/5.8.8/darwin-2level/CORE -I/usr/pkg/include >>>> -I/usr/pkg/include/db45 -c init.c -o init.o >>>> init.c:90: error: parse error before 'ConfigReply' > > ConfigReply is declared in slapd/config.h; could it be another, > system-related config.h is present in an earlier include path? > > Even though, I see in the above cc command-line -I .. is present... Personally, I think have -I., -I.., etc. is really bad. This causes #include "config.h" and #include <config.h> to be equivalent. However, there could be both a local config.h and a config.h somewhere in the system include directory. I would be better if slapd/config.h was included here by: #include "../config.h" and -I.. not be added to the include path. It possible -I.. is causing a system header to be eclipsed by the local header. Namely, /opt/local/lib/perl5/5.8.8/darwin-2level/CORE/config.h. > > p. > > > > Ing. Pierangelo Masarati > OpenLDAP Core Team > > SysNet s.r.l. > via Dossi, 8 - 27100 Pavia - ITALIA > http://www.sys-net.it > --------------------------------------- > Office: +39 02 23998309 > Mobile: +39 333 4963172 > Email: pierangelo.masarati@sys-net.it > --------------------------------------- > > >
--On Saturday, August 25, 2007 6:16 AM +0000 kurt@OpenLDAP.org wrote: > Personally, I think have -I., -I.., etc. is really bad. This causes > #include "config.h" > and > #include <config.h> > > to be equivalent. However, there could be both a local config.h and > a config.h somewhere in the system include directory. > > I would be better if slapd/config.h was included here by: > #include "../config.h" > > and -I.. not be added to the include path. It possible -I.. is > causing a system header to be eclipsed by the local header. > Namely, /opt/local/lib/perl5/5.8.8/darwin-2level/CORE/config.h. This issue seems to hit Mac systems a lot, dunno why. But I've seen it with several things now that touch perl. --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration
Kurt Zeilenga wrote: >> ConfigReply is declared in slapd/config.h; could it be another, >> system-related config.h is present in an earlier include path? >> >> Even though, I see in the above cc command-line -I .. is present... > > Personally, I think have -I., -I.., etc. is really bad. This causes > #include "config.h" > and > #include <config.h> > > to be equivalent. However, there could be both a local config.h and a > config.h somewhere in the system include directory. > > I would be better if slapd/config.h was included here by: > #include "../config.h" > > and -I.. not be added to the include path. It possible -I.. is causing > a system header to be eclipsed by the local header. -I.. is needed to include slap.h, proto-slap.h, ... I'd rather rename config.h, which is quite generic, into slapconf.h or so. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it --------------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Email: pierangelo.masarati@sys-net.it ---------------------------------------
changed notes
--On August 25, 2007 7:34:22 AM +0000 ando@sys-net.it wrote: > Kurt Zeilenga wrote: > >>> ConfigReply is declared in slapd/config.h; could it be another, >>> system-related config.h is present in an earlier include path? >>> >>> Even though, I see in the above cc command-line -I .. is present... >> >> Personally, I think have -I., -I.., etc. is really bad. This causes >> # include "config.h" >> and >> # include <config.h> >> >> to be equivalent. However, there could be both a local config.h and a >> config.h somewhere in the system include directory. >> >> I would be better if slapd/config.h was included here by: >> # include "../config.h" >> >> and -I.. not be added to the include path. It possible -I.. is causing >> a system header to be eclipsed by the local header. > > -I.. is needed to include slap.h, proto-slap.h, ... > > I'd rather rename config.h, which is quite generic, into slapconf.h or so. In the name of getting 2.4.5 released, I've updated to Kurt's suggestion until such a time as this can be acted upon otherwise. --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration
quanah@zimbra.com wrote: > In the name of getting 2.4.5 released, I've updated to Kurt's suggestion > until such a time as this can be acted upon otherwise. That's fine. But I think renaming config.h to slapconf.h is a good idea anyway. Another thing that has nagged me ever since we unified the slap tools into slapd - should have renamed slapadd.c -> tooladd.c etc... Any objections? -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
hyc@symas.com wrote: > quanah@zimbra.com wrote: >> In the name of getting 2.4.5 released, I've updated to Kurt's suggestion >> until such a time as this can be acted upon otherwise. > > That's fine. > > But I think renaming config.h to slapconf.h is a good idea anyway. > > Another thing that has nagged me ever since we unified the slap tools into > slapd - should have renamed slapadd.c -> tooladd.c etc... Personally, not. Only, slap* makes them quite personal, while tool* sounds quite generic. It's like calling them db*: could be any type of db (no pun with Berkeley intended :). p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it --------------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Email: pierangelo.masarati@sys-net.it ---------------------------------------
ando@sys-net.it wrote: > hyc@symas.com wrote: >> Another thing that has nagged me ever since we unified the slap tools into >> slapd - should have renamed slapadd.c -> tooladd.c etc... > > Personally, not. Only, slap* makes them quite personal, while tool* > sounds quite generic. It's like calling them db*: could be any type of > db (no pun with Berkeley intended :). Fair enough. I think my main issue is with slapcommon.[ch], which is only related to the tools, not common to slapd as a whole. -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
moved from Incoming to Development
conflicting include paths? config.h needs to be renamed slapconf.h