CVS log for servers/slapd/value.c

Up to [OpenLDAP] / servers / slapd

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Revert prev commit

ITS#6845 set sorted flag on newly created sorted attrs

Happy New Year

happy belated New Year

Update copyright notices

Warning cleanup: signed meets unsigned.  ber_flatten2() returns -1 on
error, not LBER_ERROR.

Happy New Year (belated)

coverity - a->a_nvals may be NULL

Attribute/Modification value counters

add more sanity checks (ITS#5136)

fix ITS#5136

behave when a value of an ordered attr starts with '{' and either contains or not '}', but the prefix '{X}' does not contain a numericString

happy new year

Entry/Attribute struct caching, to minimize malloc fragmentation
Note: this breaks LDAP_COMP_MATCH and SLAP_ZONE_MALLOC. But they
were probably broken already anyway.

assert expects int. (int)<nonnull ptr/long> can be 0. Use assert(arg!=0/NULL).

Cleanup

Cleanup

do not assume the matching rule synta has a validate handler (ITS#4380)

Happy new year!

Fix mod delete by ordered index

use lutil_ato*() whenever appropriate

Fix ber_bvchr() vs assert() logic. Declare missing variable for code in #if 0.

don't trust strchr/strrchr with bervals

add some sanity checks...

In ordered_value_sort, allow zero-length ordered values.
In check_vals, log msg when ordered_value_sort fails.

wrap validate/pretty/normalize for ordered values (only #ifdef LDAP_DEVEL)

Plug more memleaks

Silence "unused <something>" warnings

Fixes for ordered deletes

Generic ordered value support

Happy New Year!

Component Matching module
See "contrib/slapd-modules/comp_match/README" to understand
what's the purpose of  this patch is and how to use it.

unifdef -UNEW_LOGGING

fix attr_merge() usage; cleanup

trim useless code

ITS#3092: Rename sl_free() and friends to slap_sl_free()

cleanup

use BER_BVNULL

Happy new year

Updated notices

Explicitly mark attribute/assertion syntax of values to be normalized

fix up nvalues code so that pretty routines work properly
re-add objectClass pretty routines

Need to pretty assertion values

fix possible typo

Fix value_find_ex result

Memory context tweaks for other ops

More memory context tweaks

#ifdef -DSLAP_NVALUES

SLAP_NVALUES: more fixes

SLAP_NVALUES: test003 now passes (with help of a substr mr hack)

SLAP_NVALUES:
	schema engine updated (but not schema routines so things don't run yet)
	nvalues mostly populated, enough for tests 0-2 to pass
	schema routines needs lots of work
	modify/mods codes needs lots of work

SLAP_NVALUES, round 3

Change MR flag names and add comments as to what they mean to slap.h

Happy new year

Added SLAP_MR_VALUE_NORMALIZED_MATCH, avoid redundant normalize when
calling value_find with already-normalized DNs

much better fix for ITS#2196 (dnattr without sat_equality is bounced at config)

mr should not be NULL; fixes ITS#2196

Converted ch_malloc, ch_calloc and ch_realloc calls to SLAP_MALLOC and
SLAP_CALLOC in add_value/add_value_one functions and propagated errors to
all functions that use these functions.

fix possible uninit bug

/*
 * The original code performs ( n ) normalizations
 * and ( n * ( n - 1 ) / 2 ) matches, which hide
 * the same number of normalizations.  The new code
 * performs the same number of normalizations ( n )
 * and ( n * ( n - 1 ) / 2 ) mem compares, far less
 * expensive than an entire match, if a match is
 * equivalent to a normalization and a mem compare ...
 *
 * This is far more memory expensive than the previous,
 * but it can heavily improve performances when big
 * chunks of data are added (typical example is a group
 * with thousands of DN-syntax members; on my system:
 * for members of 5-RDN DNs,

 members         orig            bvmatch (dirty) new
 1000            0m38.456s       0m0.553s        0m0.608s
 2000            2m33.341s       0m0.851s        0m1.003s

 * Moreover, 100 groups with 10000 members each were
 * added in 37m27.933s (an analogous LDIF file was
 * loaded into Active Directory in 38m28.682s, BTW).
 *
 * Maybe we could switch to the new algorithm when
 * the number of values overcomes a given threshold?
 */

added attr_merge/value_add functions that dela with single attribute; bervals for '*', '+' and '1.1' made available

Add normalize_validate_normalize() to be use instead of value_normalize()
where value has not yet been validated.

Add a value_validate() function to be used by prior to value_normalize
calls as needed (compare/filters).

Renamed BVarray to BerVarray. Moved slapd:bvarray_{add,free} to
liblber:ber_bvarray_{add,free}.

Update copyright statements

Remove lint

Change struct berval ** to BVarray

One more uninit

Cleanup, fix uninitialized vars

Change struct berval * to struct berval in various structures

Fix replacing of all values with an empty value.

Replace existing SLAP_MR_ matching flags with:
	SLAP_MR_ASSERTION_SYNTAX_MATCH
	SLAP_MR_VALUE_SYNTAX_MATCH
	SLAP_MR_VALUE_SYNTAX_CONVERTED_MATCH,
add supporting evaluation macros, and update code as needed.
Misc other code cleanup included.

minor cleanup

No code change, added a comment warning of a possible future difficulty.
Apparently, we refuse to index ;binary attributes.  That is mostly
bogus.  Whether it is indexable or not depends on whether we know how
to or not, nothing more.  I.e., the existance of indexer and filter
functions for the matching rules that are relevant to the attribute
type.

Replacement for value_find and compatibility macro.
Now we will be able to fix compares.

Extend value_match to extract an asserted value from a full value
if needed.  This is controlled by SLAP_MR_VALUE_IS_IN_MR_SYNTAX,
a new flag that should be set when evaluating filters such as in
searches and compares and unset otherwise (such as in modify).

Now, some callers of value_match, notably value_find, don't know
whether to set it or not.  We'll see to that.

Plug memory leak of normalized value in value_find()

Add attribute type/matching rule support for structuralObjectClass attribute
type.  Add type to core.schema.  Not yet populated on add nor checked on modify.

unrecognized objectIdentifer in desc form shall result in
an undefined matched.  unrecognized objectIdentifer in OID form
shall result in false match.

unifdef -DSLAPD_SCHEMA_NOT_COMPAT -USLAPD_SCHEMA_COMPAT

Prepare for unifdef -DSLAPD_SCHEMA_NOT_COMPAT

SLAPD_SCHEMA_NOT_COMPAT: ACL cleanup (not yet working)

SLAPD_SCHEMA_NOT_COMPAT: working modify?  need additional match
  routines, such as distinguishedNameMatch, to be sure.

SLAPD_SCHEMA_NOT_COMPAT: Mostly work modify

SLAPD_SCHEMA_NOT_COMPAT: framework for substring searching

SLAPD_SCHEMA_NOT_COMPAT:
Add syntax normalizer, separate from matching rule normalizer.
with mr normalizer defaulting to syntax normalizer.  This allows
for more consistent handling of some syntaxes, such as directoryString
(where all matches should ignore leading, trailing, and other extra
spaces).

Add hooks for syntax normalizer (used by value_match)
and prettier (to be used by update operations).

SLAPD_SCHEMA_NOT_COMPAT: equality filters
	(2.5.4.0=2.5.6.0) works!	ie: (objectclass=top)

SLAPD_SCHEMA_NOT_COMPAT: at least make filters not loop

Const'ification
SASL mech removed from backend bind callback (as SASL is managed by frontend)
Changes to some backends are untested (as I don't have all dependent
  software install)

SLAPD_SCHEMA_NOT_COMPAT: framework for value_match() and value_find()

SLAPD_SCHEMA_NOT_COMPAT: numerous changes to syntax flags, mostly minor
	added new value_normalize() code
	need LDAPsyntaxes X- field support

SLAP_SCHEMA_NOT_COMPAT: add calls to dummy value_normalize()
SLAP_SCHEMA_NOT_COMPAT: Need to sort out normalization of substring components

Y2k copyright update

Replace -DSLAPD_SCHEMA_COMPAT with -USLAPD_SCHEMA_NOT_COMPAT

Put more old schema code behind SLAPD_SCHEMA_COMPAT (which still
MUST be defined).

ITS#303: value_add_fast() empty value bug.  Ignore empty value.
This is technical incorrect, but we don't have the codes in place
to correctly handle empty values yet.

In preparation for adding dn_rewrite()...
s/dn_normalize/dn_validate/
s/dn_normalize_case/dn_normalize/

Add OpenLDAP RCSid to *.[ch] in clients, libraries, and servers.
Replace old Id as needed (back-tcl).
Leave updating of contribWare to contributors (for now).

Handle unknown syntaxes as binary

Stop mergers if dup returns NULL.

Add copyright notices.

UNDO LAST COMMIT.

Fix wait4child change: Prefer wait3 over wait.  Use SIGNAL instead of signal.

Avoid integer truncation of v1->bv_len - v2->bv_len in value_cmp(,,SYNTAX_BIN,)

Update NT port with support for -lldap_r and -lldbm.
Also add initial slapd .dsw/.dsp files.  Still needs work (mainly syslog).

Cast `char' arguments to ctype.h functions to `unsigned char'.
These functions require their arguments to be in the range of `unsigned char'.

The result set of an EQUALITY search on a SYNTAX_BIN attribute may have been
incorrect because value_cmp() in value.c compares two attributes by
comparing the leading bytes of the two values (candidate and filter) up to
the smaller of the two lengths of the binary values. If the lengths of two
SYNTAX_BIN values differ, like SYNTAX_CES and SYNTAX_CIS, the EQUALITY
comparison should fail.

It also appears that value_ncmp() in value.c has no references anywhere in
the openLDAP source tree, save for a definition in proto-slap.h. The
following fix the bug and remove the dead code:

From: "MCGARRAHAN, KENNETH L" <km4155@momail.sbc.com>

merged with autoconf branch

Initial revision

Import of FreeBSD LDAP 3.3 Port

Import of Umich LDAP 3.3

SLAPD compiles.  Needs LDBM work to link.

include portable.h

Moved ldap_ headers to include/ac or include/ldap

Import value_cmp fix from -devel.

Last commit message was incorrect.  Actual change was to ignore
empty value (to avoid crashing).  ITS#303

Fix -c vs -H typo (ITS#154)

Apply Hallvard's ctype 'unsigned char' fix from -devel.

Update copyrights for year 2002

fix ITS#1364, value_add empty value bug

Import latest from devel

Import from devel

Merge latest devel codes into releng 2 branch.
Remove back-perl, back-sql, back-tcl from branch as they have yet
to be updated.
Additional changes are needed prior to release of alpha4.

Merge in all devel changes since 2.0-alpha2.
Move OPENLDAP_REL_ENG_2_MP forward.

Merge in all -devel changes made since branch was created.

Fix value_normalize bug.  Must uppercase the dn.
Change no search candidates error to success.
'make ldbm' now works again!

Round two of referrals/aliases: WORK IN PROGRESS, may not compile!
Basic support for "named referrals", manageDSAit control.
Disabled alias support for now.  Will implemented "named aliases"
to replace current alias/suffix-alias support.

Adapt to use matching rules.

Ensure that substrings are normalized properly by the routines
provided with the equality matching rule.

Happy (belated) new year

value_find_ex() changes

malloc fixes and other misc cleanup

Misc changes from HEAD

Sync with head

Pth support, +oc, modules, and value find init

Sync with HEAD

Sync with HEAD, including
	- subclass indexing
	- bdb locker id fixes

Suck in HEAD changes since 2.1alpha

Happy new year!

First round of changes from HEAD
	backglue syncrepl context csn initialization
	SLAPI/syncrepl nextid interaction fix
	bind referrals fix
	ldapi:// sun_path fix
	add dnIsOneLevelRDN (this seems oldly named, RDNs only have one level)
	add entry_clean()
	SLAPI modify fix

Sync with HEAD

Sync with HEAD

Happy new year

Sync with HEAD

First rounded of changes in prep for 2.2.beta3

Happy new year! (belated)

import fix to ITS#5136

happy new year

use ch_realloc
left not-reached check in place for now

Code which doesn't hanlding allocation failure should use
ch_ routines, not SLAP_ macros

Misc changes from HEAD

Happy new year!

Fixed slapd modify/delete by ordered index issue

Sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD
rebuild configure

Sync with HEAD

Initial round of changes for 2.3 beta

Sync with HEAD

Happy New Year!

happy belated new year

Update copyright for next release

Warnings cleanup

Happy new year! (belated)

ITS#5153 from HEAD - sorted values

import fix to ITS#5136

Sync with HEAD for OL 2.4.5

Quick merge: everything from HEAD

Sync with HEAD