CVS log for servers/slapd/filter.c

Up to [OpenLDAP] / servers / slapd

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

do not return void (ITS#6820)

also handle RFC 4526 t-f filters in back-ldap (more about ITS#6814)

handle undefined filters in back-ldap (more about ITS#6814)

Catch ber_scanf errors properly

Happy New Year

plug leak when presence filter with undef attr (ITS#6635)

happy belated New Year

Fully parse undefined substring filters so they can be logged

Update copyright notices

eat all the substrings assertion if the attribute type does not support substrings matching (ITS#5803)

don't free and reuse filter structure; don't rewrite undefined filter values (ITS#5731,ITS#5732)

NULL out spurious text (ITS#5688)

don't denormalize invalid values (ITS#5386)

Happy New Year (belated)

More for ITS#5212 make conditional explicit

fix prev commit (ITS#5212)

de-normalize simple filter values consistently

fix previous commit (didn't have coffee yet :()

for consistency, always represent UUIDs correctly (ITS#5168; really, a de-normalize hook would help)

add helper for internal searchs for objectClass=*

this should never occur, but in case keep it readable

happy new year

fix filter structure leak (ITS#4794)

Fix prev commit

Use temporary AttributeDescriptions to prevent unbounded growth

ITS#3707 preserve filter input, allow (and ignore) undefined attributes

- use STRLENOF, looks cleaner
- in case a value is incorrectly empty (technically, it's null because
  that's how it's returned by the stringification function), make enough
  room to add the error string "(null)"
- in case a value is legitimately empty (see above), use it accordingly;
  for example, a filter "(entryDN=)" is valid, so it should be possible
  to stringify it like that.

ITS#4364 add filter_dup, don't use str2filter to dup filters.

Happy new year!

fix ITS#4283/4 segfaults

cleanup filter escaping

allow undefined attrs to be "proxied" (ITS#3959)

assert expects int. (int)<nonnull ptr/long> can be 0. Use assert(arg!=0/NULL).

Format fixes (%d<->%lu etc)

Rework substring error checking

Happy New Year!

Split Operation into Opheader and op

unifdef -UNEW_LOGGING

cleanup

ITS#3092: Rename sl_free() and friends to slap_sl_free()

cleanup

improve filter error logging in case of unknown attribute type

fix ITS#2901

Happy new year

Updated notices

Declare filter_escape_value_x() and make it static.

Fix computed filter inversion

Must have ';' between default: and '}'

remove dnPretty
rename dnPretty2 to dnPretty

Fix computed TRUE/FALSE filters

Fix undefined substring filters

Added sl_context() to return the context associated with an alloc'd ptr.
Improved ch_malloc/sl_malloc compatibility.

More memory context tweaks

More memory context tweaks

Minor cleanups

First cut at thread-local malloc. Only used by search() for now...
Needs work in normalizers, etc.

cleanup

#ifdef -DSLAP_NVALUES

Major API change - (SLAP_OP_BLOCKS) All request parameters are
consolidated into the Operation structure. All reply parameters
are consolidated into the new SlapReply structure. Most operations
now have identical call signatures... Changes are not #ifdef'd,
revert to -r NO_SLAP_OP_BLOCKS if necessary to back out.

value is parsed in place; minor cleanup

replace get_substring_filter with get_ssa()

SLAP_NVALUES: more fixes

Fix typos in last commit
Still chasing SLAP_NVALUES trashed filter bug

Rewrite filter routines to malloc() late.

SLAP_NVALUES: still chasing an extranous free... this just saves
an unneccessary malloc.  (Actually, we should likely use local
filter structure to read things into and then malloc/copy once
we're sure there are no errors.)

SLAP_NVALUES updates

Not sure why these asserts are failing...  too tired to figure it...
so #ifdef for now.

Add some additional error checking...
but haven't yet figured out why NVALUES crashes in test003

Use ch_malloc instead of malloc for unchecked allocations

improved filter mapping/rewrite; improved result rewriting; improved attribute/objectclass mapping configuration

SLAP_NVALUES: test003 now passes (with help of a substr mr hack)

SLAP_NVALUES:
	schema engine updated (but not schema routines so things don't run yet)
	nvalues mostly populated, enough for tests 0-2 to pass
	schema routines needs lots of work
	modify/mods codes needs lots of work

Remove values match v. filter struct field macro overloads
Use LDAP_SLISTs instead of per-struct list management for schema structs
misc cleanup and lint removal

Happy new year

fix typo in comment :)

remove #ifdef SLAP_FILTER_HASSUBORDINATES

unifdef -DSLAP_X_MRA_MATCH_DNATTRS

cleanup comments

- added the capability to filter based on hasSubordinate attribute
  to back-bdb, back-ldbm and back-sql (the latter with limitations);
- added handling of ":dn" attributes to extended rfc2254 filters
  and to matched value filter
- altered the behavior of get_mra() when a matching rule is given:
  now it checks whether it is compatible with the attribute syntax
  and, in case it is, the given mr is used.  In case of no type,
  the check is delayed when filtering

Coverted LDAP_LOG macro to use subsystem ID int values instead of string values

remove lint

ITS#1797 err used unit'd in Debug statement. (removed)

Matched Values implementation (ITS#1776) based upon submission
form Mikhail Sahalaev <M.Sahalayev@pgr.salford.ac.uk>.
Further work needed:
	add testxxx-matchedvalues
	rework ldapsearch(1) portion of patch to generalize use of options
---
Copyright 2001, Mikhail Sahalaev, All rights reserved.
This software is not subject to any license of University Of
Salford.

Redistribution and use in source and binary forms are permitted
without restriction or fee of any kind as long as this notice
is preserved.

move ldap_int_put_filter to ldap_pvt_put_filter
and other cleanup

Misc extensible match clean up.

Deprecate filter_print in favor of filter2bv.

Replace get_filter generation of fstr with filter2bv().

Fix typo

Validate filter and compare inputs

Renamed BVarray to BerVarray. Moved slapd:bvarray_{add,free} to
liblber:ber_bvarray_{add,free}.

Added LDAP_FILTER_EXT case to filter_free()

Use 'm' ber_scanf format where convenient

Update copyright statements

Minor cleanup

Change struct berval * to struct berval in various structures

Changed ma_rule_text to struct berval.
Changed get_filter to struct bervals

Clean up some symbol scoping

I should finish my morning coke before making my first commit of the day.
Fixes errors in prior commits.

(undefined=*) should precompute to False

Add undefined present filter bug fix

Moved AttributeDescription caching into main code:
   Changed AttributeDescription.{ad_cname,ad_lang} to struct berval everywhere
   Deleted ad_free() everywhere
   Added ad_mutex to init.c

The AttributeDescriptions are in a linked list hanging off of the
corresponding AttributeType.

plug substrings filter memory leak

Fix undefined filter parsing

Add some additional filter checks

fix format

More new logging (Behind NEW_LOGGING)

Extend MRA.  It now has a pointer to a MatchingRule, but a char
pointer is kept for messages and to tell a filter without rule
from one with an unknown rule.  It matters.

Fix a couple of bugs in debug output.

The beginning of extensible matches.  Do not use.

Remove lint.

restrictops, requires, disallow knobs; ssf acls; and misc other changes
man pages to follow...

Rename escape_value to filter_escape_value

Fix seg fault (test003).

Escape filter strings

Skip over unsupported tags

unifdef -DSLAPD_SCHEMA_NOT_COMPAT -USLAPD_SCHEMA_COMPAT

s/substring/substrings/

fix -USLAPD_SCHEMA_NOT_COMPAT

SLAPD_SCHEMA_NOT_COMPAT: allocate/deallocate f_sub as needed.

SLAPD_SCHEMA_NOT_COMPAT: Add more three value filter logic code

Const'ification
SASL mech removed from backend bind callback (as SASL is managed by frontend)
Changes to some backends are untested (as I don't have all dependent
  software install)

Remove lint

SLAPD_SCHEMA_NOT_COMPAT: numerous changes to syntax flags, mostly minor
	added new value_normalize() code
	need LDAPsyntaxes X- field support

SLAPD_SCHEMA_NOT_COMPAT: add framework for substr value normalization
	Calls value_normalize per substr component (like old code),
	likely should have/call substr_normalize which takes all components
		at once (to allow more sophisticated normalization)

SLAP_SCHEMA_NOT_COMPAT: add calls to dummy value_normalize()
SLAP_SCHEMA_NOT_COMPAT: Need to sort out normalization of substring components

Fix -USLAPD_SCHEMA_NOT_COMPAT

Remove Lint.

Fix desc not NULL bugs

Modify ava code to return error text
Filter code needs to be updated to properly handle soft errors.

bv2ad expects desc pointer to be NULL if unallocated

Rework root dse and other info entry codes to produce entry
to caller (do_search) such that info can be used by other
operations (ie: do_compare).
SLAPD_SCHEMA_NOT_COMPAT: Add additional code to support filters (needs work)

SLAPD_SCHEMA_NOT_COMPAT: need to set desc to NULL

SLAPD_SCHEMA_NOT_COMPAT: working cn=schema

Fix -USLAPD_SCHEMA_NOT_COMPAT bugs introduced in last commit

SLAPD_SCHEMA_NOT_COMPAT: basic filter parsing

Y2k copyright update

Fix debug messages

Reorder error detection based upon precedence

Replace do_*() return -1 with return SLAPD_DISCONNECT.
Only return SLAPD_DISCONNECT with a send_ldap_disconnect()
was called.
Add initial code for support predetermined filter results
when filter is undefined (or known to be true or false).

Another round of changes behind -DSLAPD_SCHEMA_NOT_COMPAT
plus these changes unhidden changes:
	remove now meaning --enable-discreteaci configure option
	fix ITS#451, slapd filters
	Add ber_bvecadd() to support above
	constify ldap_pvt_find_wildcard() and misc slapd routines
	renamed some slap.h macros
	likely broken something

Fix -DSLAPD_SCHEMA_NOT_COMPAT -DLDAP_DEBUG builds (still won't run)

Yet another round of SLAPD_SCHEMA_NOT_COMPAT changes...
Changes outside of #ifdef include three value filter processing.

Replace -DSLAPD_SCHEMA_COMPAT with -USLAPD_SCHEMA_NOT_COMPAT

Additional changes to migrate to new schema codes
Still not usable.

Put more old schema code behind SLAPD_SCHEMA_COMPAT (which still
MUST be defined).

Second round of schema changes
Revert normalization to matching rule per discussions with Julio.
May need separate normalization routines for stored value and asserted
value. Currently rely on passed in syntax/mr to allow "special" behavior.
Reworked filters to pass struct berval * instead of char *. (needs work)
Validation, normalization and matching needed.

Add OpenLDAP RCSid to *.[ch] in clients, libraries, and servers.
Replace old Id as needed (back-tcl).
Leave updating of contribWare to contributors (for now).

Add copyright notices.

Change 'unsigned long len' to ber_len_t in get_filter()

Add support for unsolicited notifications.

Remove old U-Mich v3.0 and OLD_LDAP_* crud.
Leave only LDAPv2+ and LDAPv3.

ber_int_t, ber_tag_t, ber_socket_t, ber_len_t
added lber_types.h.nt, lber_types.h.in
removal of NULLxxx internal macros (in favor of NULL).
ch_free added to slapd,slurpd/ch_malloc.c
#define free ch_free (should be removed after s/free/ch_free/g) in proto-slap.h
ch_malloc and friends use ber_memalloc and friends

Silence warnings: Remove unused variables. Enclose some initializers in in {}.

Fix double free of filter when bad.

Replace strdup() with ch_strdup() such that exit() will be called
if strdup fails.  This is better than not checking, but we should
add orderly shutdown.

Protoized, moved extern definitions to .h files, fixed related bugs.
Most function and variable definitions are now preceded by its extern
definition, for error checking.  Retyped a number of functions, usually
to return void.  Fixed a number of printf format errors.

API changes (in ldap/include):
  Added avl_dup_ok, avl_prefixapply, removed ber_fatten (probably typo
  for ber_flatten), retyped ldap_sort_strcasecmp, grew lutil.h.

A number of `extern' declarations are left (some added by protoize), to
be cleaned away later.  Mostly strdup(), strcasecmp(), mktemp(), optind,
optarg, errno.

Fix most `wider type truncated to int' bugs on OSF1 due to implicit decls:
 #include <stdlib.h>    to get malloc & co various places,
 #include <ac/string.h> to get strlen & co in (liblutil/setproctitle.c),
 declare ch_malloc & co (slurp.h), avl_find_lin (avl.h), Malloc (ud/edit.c).
Also changed ch_malloc & co from char* to void* functions.

1. extend aclgroup's to be able to specify objectClassValue and groupAttrName
2. update print_acl() a bit and call it during aclparse if LDAP_DEBUG_ACL

merged with autoconf branch

Minor cleanup

Merged LDAPworldCurrent (P1-10,13,15,16,19-22)
Cleaned up old rcs keyworld subs

Initial revision

Import of FreeBSD LDAP 3.3 Port

Import of Umich LDAP 3.3

changes from Terry Lambert

LDAPworld P9: SLAPD crashes with filter containing zero elements

Merge changes from LDAP_3_3+prerelease into BOOLEAN_LDAP

SLAPD compiles.  Needs LDBM work to link.

include portable.h

Use stderr instead of stdout

Import strdup() -> ch_strdup() change from -devel.

Update for Alpha3 from -devel as of OPENLDAP_DEVEL_981116.
Includes everything but ldapext & ldap.conf changes.

Mongo patch: changes from -devel from 981105 snap to present
    Changed LDBM default to sync on writes
    Added mail500 BOUNCEFROM patch
    Added dbcachenowsync option
    Fixed slapd/ldbm id2children bug
    Fixed slapd/shell newline bug
    Fixed whois++ get_dn leak
    Fixed DEC OSF1 (alpha) support
    Fixed r/w lock initialization on non-final Pthreads
    Fixed slapd/slurpd file unlock bugs
    Fixed slurpd string translation bug
    Fixed slurpd/st mutex unlock bug
    Moved detach() to -llutil
    Added lutil_passwd() to -llutil
    Autoconf:
        Fixed thread detection
        Removed gcc -traditional tests
        Changed --enable-dns to require --enable-referrals
        Added -lresolv tests for ldapd and LDAP_DNS
        Added basic ISODE checks
        Added pwd.h &  getpwuid() tests
        Added sys/resource.h test
    Updated NT support (now builds ud)
    Removed lint

Merge in fixes/minor enhancements from from -devel.

Import getfilter() double free() bug fix from -devel

Another round of BER type changes, plus
move AVL internals out of avl.h
change slapd's ch_malloc and friends to use ber_memalloc and friends.
Added ch_free and #define free ch_free in proto-slap.h.

Introduction of BER types (ber_int_t, ber_tag_t, ber_len_t, ber_socket_t)
and lber_types.h (NT version only, need to write configure support for other
platforms).   Changes to sources are likely incomplete and buggy.
This is a work in progress.

Defer normalization to later stages.

Fix ITS#2023,2027 ACL filters with substrings.

Update copyrights for year 2002

Import undefined present filter bug fix from HEAD

Plug leak of substrings filter_free()

Import undefined filter fix

Import additional filter checks from HEAD

Fix nameuid ACL bug and remove related lint

Import latest from devel

Import from devel

Merge latest devel codes into releng 2 branch.
Remove back-perl, back-sql, back-tcl from branch as they have yet
to be updated.
Additional changes are needed prior to release of alpha4.

Merge in all devel changes since 2.0-alpha2.
Move OPENLDAP_REL_ENG_2_MP forward.

Merge in all -devel changes made since branch was created.

compute absolute t/f filter

sync with head

First round of imports from HEAD

Fix typo

Misc changes from HEAD

match rule uses and other misc stuff from HEAD

Sync with HEAD

mostly new logging

Remove lint

Suck in latest changes from HEAD

Suck in HEAD changes since 2.1alpha

Happy new year!

Misc fixes including:
+       Fixed slapd set acl recursion (ITS#3140)
+       Fixed slapd entry2mods normalization bug (ITS#3144,3152)
+       Fixed back-ldap normalization bug
+       Fixed pcache cache_entries init bug (ITS#3150)
+       Fixed pcache consistency_check bug (ITS#3151)

Sync with HEAD as of 14-March-2004

Sync with HEAD

Sync with HEAD

Happy new year

Sync with HEAD

Merge in latest changes from HEAD

Happy new year! (belated)

fix previous commit

more about ITS#5168

happy new year

fix filter structure leak (ITS#4794)

From HEAD
+       Fixed slapo-syncprov/pache filter dup issue (ITS#4364)
+       Fixed slapo-syncprov playlog netries reset issue (ITS#4365)

Happy new year!

import ITS#4283/4 segfault fixes from head

Sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD

6814 cleanup (ITS#6820)

ITS#6814

Catch ber_scanf errors properly

Happy New Year!

ITS#6635

happy belated new year

Fully parse undefined substring filters so they can be logged

Update copyright for next release

ITS#5803

ITS#5731,ITS#5732

ITS#5688

ITS#5386

Happy new year! (belated)

More for ITS#5212 make conditional explicit

ITS#5212
Fix filter normalization

ITS#5192
ITS#5072
ITS#5168

fix previous commit

more about ITS#5168

Forced commit, prev was:
Import changes from HEAD
+ Helper for internal searches for objectClass=*
+ proxy cache fixes (ITS #5112, #5113, #5114)

/tmp/msg

Sync with HEAD for OL 2.4.5

Quick merge: everything from HEAD

Sync with HEAD