CVS log for servers/slapd/connection.c

Up to [OpenLDAP] / servers / slapd

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Catch ber_scanf errors properly

Happy New Year

ITS#6758 Avoid SlapReply reuse, simple cases.
Caller provides and reuses a SlapReply it does not read after
initialization.  So reinitialize or move the declaration inwards.
In case of refint, move the rs parameter into refint_repair().

ITS#6759: assert;Debug -> Debug;assert

ITS#6747 Fix LDAP_CONNECTIONLESS Debug(), warnings

happy belated New Year

ITS#6412, refix #6304 - only check for writes if sockbuf NEEDS_WRITE

connid is unsigned; offset real conns by maxrid + 1

Move connection state enums to slap.h to ease debugging

ITS#6304 retry if tls_accept() returns 1

ITS#6361 remove asserts

ITS#6276 wake up blocked writers if we're pausing

More for #6220, don't timeout idle connections when writetimeout is
set and idletimeout is not.

ITS#6220 don't check write timeouts when global_writetimeout isn't set

Fix Debug format in last commit

ITS#6189 delay resetting the SLAP_C_BINDING state until the Bind handler
has fully returned to the connection manager. This may result in
"deferring operation: binding" messages being logged again (ITS#3850) but
it should not cause any hangs.

More ITS#6104: mutex-protected check of o_cancel value from other thread

ITS#6056 partially revert ITS#5886, close sequencing was broken

ITS#6111 connection_state_closing() -> connection_valid()

Partially revert prev commit, leave rs->sr_err == SLAPD_ABANDON

ITS#6103 send cancelled response back to client

Add missing extended/intermediate handlers for fake connections

ITS#5836, add writetimeout keyword for timing out hung writers

check mutex in connection_write()

Revert prev commit, unnecessary

Use epoll in edge-triggered mode

Update copyright notices

Revert prev commit, better fix - make sure client conns are closed
as expected

Client connection might get closed implicitly

Fix prev commit, c_writers check should be mutex'd

ITS#5835 fix connection teradown when there are waiting writers

ITS#5886 fix epoll hangup handling

Revert prev commit

ITS#5835 tentative fix - remove bogus call to connection_close().
Note that with this change, all calls to connection_closing() and
connection_close() always occur in pairs - probably the two
functions should be collapsed into one.

Let the idletimeout check kill hung writers

ITS#5835 change some DEBUG_TRACE messages to DEBUG_CONNS for easier debug

improve previous commit (ITS#5814)

don't assert on unprotected data (ITS#5814)

ITS#5725: Don't enable connection for events twice.

ITS#5469 check earlier for write waiters

Warning cleanup: function ptr <=> void* at ldap_pvt_thread_pool_<set/get>key()

Happy New Year (belated)

rename ldap_pvt_thread_pool_setkey_x() to ldap_pvt_thread_pool_setkey() (as part of ITS#5309)

ITS#5259 fix sasl_auxprop_store to allow cleanup after bindop is gone

Streamlined Winsock connection management

Fix connection teardown

Fix test050

Forced commit: forgot to note that SLAP_LIGHTWEIGHT_DISPATCHER is
now unifdef'd.

Use per-thread slap_counters to eliminate lock contention

Concurrency tweaks:
  store conn->c_sd, don't use ber_sockbuf_ctrl to retrieve it.
  use per-thread free lists for operations, no mutexes needed.

re-sort funcs (and enums) in "logical" order

fix SASL ssf logging (ITS#5001)

thread pool data was accessed through the wrong type

Give OperationBuffer normal struct members instead of using
LBER_ALIGNED_BUFFER(OPERATION_BUFFER_SIZE), as discussed in ITS#4078.
Add a corresponding SyncOperationBuffer in overlays/syncprov.c.

Remove unused variables

ITS#4948: '#if <undefined macro>' -> '#ifdef' warning cleanup

Cleanup conditional arg in prev commit

ITS#4893 fix prev commit

ITS#4893 define LDAP_PF_LOCAL_SENDMSG in <ac/socket.h> if a message must
be sent to transmit client credentials. Buffer the message data.

cleanup struct declarations

Plug leaks

Added "slapd" rewrite map handler, connection_fake_init2 to use existing
tmpmemctx without reinitializing

Remove extraneous debug statements

Use thread keys to plug slapi leak in connection_fake_init()

connection_fake_init can leak SLAPI extensions.

logging cleanup

happy new year

Don't log EAGAIN returns from ber_get_next()

Fix connection_get race condition on Windows

In connections_shutdown - check for Uninitialized struct first, since
attempting to lock an unint'd mutex may crash on some platforms. And
there is no chance for an unint'd conn to get init'd while shutdown
is occurring, so the unprotected check of struct state is safe.

protect assertion behind mutex (test should be atomic anyway...)

Fix connections_shutdown()

give cleanup another chance to free the temporary callback (ITS#4771)

don't use conditionals in macro arguments (ITS#4769)

Fix typo in prev commit

Fix - failed Binds could leave a closing connection open.

Fix prev commit again (ITS#4722)

Fix typo in prev commit

Tweak prev commit, add more notes (re ITS#4667)

From rev 1.373, releasing the mutex means connection_close() may get called
from another thread. Drop the assert, just return instead.

ITS#4606 errno is not per-thread on WIN32, always use WSAGet/SetLastError
(with notable exceptions: ignore tests for EINTR which winsock never sets)

In connection_next, sockets may not be contiguous on Unix if syslog etc are
active. Just search to the end of the table, tracking the max isn't worth
the lock overhead.

ITS#4667 in connection_closing, release c_mutex to allow waiters
to clear out.

ITS#4667 fix assert in connection_next() for PENDING connections

move req2op selection into a helper

remove unnecessary assertion; add test for pending ops

add an assertion to track ITS#4659; minor cleanup

Move ber_sockbuf_free() to slapd_remove() to avoid using AC_SOCKET_INVALID

Fix prev commit

Move socket close into slapd_remove, don't close until after socket
is removed from daemon control.

cleanup

Fix idletimeout deadlock

Fixed version of rev 1.361

Revert prev commit, spoke too soon, close race condition came back.

Simplify connection mutexes

ITS#4525

Use ldap_pvt_thread_pool_tid()

ITS#4476 revert connection_write processing back into main thread

Warnings: Unused vars. funcptr=0, not =NULL. if(b=...) -> if((b=...) != NULL).

fix previous commit (ITS#4465)

fix bound check (ITS#4449)

add a cleanup handler for binds (ITS#4465)

Cleanup

Forced commit to correct prev. commit message
Prev commit included additional TXN changes (a work in progress)

Add link to FAQ entry on BDB tuning

more txn infrastructure

Some more txn infrastructure

cleanup callback freeing

Happy new year!

Create SLAPI object extensions in connection_fake_init()

Primitive handling of dontUseCopy (always error).

valgrind keeps complaining (it makes sense) but the bus error problem disappeared

ITS#4158 still more

ITS#4158 move SASL bind finalization to bind_cb.

fix num args in Debug()

Fix ITS#4151 - set sasl_bind_in_progress in bind_cb

ITS#4136 fix prev commit

Fix fastpath for internal clients (e.g. syncrepl) too.

Fix fastpath for single-op dispatching

plug one-time leaks

cleanup

Free bind callback

fix size of connection array (ITS#4131)

Partial fix for ITS#3850, stop spurious "deferring: binding" messages.
Make sure conn state is reset before reply reaches client. Hang still
occurs in RE22, not in RE23.

ITS#4108 fix another accept/read race condition

ITS#4108 Cleanup accept/close race conditions.

Cleanup, fix ITS#4120

Revise last commit

Fix TLS/SASL handling in new lightweight dispatcher

Move slapd_set_read before return
(likely wake should be after... hmmm....)

disable SLAP_SEM_LOAD_CONTROL by default, needs additional review/work
Misc. other cleanup

Revised lightweight dispatcher -- writers moved into worker threads
Presently spawns operations in separate thread to ease clr_read/wake handling.
Seems to perform reasonable well...

More cleanup

cleanup

Move CSN invocations to backends

cleanup

cleanup

Correct last commit message: lightweight listener (ITS#3975

Align Operation buffers using LBER_ALIGNED_BUFFER

Include "fd=.." in Statslog message "TLS established"

ITS#3983 fix connection_client_stop, must reset sockbuf

Add missing Statslog() statements (loglevel stats/stats2):
  "ABANDON", "STARTTLS", "CANCEL", "WHOAMI", "PASSMOD", "EXT", "INTERM",
  "TLS established", SASL and Extended Response "RESULT".
In Statslog output "conn=xx fd=yy closed", append the reason in
  "()" unless client or server closed the connection after Unbind.
Still missing Statslog output from a number of failed requests.

should fix the invalid free issue

Move most of SLAPI frontend into overlay

ITS#3549 don't queue Unbind requests

ITS#3671 must release conn->c_mutex to allow blocked writers to exit

<limits.h> cleanup && ITS#3643

Add conn->c_sasl_authz_dn, store SASL authzDN separately from authcDN

ITS#3549 allow one op to progress when a socket with writewaiters
becomes ready to write.

ITS#3549 cleanup abandon/cancel processing

Delete obsolete syncprovider stuff

ITS#3463 additional fix

Happy New Year!

fix comment

rework operations in a table-driven manner; better exception handling

fix previous commit (for compilers that require at least one statement after a label)

PROTOS fix

improve usability of global ovrlays for write operations; may need to anticipate SLAPI accordingly.  More work needed for add (overlays need to understand they're global and call slap_mods2entry() explicitly)

better fix to ITS#3433

Fix prev commit

Add fe_op_abandon, call it in connection_abandon()

More migration of syncrepl from frontend to syncprov overlay
define OPERATION_BUFFER_SIZE for dummy Operations

Split Operation into Opheader and op

Disable back-bdb native syncrepl support, enable syncprov overlay,
remove syncrepl stuff from Operation struct

Add the omitted part from the original buddy allocator commit

Dynamic control management

Revert ITS#3353 patch, it needs to be reworked.

ITS#3353 consolidate slapd globals into a single struct

preformat "conn=%lu op=%lu"

multiple precision with BIGNUM/gmp/ulong

lots of cleanup; few improvements; fix RDN selection bug when creating connection dynamic entries; rework entries ordering - now it's more intuitive and regular; optimize counters update

use GMP for multiple precision in counters

unifdef -UNEW_LOGGING

Remove unused variable

This patch fixes some subtle interactions between SLAPI and syncrepl. Due to
SLAPI always assigning connection and operation IDs of zero for internal
operations, such operations would cause a stale contextCSN to be returned from
slap_get_commit_csn(). As a result, SLAPI internal updates would be invisible
to replicas until an external update was made. Also, SLAPI internal operations
never called slap_graduate_commit_csn() which leaked pending CSNs.

Also included in this patch is a general cleanup of some of the SLAPI code.

Note that we need to use a separate mutex on conn_nextid to avoid a deadlock
where a post-operation plugin tries to acquire connections_mutex, having locked
the per-connection mutex, while the listener thread tries to acquire the
per-connection mutex (having locked connections_mutex). connection.c needs to
be fixed to acquire mutexes in the same order.

should fix ITS#3265

frontend stuff moved into a database structure, essentially to allow overlays to be processed before database selection; passes all tests (ITS#3080)

cleanup

SLAPD_DISCONNECT v -1 cleanup
misc other cleanup

cleanup

clear pagedresults_state if reusing an inactive connection; prepare for more consistent behavior of pagedResults control

ITS#3109 - added slap_tls_ctx

ITS#3092: Rename sl_free() and friends to slap_sl_free()

use BER_BVNULL

Silence warning

cleanup

Add connection_fake_init()

cleanup

Add c_conn_idx, to simplify external modules managing per-connection state

Don't defer abandon due to pending

ITS#2959: provide reason for deferring operation in log message
Also, took away abandon operations blank check against deferment.
Abandon must be deferred in some cases (such as when other operations
are pending) and should be deferred in some other cases (such as too
many threads).

ITS#2921, fix client connection handling for HAVE_WINSOCK

Happy new year

Misc code cleanup

Don't require slapi to be in the path - always include slapi/slapi.h

Move experimental built-in SASL behind SLAP_BUILTIN_SASL macro

Completely untested built-in EXTERNAL implementation
Needs identity mapping and proxy authorization support

First round of SLAPI cleanups - use slapi_int_XXX for internal functions
(slapi_x_XXX is still reserved for exported functions that are not part
of the SLAPI specification)

cleanup

unifdef -DLDAP_CONTROL_PAGEDRESULTS (as it is always defined)

Move SLAB_SIZE def to slap.h

Cleanup: Remove unused label 'no_co_op_free:' in connection_operation().

Updated notices

For previous, assert (writewaiter==0) in conn_destroy too.

Cleanup prev commit, assert if writewaiter != 0 in init

ITS#2832 init conn->c_writewaiter to 0

cleanup

1. Session history support
	- memory based session history to minimize sync traffic
	- when client is covered by a session history, then
      [add+delete] mode is used
	- when client cookie is not covered by the history because
      the cookie is too outdated and/or the history is truncated,
	  [add+present] mode is used
2. Sync cookie syntax : comma separated name=value pairs
	- csn=yyyymmddhh:mm:ssZ#0xSSSS#r#ssssr,sid=nnn

Code and logging cleanup

Fix retry on failure

Fix prev commit, don't timeout outbound connections

Add support for outbound connections in main listener.
Restructure syncrepl/persist to use outbound connection manager.

Fix prev commit

SLAPI fix - no-op when slapi_plugins_used == 0

ITS#2779, cache group ACLs per operation instead of per-connection

ITS#2684 keep psearch operations on the connection's active list so they
can be located by connection_abandon() during an unexpected close. Remove
the operations in bdb_abandon() etc.

Don't timeout slow-running operations

move c->c_n_ops_executing/completed to the right place

Initial support for pre/post read controls.
TODO:
	Fix transactional consistency
	Add client response control handling

ITS#2649, never defer Abandon requests

unifdef LDAP_SYNC and LDAP_SYNCREPL

Support for SLAPI plugin extensions API.

This API allows a plugin to associate arbitrary context with an
internal server object such as a connection or operation.

Some documentation is at:

http://enterprise.netscape.com/docs/directory/602/plugin/function.htm#1104211

LCUP primitive routines removed

Fix vrFilter compile error

Merge partial and intermediate responses

Fix LBER_OPT_MEMCTX behavior

ITS#2549, init memctx to NULL. Also reset ber memctx to NULL when freeing.

persistent search updates with recent changes

Fix some Statslog()s:  Add missing newlines. Print file descriptor as long.

ITS#2424 use two SASL contexts per session to conform to RFC 2222

Memory context tweaks for other ops

Memory context tweaks for Bind

More memory context tweaks

More memory context tweaks

More memory context tweaks

Minor cleanups

Eliminate getkey search

Just use a fixed size slab for now

First cut at thread-local malloc. Only used by search() for now...
Needs work in normalizers, etc.

silence warning

Consolidated slap_callbacks into one function. Removed send_search_result.

Major API change - (SLAP_OP_BLOCKS) All request parameters are
consolidated into the Operation structure. All reply parameters
are consolidated into the new SlapReply structure. Most operations
now have identical call signatures... Changes are not #ifdef'd,
revert to -r NO_SLAP_OP_BLOCKS if necessary to back out.

ITS#2389 - added conn_max_pending/auth config keywords to cap the number
of outstanding requests on a connection. Set rate limits for request
execution:
   no connection can have more than maxthreads/2 ops executing at once.
   a connection that is write-blocked will not execute any new ops.
   queued ops must drain before any new ops can execute.
If the queue exceeds the max_pending limit, the connection is closed.
...also fixed a bug where a connection was not marked active if it never
received a Bind.

Cleanup previous commit

struct co_arg is redundant, removed

ITS#2389 - stop reading requests on a conn if it has more than
connection_pool_max/2 operations already executing. May want to tune
this to a higher value, e.g. connection_pool_max - XX, etc. Fix in
result.c throttles the connection too late, all threads are already
consumed by the time the send buffer blocks.

ITS#2382 use ch_calloc

Fix ITS#2335, RFC1798 sequence layout was wrong.

Partial fix of ITS#2335, restore proper CLDAP msg format for LDAPv2

Cancel exop updates

Rework #ifdef'ing of expermental controls to ease release engineering
using LDAP_DEVEL (to indicate experimental) to enable experimental features
(true for HEAD unless LDAP_REL_ENG is defined)

LDAP Sync Operation (draft-zeilenga-ldup-sync) as a groundwork for an LDAP replication design

Intermediate Response

LDAP cancel misc patch

LDAP cancel operation

LDAPv3 over UDP disposition is now compatible with Active Directory
Stubs for PermitModify/NoReferrals controls; implementation coming soon

Happy new year

Revert previous, it was only masking the real problem. And caused more...

undef CONNECTION_INPUT_LOOP, use DATA_READY_LOOP. Seems to help prevent
hangs in heavy load situations.

SLAPI - Netscape plugin API for slapd - based on patch contributed by Steve Omrani <somrani@us.ibm.com> as ITS#2073

Fix ITS#2157, server should never attempt to unlink the client's socket.
It likely has no name anyway, and the client owns it after all.

Addition of servers/slapd/lcup.c and servers/slapd/back-bdb/lcup.c for persistent search

LCUP persistent search code drop

listener:
- use bervals for url and sockname
- pass connection_init() the listener struct pointer instead of each value
- don't copy them in the Connection struct 'cause they're not going to change
- define macros for legacy usage of c_listener_url and c_sockname

Misc cleanup

Remove c_sasl_bindmutex, Binds are already serialized.

Add a Connection pointer to the Operation.

Experimental cruft to propagate valid Operation to SASL callbacks.
If you have a better way, jupm on in...

Added thread-pool getkey/setkey functions

Revert previous commit

Don't strdup conn->authz into op, just reference directly. (Conn cannot
be freed until after all associated ops are freed.)

Coverted LDAP_LOG macro to use subsystem ID int values instead of string values

get data if ready

Deleted Connection->c_cdn. Use conn->c_dn instead...

Rework c_authzid_backend in preparation for sasl_setpass() support

ITS#1795 authid is uninit'd if tls_get_cert fails

Matched Values implementation (ITS#1776) based upon submission
form Mikhail Sahalaev <M.Sahalayev@pgr.salford.ac.uk>.
Further work needed:
	add testxxx-matchedvalues
	rework ldapsearch(1) portion of patch to generalize use of options
---
Copyright 2001, Mikhail Sahalaev, All rights reserved.
This software is not subject to any license of University Of
Salford.

Redistribution and use in source and binary forms are permitted
without restriction or fee of any kind as long as this notice
is preserved.

Changed ldap_pvt_tls_get_my_dn and ldap_pvt_tls_get_peer_dn to store result
in dn parameter and return a result code.

Changed dnX509peerNormalize as above. Added debug message on failure to
retrieve client DN.

Fix memory leak in previous commit

deleted sasl_external_x509dn_convert; X509 DNs are always converted to
normalized LDAP DNs now.

Changed dnDCEnormalize to dnX509normalize, added dnX509peerNormalize,
based on new ldap_X509dn2bv() etc.

ITS#1733 eliminate o_abandonmutex

ITS#1735 unused conn.c_uthc_backend, include ldap_pvt.h

don't count operations per request if back-monitor is not built

count initiated/completed operations divided per request

ITS#1708 ldap_pvt_tls_sb_ctx() et al

do not print -1 as %lu

Update control framework
Misc cleanup
NT updates

fix ITS#1671 and more

fix ITS#1660 (issue 1)

Fix ITS#1655, don't retrieve sd until we've checked for valid c_sb.

use ber_str2bv() instead of ch_strdup/strlen.

CLDAP fixes

Some misc cleanup

Changed Access.a_sockurl_pat, Connection.c_listener_url etc.
to struct bervals

Changed slap_authz_info.sai_mech to struct berval.
Changed sasl_* to use struct bervals.

Zap connection_internal_*

readahead is only needed on UDP, don't use it on TCP. (Save unneeded memcpy)

Changed conn->c_cdn to struct berval.

Update copyright statements

Use ldap_queue.h instead of <ac/queue.h>

Changed search attrs from struct berval ** to AttributeName *

Use queue-compat for Connection->c_ops,c_pending_ops

More str2rdn tweaks

Changed sai_dn, sai_ndn to struct berval. (Affects op->o_dn,o_ndn,
conn->c_dn,c_ndn, Access->a_dn_pat)

more cleanup from jon@symas.com

Eliminate unnecessary per-operation dn_normalize(o_ndn); it's already
done in do_bind() and there's space in the connection structure for c_ndn
already, just copy it.

Clean up some misplaced 'extern' declarations (should be headers)

minor cleanup

optimize number of calls to slap_get_time()

Added backend_group result caching.

More CLDAP tweaks, to differentiate between real LDAPv2 CLDAP and "other"
LDAP/UDP messages. Slapd marks received CLDAP messages as LDAP_VERSION2.
The client library can generate CLDAP queries if -Protocol 2 is chosen,
otherwise not. LDAPv2 CLDAP cannot query the slapd rootDSE, gets no reply.

Set protocol to LDAP_VERSION2 on UDP session.

Resurrection/rewrite of CLDAP (RFC1798 Connectionless LDAP).

Compile with -DLDAP_CONNECTIONLESS to use this code.
For slapd, use "-h cldap://" to listen on UDP.
For ldapsearch, use "-H cldap://" to query on UDP.
Client-side support is very minimal:
  no automatic timeout/retries
  no basedn wildcard expansion on results
  no support for specifying multiple servers at once.

Another round of TLS updates to support secure referral chasing

Add support for separate max incoming for anonymous and authenticated
sessions (defaults: 256K and 16M respectively).

Add simple configure support for sockbuf max incoming

Quick sb_max_incoming hack, should be configurable (likely
with differing anonymous vs authenticated values).

fix format

more new logging (finally), behind NEW_LOGGING

ITS#897, internal connections need to free their single operation struct.

label io as "ldap_"

Don't recursive lock connections_mutex in idle timeout routine

remove lint
update bdb codes

Fix build issues

Implementation of SASL authorization.

Add "allow tls_2_anon" to allow StartTLS to force session to anonymous.
Add "disallow tls_authc" to disallow StartTLS when session is authenticated.
Create and use connection2anonymous routine for consistency.

Minor change to connection error handling

Fix authz bug introduced by last change

Rework connection lock code to avoid unnecessary lock reaquire

Fix SSF ACLs

Experimental fix for deadlock

Don't drain after TLS failure.... causes busy forever loop

restrictops, requires, disallow knobs; ssf acls; and misc other changes
man pages to follow...

Minor typedef and other clean ups

needs ldap_pvt.h

Implemented ldap_pvt_tls_get_peer() for use with SASL/EXTERNAL.
Added ldap_pvt_tls_get_strength() - return encryption strength, for
use as a SASL session security factor.

Working SASL security layers!

Remove cruft

Fix typo

Store sasl callbacks in session handle so that they can properly freed.

Update SASL code to reuse context through life of session.
Replace 'negotiated' with 'interactive' bind
Add hooks for SASL/EXTERNAL
Disable SASL security layers
Rework SASL command line and config file parameters

s/enable-unix/enable-local/
s/LDAP_PF_UNIX/LDAP_PF_LOCAL/
s/AF_UNIX/AF_LOCAL/
s/PF_UNIX/PF_LOCAL/

Minor cleanup

Reworked thread code to better support thread-library specific
r/w locks and thread pools.  Hide internal structures (using
pthread'ish technics).  Place common code in threads.c.  Move
no-thread code to thr_stub.c.  Move thread pool code to tpool.c.
Removed setconcurrency call from initializer, added 'concurrency'
directive to slapd.  Tested code under pthreads, pth, and no-threads.

Removed active_threads count and associated mutex/cond.  Replaced with
 ldap_pvt_thread_pool_backload() as needed.  All tests run OK on pthre
ads (linux), cthreads, NT threads, and Pth.

Update PF_INET6 and PF_UNIX detection, both default to auto

~ NULL was a bad idea.

remove pointer v. int lint from ber_sockbuf_ctrl.

Use thread pool for operation threads.

Bug fix for new sockbuf code under NT.  Added mutex protection against
 deadlock in connection_resched.

remove lint

ITS#537: lber io rewrite from Gambor Gombas.
Copyright 2000 Gábor Gombás. All rights reserved.
This is free software. You may redistribute and use it under the same
terms as OpenLDAP itself.

Const'ification
SASL mech removed from backend bind callback (as SASL is managed by frontend)
Changes to some backends are untested (as I don't have all dependent
  software install)

SLAPD_SCHEMA_NOT_COMPAT: framework for value_match() and value_find()

Y2k copyright update

libldap/tls.c: change tls_verify_cb to no longer ignore verification errors.
This means a ldaps connection may drop before any LDAP protocol exchange
occurs (due to expired cert, unrecognized CAs, etc.).
  Change ldap_pvt_tls_connect to copy any TLS error string to ld_error upon
connection failure, otherwise client just sees "can't contact LDAP server."

slapd/connection.c: add flush/delay when SSL_accept fails, to allow any
TLS alerts we generated to propagate back to the client. (Which will then
be picked up by ldap_pvt_tls_connect on the client...)

SASL closer to working from frontend only, need to work through
states.

SASL code without backend support.   Should work with
external store, but not yet tested.  [Intent is to support
both in same server... may not be doable]

Print tag with SASL in progress operations error.

Move handling of operations errors due to submission of
non-bind requests while a multi-step SASL bind process
is under to connection.c.  Return LDAP_OPERATIONS_ERROR,
not LDAP_SASL_BIND_IN_PROGRESS.

Replace do_*() return -1 with return SLAPD_DISCONNECT.
Only return SLAPD_DISCONNECT with a send_ldap_disconnect()
was called.
Add initial code for support predetermined filter results
when filter is undefined (or known to be true or false).

Merged in preliminary support for Cyrus SASL library;
support for DCE slash-delimited, left-to-right DNs;
support for a domain socket transport (enable with
--enable-ldapi); and extensions to URL parsing to
support the latter transport.

Bug fix:  re-used Connection have TLS value for previous conn.

Slight modification to last commit to cast %ld args to long

Fix stupid "got <garbage> of 0 so far" debug message after ber_get_next.

In preparation for adding dn_rewrite()...
s/dn_normalize/dn_validate/
s/dn_normalize_case/dn_normalize/

Add OpenLDAP RCSid to *.[ch] in clients, libraries, and servers.
Replace old Id as needed (back-tcl).
Leave updating of contribWare to contributors (for now).

Some constification & lint removal

In previous commit - change strerror() to STRERROR().
Use strerror() if available.

Use strerror()

Remove misplaced asserts.  connection_resched changes connection state
to UNUSED without holding connections mutex.  It's not safe for
connection_init to check connection state until after acquires the
c_mutex.

Plug ber leakage:
result was leaking ber's in some error cases.  ber_flush now called
with no freeing so that caller of send_ldap_ber() can free its own ber.
c->c_currentber was also being leaked if connection was destory
current when a PDU input was outstanding.
Fixed ber_flush to free ber upon write only to file.

More CSRI malloc debugging support and destroy sockbuf fix.
Test008 now runs without leak.

Clean up debug messages.

Force to LDAPv3 until BIND

Minor cleanup:
Fix Statlog() formats, remove an implicit int, include <ctype.h> for isspace().

Add copyright notices.

Don't have time to finish SASL right now...  this is a work in progress
but is safely tucked away behind --with-cyrus-sasl.

Add limited LDAP_INVALID_DN_SYNTAX support.  dn_normalize{,_case}() now returns
NULL does not meet basic syntax rules.

ACL CHANGES:
  by <who> <access> changed to by <who>+ <access> (joined with AND)
  added peername=<regex> sockname=<regex> url=<regex>
  removed addr=<regex> (use peername instead).
replace dn_upcase with str2upper and str2lower.  Use where needed.

Backout the input exhaustion change, it loops.  Still looking for
the right way.

Move the input data exhaustion loop to connection.c from daemon.c
Let transport (TLS or somesuch) force reading or writing on
sockets even if the higher layers think otherwise.

Namespace changes
  added slap_ and ldbm_ to many structures
  added typedefs to many structures
  used typedefs
New main.c argument parsing with ldap url support (replacing -a address).
New sockaddr_in handling and support for multiple listeners.

(re)introduce o_connid such that STATS doesn't need c_mutex (which it
didn't bother to acquire)...

Clear c_needs_tls_acccept on ldap_pvt_tls_accept errors

Move calls to ldap_pvt_tls_accept to connection_read instead of
connection_init so that we get into the select() logic.
Make use of new flags in the connection.
BTW, and before I forget, it sort of works.  I have connected with
a Netscape client using a secure connection and did a failed
search (my test database is empty), but the trace looked correct.
Make sure you have your CA certificate in your Netscape preinstalled.
Otherwise, the connection fails with error 0xFFFFFFFF that is rather
uninformative.

connection_init now takes one more argument that indicates whether to
use TLS right away or not on that connection.

Add support for unsolicited notifications.

Abandon all operations upon receiving a BindRequest.

More bind changes to support SASL/DIGEST.
Added configuration support for "digest-realm <realm>" configure directive.
Added connection state and bind_in_progress fields to cn=monitor connection
attribute.

Add conn/op bind_in_progress flags such that operations can detect
if multiple step SASL binds are in progress.

Rework BER decoding with lieu of LDAPv3 controls (coming soon).
Add place holder for handling LDAPv3 extended operations (coming soon).

Reimplement connection counters.  Format of "connection" attribute
changed significantly.

Add framework for sasl and controls.

Remove old U-Mich v3.0 and OLD_LDAP_* crud.
Leave only LDAPv2+ and LDAPv3.

Added connection initialisation and destruction notification. Now backends can register functions in backend_info.bi_connection_init and backend_info.bi_connection_destroy that will be called when a connection is initialized or destroyed.

experimental connections_timeout_idle() implementation.

ber_int_t, ber_tag_t, ber_socket_t, ber_len_t
added lber_types.h.nt, lber_types.h.in
removal of NULLxxx internal macros (in favor of NULL).
ch_free added to slapd,slurpd/ch_malloc.c
#define free ch_free (should be removed after s/free/ch_free/g) in proto-slap.h
ch_malloc and friends use ber_memalloc and friends

initial commit of idletimeout code...  everything but the actual timeout.

Add test for resched state change in connection_get

check addr for NULL before copying

connection_get forgot to unlock c_mutex in not used case!

Resched changes struct state without lock to avoid deadlock.
Hence connection_get must recheck struct state after obtaining
c_mutex to detect close.

connection_get:
	Connection could be closed before acquiring connections_mutex.
	if c->c_struct_state == SLAP_C_UNUSED, return NULL.

Add additional assert in connection get for race debugging.

EXPERIMENTAL: move slapd_remove to connections_read/_write as they
acquire c_mutex.

Add Debug to help sort out race condition.

Initialize connection pointer to NULL else won't be able to
detect connection table full properly.

Fix typo in previous commit.

Add diagnostics.

move connection_close call from connection_input to connection_resched
to avoid accessing c_conn_state after close.

Make connection_first/next/done reentrant.

remove redundant memset 0 of connection entry after calloc.

Add comment concerning connections mutex.  Need to analysis
locking requires and possibly restructure locking.

Lock (connections_mutex) should be acquired by caller.

ldap.h:
 added comments
 removed LDAP_MAX_ATTR_LEN
 removed LDAP_COMPAT* from <ldap.h> but not code.
 move LDAP_DEFAULT_REFHOPCOUNT to ldap-int.h
 added experimental options macros
 added LDAP_CONTROL_REFERRALS macros
libldap:
 Replace ld_attrbuffer with per use allocated attributed.
 ldap_first/next_attribute attributes now must be freed (as per draft).
 unifdef -DLDAP_API_FEATURE_X_OPENLDAP_V2_REFERRALS

don't free connections[i]

method tag should be unsigned long.
connection assert should use s, not i.

Vienna Bulk Commit
This commit includes many changes.  All changes compile under NT but
have not been tested under UNIX.

A Summary of changes (likely incomplete):

NT changes:
	Removed lint.
	Clean up configuration support for "Debug", "Release", "SDebug",
		and "SRelease" configurations.
	Share output directories for clients, libraries,
		and slapd.  (maybe they should be combined further
		and moved to build/{,S}{Debug,Release}).
	Enable threading when _MT is defined.
	Enable debuging when _DEBUG is defined.
	Disable setting of NDEBUG under Release/SRelease.  Asserts
		are disabled in <ac/assert.h> when LDAP_DEBUG is not
		defined.
	Added 'build/main.dsp' Master project.
	Removed non-slapd projects from slapd.dsp (see main.dsp).
	Removed replaced many uses of _WIN32 macro with feature based
		macros.

ldap_cdefs.h changes
	#define LDAP_CONST const
		(see below)
	#define LDAP_F(type) LDAP_F_PRE type LDAP_F_POST
		To allow specifiers to be added before and after
		the type declaration.  (For DLL handling)

LBER/LDAP changes
	Namespace changes:
		s/lber_/ber_/ for here and there.
		s/NAME_ERROR/LDAP_NAME_ERROR/g
	Deleted NULLMSG and other NULL* macros for namespace reasons.
	"const" libraries.  Installed headers (ie: lber.h, ldap.h)
		use LDAP_CONST macro.  Normally set to 'const' when
		__STDC__.  Can be set externally to enable/disable
		'constification' of external interface.  Internal
		interface always uses 'const'.  Did not fix warnings
		in -lldif (in lieu of new LDIF parser).

	Added _ext API implementations (excepting search and bind).
		Need to implement ldap_int_get_controls() for reponses
		with controls.

	Added numberous assert() checks.

LDAP_R
	_MT defines HAVE_NT_THREADS
	Added numberous assert() checks.
	Changed ldap_pthread_t back to unsigned long.  Used cast
	to HANDLE in _join().

LDBM
	Replaced _WIN32 with HAVE_SYSLOG

ud
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).

slapd
	Made connection sockbuf field a pointer to a sockbuf.  This
		removed slap.h dependency on lber-int.h.  lber-int.h now only
		included by those files needing to mess with the sockbuf.
	Used ber_* functions/macros to access sockbuf internals whenever
		possible.
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).
	Removed FD_SET unsigned lint

slapd/tools
	Used EXEEXT to added ".exe" to routines.  Need to define EXEEXT
		under UNIX.

ldappasswd
	Added ldappasswd.dsp.  Ported to NT.  Used getpid() to seed rand().

nt_debug
	Minor cleanup.  Added "portable.h" include and used <ac/*.h> where
	appropriate.  Added const to char* format argument.

use mutex to protect connection in connection_destroy until task is complete

move socket.h before errno.h so EWOULDBLOCK is defined on NT

Winsock changes:
Centralize #define EWOULDBLOCK WSAEWOULDBLOCK to ac/errno.h
Move WSAStartup to slapd_daemon(), add WSACleanup() to match.

Don't destroy uninitialized connections...

Don't have connection_state_closing() lock connection.  Already locked
by callers.

Implement "quick" shutdown (similiar in behavior to shutdown
prior to connection management changes).  No "normal" (wait
for pending operations to complete) shutdown mode (yet).
Changes:
 Add connections_destroy() implementation to connections.c.
 Move connections_init() call to slap_daemon().
 Add connections_destroy() call to slap_daemon().
 Add connections_shutdown() implementation to connections.c.
	calls connection_closing()/connection_close() for each
	"in use" connection.
 Add connections_shutdown() call to slap_daemon_task().

Should clear the write flag upon closing.

Update state to closing early.

Modify connection_closing() to abandon operations and wake blocked writer.
Modify send_result to return if connection state is closing.
Modify do_abandon() to remove abandon'ed operation if pending.

Changes to support FreeBSD LinuxThreads port.  Namely don't rely
on errno not getting changed by Debug().  Likely a problem elsewhere.
Tests run okay, excepting concurrency has "no such object" problems.

NT port

Reenable counters.

Fix unlock bug in connection_read/write.  Fix connection_read() to
ignore input when connection is closing.

Improved "closing" handling.  Remove fd from read set when state
changes to closing.  Need to add protection against read set races.

Add trace to connection_get() to aid debugging.

PROTOTYPE: New connection management infrastructure designed to
remove race conditions on connection close.
BROKEN: various counters for dn=monitor.
Initial testing on FreeBSD (with and without pthreads) was successfull.
Have not yet tested preemptive threading environments.
Have not built against backends other than LDBM.

First cut at bind race fix.   Passes our test suite at least.

Initial check of connection states.  Have only implemented
SLAP_C_ACTIVE vs SLAP_C_INACTIVE.  Need to implement BINDING and CLOSING.
Added fields tracking pending (on bind) ops.  Could also be used to
implement per-connection thread limits.

Bugfix: Missing parens in `status = ldap_pvt_thread_create(...) != 0'