CVS log for servers/slapd/back-meta/search.c

Up to [OpenLDAP] / servers / slapd / back-meta

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

ITS#5421 drop ldap-int.h

Happy New Year

make sure matched is NULL when err=SUCCESS (ITS#6774)

no need for next control

use Paged Results when talking to targets (in response to ITS#6664)

ITS#6758 Reset dangerous REP_ENTRY_* flags.
If SlapReply.sr_un cannot contain an entry but does or soon may
contain another member than sru_search: Ensure nothing will see
leftover REP_ENTRY_* flags and try to clean up the "entry" there.

For ITS#5421: Also LBER_FREE() -> ber_memfree()

For ITS#5421: Remove ldap-int.h dependencies.
LDAP_FREE() -> ber_memfree(), msg->lm_ber -> ldap_get_message_ber(msg).

set rebind proc if needed and bind succeeds (ITS#6665)

minor cleanup

check return code (ITS#6643)

cleanup previous commit

don't risk leaving around client library error codes; try to return additional information

make sure bind credentials are consistent

allow to specify a per-database list of attributes that need to be always collected, even if not explicitly requested by clients (addresses ITS#6513)

happy belated New Year

use slab memory as much as possible

handle ordered values as appropriate (ITS#6516)

honor per-target tls/chase referrals/rebind as user (ITS#6190)

ITS#5977 fix typo

Better fix for prev

More for prev commit

ITS#5977 strip duplicates out of sorted attrs

ITS#5959, cleanup

ITS#5959 just drop illegal values, keep remainder if any. fix a_numvals.

ITS#5959 drop attrs with illegal values

do not let entryDN,subschemaSubentry slip into results when mapped out (ITS#5760)

fix previous commit (and ITS#5931: now back-meta allows to proxy syncrepl)

partially addresses an issue with ITS#5931: intermediate responses seem to be handled, as well as entries with controls; syncrepl does not work yet

do not assert when receiving intermediate response (partial fix to ITS#5931)

discard attribute values if attribute name cannot be parsed (ITS#5927)

ITS#5916 - externally callable functions are ldap_pvt, not ldap_int.

Allow alias dereferencing in search C API; use new API in proxy backends (ITS#5916)

Update copyright notices

fix alias deref in case of retry (ITS#5889)

canonicalize undef objectClass names (much like attributes; ITS#5681)

allow proxies to filter out search references (ITS#5593)

missing numvals (ITS#5481)

don't set sm_nvalues unless required (ITS#5375)

ITS#5355 use bi_extra instead of calling directly into back-ldap

Happy New Year (belated)

Attribute/Modification value counters

add support for session tracking (draft-wahl-ldap-sessio) to proxy backends requests

defer thread key retrieve as it might not be needed

merge attributes as required after mapping; avoid objectClass duplicates (ITS#5091)

return entry controls (partially fixes ITS#4591)

fix cleanup

check consistency of referrals and result code (ITS#4861)

improve async connect handling in case of errors

don't return adminLimitExceeded unless LDAPv3; use largest among candidates timeouts

implement search timeout when the remote server does not respond in the specified timeout

don't bail out if all targets are too lazy...

one more round of cached connections fixes/improvements

allow forcing abandon of search operations on a connection basis

better handling of critical conditions

fix response code mapping

better async connection and partial error handling

happy new year

- add support for "use-temporary-conn" much like back-ldap
- fix various connection creation/setup concurrency issues
- use shared connection when always idasserting (similar to ITS#4781)
- reduce the impact of schema mapping when not used (tnx to gprof)
- fix temporary/tainted connection leak in abnormal conditions

fix deadlock in case of bind error; propagate error as appropriate

add "report" to "onerr" modes: continue a search in case one target returns an error, and only propagate the error at the end

fix leak when 'rebind-as-user' is set (and client searches without prior bind)

rework compare
fix several minor issues with using dangling pointers and uninitialized data
fix caching of privileged connections
fix issues with unresponsive target failures during search

fix concurrency issue when binding before a search; rework and cleanup data structures (remove unused members)

rework timeout strategy a little bit

cleanup and streamline response handling

add LDAP_OPT_DIAGNOSTIC_MESSAGE; replace deprecated option names

don't mix return codes (ITS#4711)

more on clarification of special proxy identities and resilience to connection failure

fix ITS#4686 (retry with idassert)

minor cleanup

ld may legitimately be NULL if another operation freed it because of a failure while binding

fix arg format; better trace logging...

don't abandon binds in progress; rather unbind (ITS#4663).
Better logging for tracing

Entry/Attribute struct caching, to minimize malloc fragmentation
Note: this breaks LDAP_COMP_MATCH and SLAP_ZONE_MALLOC. But they
were probably broken already anyway.

invalidate idle connection if a candidate target does not respond for the duration of time limit...

give slapd a chance to play callback cleanup handlers when a search operation is abandoned (ITS#4645)

use bound credentials, if any

move retry into response handling (fix ITS#4594; partially addresses ITS#4591 as well)

port identity assertion to back-meta; share as much code as possible with back-ldap; misc cleanup

rework quarantine locking and so

cleanup

refine (and fix) back-meta handling of search initialization (ITS#4519)

trap an issue that occurred in odd conditions

misc cleanup

implement proxy quarantine (ITS#4569)

add cancel strategies (ITS#4560)

more checks

cleanup resource release

refine previous commits (don't leave bindings around)

add URI list resorting feature (ITS#4524)

fix previous commit

refine previous commit

parallelize dobind/search (ITS#4519)

make sure NULL pointers are not dereferenced

gracefully handle server down while initiating a search (ITS#4518)

pedantic cleanup

honor stop on error

only wait if no entry was returned

immediately return sizelimitExceeded if appropriate

more on recovery (ITS#4429)

seems to fix the equivalent of ITS#4429 in back-meta; had to give up per-target conn-ttl and idle-timeout

unifdef -DLDAP_NULL_IS_NULL

Happy new year!

use macros instead of numbers...

minor cleanup

more about sizelimit disclose issue in back-meta (ITS#4213)

Remove some unnecessary #ifdefs

use LDAP_SIZELIMIT_EXCEEDED; rework the return values of slap_send_search_entry(); silence a few warnings

check sizelimit in frontend (ITS#4213)

don't return matchedDN in the case described in ITS#4195

don't care about empty matched/text #ifdef LDAP_NULL_IS_NULL

backport write operation timeouts from back-meta to back-ldap; minor cleanup & silence warnings

allow per-target retry in searches; taint invalid connections; don't massage the pseudorootdn (ITS#4150)

fix size/time limit (ITS#4145)

eat up values of removed attrs

fix previous commit

fix handling of invalid DN-valued attrs (ITS#4107)

Fix snprintf() format

cleanup states/timeout handling in back-ldap/meta; add connection pooling and defer of pseudoroot bind to back-meta

fix previous commit; cleanup few 64 bit issues

use result of validation (ITS#4028)

pretty the DN as well

save target errors for later evaluation

prettify matchedDN; fix memory handling

allow undefined attrs to be "proxied" (ITS#3959)

normalize/pretty attributes when possible

more about matchedDN in back-meta (ITS#3944)

strip entryDN from search entries; frontend will reattach it :(

implement overlapping targets enhancement (ITS#3711)

fix "matched" return and return code (ITS#3944)

fix concurrency issues

add "onerr" flag

first round of provisions for back-config

preemptive time limit check in proxy backends

fix entry DN free

fix sizelimit interaction with glue overlay (ITS#3724)

don't bother about slap_dummy_bv

fix sizelimit bug (ITS#3720)

add support for "subordinate" scope

a bit more reworking and streamline; the change to the LAST_CONN test seems to eliminate the last LDAP_BUSY problems on the only machine that was showing it yet; please test

honor T-F filters (ITS#3706) and lots of cleanup

more cleanup in handling timeouts in ldap_result()

reset candidates when intentionally abandoning; consistently handle referrals

more on error handling reworking; should address ITS#3672 and ITS#3676

fix previous commit

add basic support for retry; protect internal bind behind mutexes; rework search, review candidate selection; minor cleanup.  Passes concurrency test036

slightly reduce malloc overhead; minor cleanup

fix memory leak (ITS#3669)

a) implement a new candidate selection procedure, based on target naming
   context checking and multiple match resolution via an internal search
b) move the candidate listing in a persistent per-thread buffer
c) fix bind procedure
d) minor cleanup

(a) and (b) should address ITS#2935; (b) and (c) should address ITS#3171

A test is also added

Always return SLAPD_ABANDON in response to op->o_abandon being set.

import selected improvements from back-ldap: use asynchronous Start TLS exop; allow propagating TLS if used in the original connection; minor cleanup

don't play with controls at bind; rather use the ldap_*_ext API

fix ITS#3498; some cleanup

fix ITS#3464

major namespace cleanup & minor fixes

Happy New Year!

works now

fix typos leading to memory issues

fix spurius noSuchObject when base=suffix

multiple precision with BIGNUM/gmp/ulong

unifdef -UNEW_LOGGING

move call to frontend API

slightly rework user/operational attributes handling (including fixing a bug in the logic of the previous change to backend_operational()); cleanup; more improvements to slapo-rwm and back-relay

res is already freed by ldap_parse_reference() (ITS#3190)

clarify no limits in (internal) searches

fix DN_SEPARATOR() and clarify its use

more on fixing escaped semicolon in normalized DN

use BER_BVNULL

exploit new frontend API 2 protocol error mapping

reset SlapReply flags

add "searchFilterAttrDN" rewrite context, and allow filterstring rewrite

move limits evaluation to frontend

initial round of fixes related to ITS#2986

handle filter computed in a more granular way (ITS#2977)

allow search limits based on groups (ITS#2967)

Happy new year

Clean up entry initialization

notices and acknowledgements

Moved proxy caching to overlay

notices and acknowledges

fix a_nvals according to back-ldap implementation (ITS#2716; at least part of it)

unifdef LDAP_CACHING

now LDAP_CACHING can be enabled again; not sure it works, though

remove dnNormalize2
replace calls to dnNormalize2 with calls to dnNormalize

Fix compilation errors (caching must still be undefined though)

return 'matched' only if all the targets didn't recognize the search base

works fine now

first cut at grouping rewrite/map stuff; needs work

silence warnings

propagate selected changes to back-ldap

remove more unnecessary args

new API; compiles if proxy is disabled

Commit of the Proxy Cache contribution (ITS#2062)
from IBM India Research (Apurva Kumar)
Code review by Pierangelo, Kurt, and Jong.

improved filter mapping/rewrite; improved result rewriting; improved attribute/objectclass mapping configuration

improve error handling

partially fix ITS#2310

clean up mapping api

fix objectclass mapping (to nothing)

fix ITS#2289 (don't use shared data for search state; use msgid instead)

Happy new year

improve limits handling and consistency; return "Admin limit exceeded" instead of "Unwilling to perform"

improve error messages

added referral support to back-{ldap,meta}; need to allow send_serch_reference() handle NULL entry pointer

better error handling when returning results

initialize struct timeval (fixes ITS#2014);
also, check for return value of dnNormalize2: if the returned
DN contains undefined attributes, the normalization fails.

rework connection pool handling (reduce amount of malloc)

fix previous commit

operationsError != Internal Error
hence, s/LDAP_OPERATIONS_ERROR/LDAP_OTHER/

fix ITS#1953

Coverted LDAP_LOG macro to use subsystem ID int values instead of string values

honor limits if below soft limit

ITS#1732 signed/unsigned integers

ITS#1733 eliminate o_abandonmutex

Mostly based on patches provided by Hallvard B. Furuseth

ITS#1677 - cast away const warnings
ITS#1678 - unsigned char args to ctype funcs
ITS#1682 - don't redefine ldap_debug
ITS#1683 - uninitialized vars
ITS#1703 - ldo_debug initialization
ITS#1705 - unsigned testing
ITS#1706 - socklen_t args
ITS#1719 - back-tcl update (other cleanups/fixes/improvements; yet untested)
ITS#1724 - integerNormalize/integerFilter/integerIndexer bugs
ITS#1725 - libdes not required

Implement back-null (/dev/null style backend)
Cleanup some misc warnings ("%lu" format, unused/uninitialized vars,
        ambiguous operator precedence)

Kurt, please regenerate configure

check on escaped rdn separator not needed any more

Renamed BVarray to BerVarray. Moved slapd:bvarray_{add,free} to
liblber:ber_bvarray_{add,free}.

Modify performance patch from Gertjan van Wingerde <gwingerde@home.nl>

Use 'm' ber_scanf format where convenient

Update copyright statements

more fixes/updates

more cleanup; doesn't work (fails on ldap_result, select returns -1)

lots of migration to struct berval; unfortunately it seems to be broken

Changed AttributeName back into an array instead of a linked list.
Fixed bug in do_search eating up controls.

Changed search attrs from struct berval ** to AttributeName *

Added dnPretty2/dnNormalize2 using preallocated destination berval

conversion to berval DN

More struct berval DN changes
decrease dependency on dn_validate/dn_normalize

Changed get_limits to struct berval*

Changed search attrs to struct berval **.
Use typedefs for all backend functions, to minimize work in future API
updates. (back-*/external.h will never need updating in the future.)

More struct berval DNs

Changed sai_dn, sai_ndn to struct berval. (Affects op->o_dn,o_ndn,
conn->c_dn,c_ndn, Access->a_dn_pat)

Changed AttributeType.sat_cname from char * to struct berval.
(will fix up back-bdb next.)

Moved AttributeDescription caching into main code:
   Changed AttributeDescription.{ad_cname,ad_lang} to struct berval everywhere
   Deleted ad_free() everywhere
   Added ad_mutex to init.c

The AttributeDescriptions are in a linked list hanging off of the
corresponding AttributeType.

use slap_str2undef_ad for unknown attributes

fix candidate selection based on scope

fix various result returning bugs, mostly related to candidate selction that results in invalid candidates (bug detected by Markus Storm <Markus.Storm@mediaWays.net>)

cleanup limits stuff in back-meta

enforces detailed search limits

semicolon after colon in goto labels; no C++ style comments; unused vars removed or #ifdef'd

minor cleanup; some error handling and log fixes

added new logging to back-meta

This is the commit of:
  - librewrite, for string rewriting; it may be used in back-ldap
    by configuring with '--enable-rewrite'. It must be used in
    back-meta. There's a text file, 'libraries/librewrite/RATIONALE',
    that explains the usage and the features. More comprehensive
    documentation will follow.
  - enhancements of back-ldap (ITS#989,ITS#998,ITS#1002,ITS#1054 and ITS#1137)
    including dn rewriting, a fix to group acl matching and so
  - back-meta: a new backend that proxies a set of remote servers
    by spawning queries. It uses portions of back-ldap and the rewrite
    capabilities of librewrite. It can be compiled by configuring
    with `--enable-ldap --enable-rewrite --enable-meta'.
    There's a text file, 'servers/slapd/back-meta/Documentation', that
    describes the main features and config statements.

Note: someone (Kurt?) should run 'autoconf' and commit 'configure' as
my autoconf version must be different: my configures contain a number
of differences and I didn't feel comfortable in adding them :)

Such in back-meta changes and sync slap.h with HEAD

First round of imports from HEAD

Search limit updates and other misc cleanup

Misc changes from HEAD

Add search continuation support

Sync with HEAD

Sync with HEAD

Sync with head

s/LDAP_OPERATIONS_ERROR/LDAP_OTHER/

mostly new logging

Suck in latest changes from HEAD

Suck in HEAD changes since 2.1alpha

fix sizelimit interaction with backglue (ITS#3724)

import fix to sizelimit bug (ITS#3720)

import fix memory leak from HEAD (ITS#3669)

Happy new year!

import fixes from HEAD

Fixed back-meta freeit bug (ITS#3190)

Changes from HEAD, including
+       Fixed back-bdb ignore deadlock bug (ITS#3188)
+       Fixed back-bdb pagedResults no end cookie bug (ITS#3161)
+       Fixed back-bdb pagedResults clear controls bug (ITS#3182)
+       Fixed back-bdb pagedResults ignore control bug
+       Fixed slapd internal search limit bugs (ITS#3183)
+       Added slapd -l USER/DAEMON options (ITS#3187)
+       Build environments
+               Fixed back-sql trace build

Sync with HEAD

Sync with HEAD

Suck in changes from HEAD (CHANGES needs ITS #s)
+       Fixed slapd syncrepl replication bugs
+       Fixed slapd slurpd update bugs
+       Fixed slapd inappropriate bind error disclosure bugs
+       Fixed slapd sun_path portability bug
+       Fixed slapd passwd referral memory leak
+       Fixed slapd sasl userdb checkpass bug
+       Added slapd Delivery Method syntax validation
+       Updated slapd overlay framework
+       Updated back-ldap backend
+       Updated back-meta backend

Sync with HEAD as of 14-March-2004

sync with HEAD (ITS#2977): do not return no such object if filter cannot be interpreted

Sync with HEAD

Happy new year

Sync with HEAD

Sync with HEAD

Merge in latest changes from HEAD

Changes from HEAD for beta

Happy new year! (belated)

import fix for ITS#5091

fix search cleanup

import fix to ITS#4861

import back-ldap/back-meta improvements from HEAD

line up with HEAD (ready for release)

better handling of critical conditions

import selected fixes/improvements to proxy backends from HEAD:

        Fixed slapd-ldap/meta privileged conn caching (ITS#4547)
        Fixed slapd-ldap chase-referrals switch (ITS#4557)
        Fixed slapd-ldap bind behavior when idassert is always used (ITS#4781)
        Fixed slapd-ldap response handling bugs (ITS#4782)
        Fixed slapd-ldap/meta privileged connections handling (ITS#4791)
        Fixed slapd-meta retrying (ITS#4594, 4762)
        Fixed slapo-chain referral DN use (ITS#4776)

happy new year

import fix to ITS#4711

merge fixes for ITS#4419,ITS#4429

Happy new year!

ITS#4115 fixes for back-meta/ldap

Sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD
Changes needs updating for release...

Sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD (need to update CHANGES)

Sync with HEAD
ready for 2.3.6?

Sync with HEAD

Sync with HEAD

sync with HEAD

Merge in recent changes to HEAD

Sync with HEAD

Merge from HEAD

Initial round of changes for 2.3 beta

Sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD

ITS#6758

More for ITS#5421

ITS#6625,ITS#5421

Happy New Year!

ITS#6774

ITS#6664

don't risk leaving around client library error codes; try to return additional information

don't risk leaving around client library error codes; try to return additional information

ITS#6665

minor cleanup

ITS#6643

make sure bind credentials are consistent

use slab memory as much as possible

ITS#6516

happy belated new year

ITS#6190

ITS#5977,ITS#5959 re-fix

More for ITS#5959

ITS#5959

ITS#5760
warnings fix

More for ITS#5927, ITS#5931

Fix ITS#5931 crasher bits

ITS#5916

Update copyright for next release

ITS#5889

ITS#5681

ITS#5593

ITS#5481

ITS#5375

ITS#5355

Happy new year! (belated)

ITS#5153 from HEAD - sorted values

Sync with HEAD for OL 2.4.5

Quick merge: everything from HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD