CVS log for libraries/libldap/result.c

Up to [OpenLDAP] / libraries / libldap

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Happy New Year

Cleanup prev commit

ITS#6744 - plug leak

typo in comment

remove #ifdef EAGAIN, EWOULDBLOCK (ITS#6603)

ITS#6625 concurrency patch from Doug Leavitt @ Oracle .com

ITS#6672 mutex cleanup

ITS#6569 return server's error code on Disconnect

happy belated New Year

ITS#6510 ignore referrals on Bind response

honor -1 timeout (ITS#6388)

ITS#5980 clear res_matched after successfully chasing referral

fix misc warnings

ITS#5853 restructure wait4msg / try_read1msg again. Consolidate
the two try_read1msg cases into one, bump refcnts to prevent
lconn's from being freed prematurely.

ITS#5896 don't return immediately on Intermediate responses

Update copyright notices

Warning cleanup: signed meets unsigned, remove assert(unsigned >= 0).

Avoid "label at end of compound statement" error of newer gcc

Protect errno values from Debug

ITS#5318 drop invalid msgids, cleanup msgid logging

Happy New Year (belated)

Cleanup spaces

Quiet request logging

dispose of connection when server down (related to ITS#5127)

fix format

add sub-second result timeout accuracy (for which is which; ITS#4963 with changes)

note ITS#4872 (forced commit)

apparently, time_t is unsigned in some systems

Timeouts should not be malloc'd

Fairly sure this is what the TIMEOUT option should always have been for

unsolicited responses shouldn't necessarily end the connection

fix previous commit

fix \& improve previous commit

implement client-side handling of RFC 4511 unsolicited responses and "Notice of Disconnect"

happy new year

don't leave dependencies on liblutil in libldap :)

Eliminate redundant checks in try_read1msg

ITS#4545 better fix. this code still needs cleaning up.

ITS#4545 when referral chasing is off, complete the request

fix warnings after previous commit

fix request/result abandon

fix endless loop in canceling child requests; cleanup

fix message (ITS#4717)

Misc LDAPbis comment update
Remove unnecessary ISOC notices

add ldap_int_discard(); use it in proxies (ITS#4717)

ITS#4606 errno is not per-thread on WIN32, always use WSAGet/SetLastError
(with notable exceptions: ignore tests for EINTR which winsock never sets)

better function name

keep count of requests in use

re-fix ITS#4405 (really start from the first conn)

some LDAP ASN.1 updates from 4511/4526

don't risk using dangling pointers when looping thru connections (ITS#4405)

s/fprintf/Debug/ (ITS#4553); lock ld_conn_mutex before accessing conn(s)

cleanup

cleanup

more cleanup

seems to fix referral chasing (ITS#4448)

unifdef -DLDAP_NULL_IS_NULL

Happy new year!

cleanup

silence warnings...

don't malloc empty strings for matched, error

Fix typo

Add LDAP* to debug messages to aid tracking

Fix ITS#3832 must mutex protect ld->ld_conns

Simplify lm_chain_tail handling, support LDAP_MSG_RECEIVED
Drop support for LDAP_MORE_RESULTS_TO_RETURN

silence warnings

treat TRUE/FLASE like SUCCESS; don't chase "" referrals

cosmetic changes (easier to inspect under gdb)

Read LDAPResult.resultCode & ModifyRequest.modification.operation
and send SortResult.sortResult as BER ENUMERATED, not BER INTEGER.

libldap: ldap_parse_extended_result, try_read1msg, build_result_ber,
ldap_parse_sasl_bind_result.  slapd: do_modify, send_ldap_controls.

little more about potential concurrency issues

plug leaks; cleanup

cleanup

(yet) another potential concurrency issue

assert expects int. (int)<nonnull ptr/long> can be 0. Use assert(arg!=0/NULL).

some (stupid) editors complain because 'new' is a reserved word in C++

Silence "unused variable" warnings

Linux updates tv on select() so always use a second copy

fix inconsistent indentation

Fix for ITS#3612

Happy New Year!

cleanup

Patch for fast synchronous search result processing

Revert last commit.
return 0 on timeout is actually correct.

ITS#3359: fix crash on recursive rebind following referral

unifdef -UNEW_LOGGING

ITS#3250 don't call select unnecessarily

ITS#2982 ok, we should NULL out lc after all...

ITS#2982 be sure to use nextlc when calling try_read1msg

Happy new year

Updated notices and acknowledgements

Back out previous commit - files apart from test.c

ITS#2777 - fix previous commit

Add Internet Society copyright notices

intermediate response fix

Merge partial and intermediate responses

Fix previous commit

Fix ITS#2335, properly parse multiple CLDAP responses in a single datagram
for both RFC1798 and MS CLDAP.

Change "goto leave" to "goto exit" to avoid DEC namespace pollution

Fix previous commit

More for re-entrant LDAP* handles. Works much better.

Added ld_req_mutex and ld_res_mutex to protect ld_requests and ld_responses
queues for multithreaded access to LDAP*'s. Also used to protect writes and
reads of ld_sb, respectively. Appears to work...

unifdef -DLDAP_NOCACHE

Rework #ifdef'ing of expermental controls to ease release engineering
using LDAP_DEVEL (to indicate experimental) to enable experimental features
(true for HEAD unless LDAP_REL_ENG is defined)

Intermediate Response

Happy new year

Plug memleak in previous commit

ITS#2153, make sure sockbuf buffer is empty before returning (-2) from
try_read1msg. Blind fix, problem was not duplicated/tested.

Add copy of OPL 2.0.1 and note in files which specifically refer
to 2.0.1 as to the location to the copy.

Fix ITS#1983, handle writing of large requests. Only one pending request is
allowed per LDAP* handle. It works, but needs review.

Coverted LDAP_LOG macro to use subsystem ID int values instead of string values

Consistently don't check for NULL session handle and other pointers.
Application is responsible for providing valid session pointers.

Fix previous commit, only zero out v3 refer_cnt if we got a SEARCH_RESULT.
If we got a SEARCH_REFERENCE, we need to keep going...

ITS#818, ITS#980, ITS#1234 ldapsearch/referral hang - set refer_cnt to 0
after v3refs have been chased. They are fully processed by the time we get
back, so we should just return the current result message to the caller.

ITS#1732 signed/unsigned fixes

Added LDAP_LOG messages

Use ber_scanf 'm' format for ignored UDP string

Some memory allocation cleanup.

Update copyright statements

Clean up some symbol scoping

More CLDAP tweaks, to differentiate between real LDAPv2 CLDAP and "other"
LDAP/UDP messages. Slapd marks received CLDAP messages as LDAP_VERSION2.
The client library can generate CLDAP queries if -Protocol 2 is chosen,
otherwise not. LDAPv2 CLDAP cannot query the slapd rootDSE, gets no reply.

Resurrection/rewrite of CLDAP (RFC1798 Connectionless LDAP).

Compile with -DLDAP_CONNECTIONLESS to use this code.
For slapd, use "-h cldap://" to listen on UDP.
For ldapsearch, use "-H cldap://" to query on UDP.
Client-side support is very minimal:
  no automatic timeout/retries
  no basedn wildcard expansion on results
  no support for specifying multiple servers at once.

chasing multi-level referrals core dumps (ITS#1346) bug fix
from Zachary Amsden <zach@mirapoint.com>.

Make some additional UTF8 public
Remove lint

Bug in chkResponseList loop (ITS#1047) from David @ Novell

Rework scope defaulting to only default scope for references.
Might break LDAPv2 partial results

Update handling of partial responses
Update comments
Update log messages
rename symbols per conventions

Revised ITS#799 fix from Steve Sonntag <vtag@novell.com>
 The problem is that the current code checks the queue inside
 the test for correct connecction state, so sometimes the queue
 doesn't get checked. This change moves the test outside
 the connection check.

References with empty dn (ITS#817)

ITS#799: chasing multiple referrals bug
Patch provided by Steve Sonntag <vtag@novell.com>

Don't assert on null

Remove CLDAP cruft

Improved but still broken client tools.

Added -llber 'N' ber_printf format which inserts a NULL if
an internal flag set.  Used for SEQUENCE testing.  Flag must
be set using debugger.  Modified ber_printf to use new format
were needed for extensibility testing.

Added first cut -lldap support for extended responses.
Modified ldapsearch(1) to handle v3 search references when not
chasing.  Also added extended/unsolicited notification handling
and extended partial response handling.  Changes include a
number of LDIF enhancements.

Fixed getpassphrase() returns NULL bugs

Memory leak in referral code (ITS#596)
Apply patch from Steve Sonntag <vtag@novell.com>

ITS#537: lber io rewrite from Gambor Gombas.
Copyright 2000 Gábor Gombás. All rights reserved.
This is free software. You may redistribute and use it under the same
terms as OpenLDAP itself.

A couple of minor fixes to LDAPv3 referral chasing

LDAPv3 referrals changes by Steve Sonntag @ Novell

s/0/LDAP_MSG_ONE/ per Steve's patch (ITS#542)

Y2k copyright update

ldap_result was losing messages when multiple msgids were queued,
and results were being returned one-at-a-time. Ugh, this cost me two
days, loss of hair, sleep, etc.....!

bug fixes for ldap_msgtype and ldap_msgid

Add OpenLDAP RCSid to *.[ch] in clients, libraries, and servers.
Replace old Id as needed (back-tcl).
Leave updating of contribWare to contributors (for now).

Cleanup:
Fix printf formats, remove unused variables, add missing prototypes in slapd,
add static/const, add some return types or change to void return type.

Fix LDAP_CONNECTIONLESS code rot

Minor cleanup of ldap_result().

ber_int_t, ber_tag_t, ber_socket_t, ber_len_t
added lber_types.h.nt, lber_types.h.in
removal of NULLxxx internal macros (in favor of NULL).
ch_free added to slapd,slurpd/ch_malloc.c
#define free ch_free (should be removed after s/free/ch_free/g) in proto-slap.h
ch_malloc and friends use ber_memalloc and friends

Clean up build_result_ber error handling.

Fix build_result_ber to construct a new ber and to set ld_errno appropriately.

Update comments to reflect RFC2251 specs.

s/<stdlib.h>/<ac/stdlib.h>/

Clean up LDAP_BOOL_GET and fetching via ldap_get_option().
Modify apitest to test for non-zero instead of LDAP_OPT_ON.

Add LBER_ and LDAP_ memory allocators/deallocators for internal
library use:
  LBER_ macros expand to system routines.
  LDAP_ macros expand to new ber_ allocators.

Add ber_ and ldap_ memory allocators/deallocator:
  ber_ routines are wrappers of LBER_ macros.
  ldap_ routines are wrappers of ber_ routines.

Removed safe_realloc() macro from various files.  This issue
(if an issue) should be resolved across whole package.

ldapmodify.c now uses ber_ allocators to resolve ber_bvfree()
vs. WIN32 multiple heaps issue.

These changes should facilate implementation of
  ber_set_option( NULL, LBER_OPT_MEMORY_FN, ...)
and
  ldap_set_option( NULL, LDAP_OPT_MEMORY_FN, ...).

Changed lc_conn to be a pointer to a BerElement to aid in state management.
Added validation to exposed opaque data structures (BerElement, Sockbuf,
and LDAP).  Added macros BER_VALID, SOCKBUF_VALID, LDAP_VALID.
Added ber_pvt_ber_bytes() and ber_pvt_ber_remaining() macros to hide
some ber internals.  These really should be handled by ber_get_option().

In try_read1msg, clear errno before calling ber_get_next, otherwise leftover
values will obscure EOF condition on closed sockets.

ldap.h:
 added comments
 removed LDAP_MAX_ATTR_LEN
 removed LDAP_COMPAT* from <ldap.h> but not code.
 move LDAP_DEFAULT_REFHOPCOUNT to ldap-int.h
 added experimental options macros
 added LDAP_CONTROL_REFERRALS macros
libldap:
 Replace ld_attrbuffer with per use allocated attributed.
 ldap_first/next_attribute attributes now must be freed (as per draft).
 unifdef -DLDAP_API_FEATURE_X_OPENLDAP_V2_REFERRALS

Assert pointer args

Add UL to more BER tags.

Add UL to LBER tags.

Vienna Bulk Commit
This commit includes many changes.  All changes compile under NT but
have not been tested under UNIX.

A Summary of changes (likely incomplete):

NT changes:
	Removed lint.
	Clean up configuration support for "Debug", "Release", "SDebug",
		and "SRelease" configurations.
	Share output directories for clients, libraries,
		and slapd.  (maybe they should be combined further
		and moved to build/{,S}{Debug,Release}).
	Enable threading when _MT is defined.
	Enable debuging when _DEBUG is defined.
	Disable setting of NDEBUG under Release/SRelease.  Asserts
		are disabled in <ac/assert.h> when LDAP_DEBUG is not
		defined.
	Added 'build/main.dsp' Master project.
	Removed non-slapd projects from slapd.dsp (see main.dsp).
	Removed replaced many uses of _WIN32 macro with feature based
		macros.

ldap_cdefs.h changes
	#define LDAP_CONST const
		(see below)
	#define LDAP_F(type) LDAP_F_PRE type LDAP_F_POST
		To allow specifiers to be added before and after
		the type declaration.  (For DLL handling)

LBER/LDAP changes
	Namespace changes:
		s/lber_/ber_/ for here and there.
		s/NAME_ERROR/LDAP_NAME_ERROR/g
	Deleted NULLMSG and other NULL* macros for namespace reasons.
	"const" libraries.  Installed headers (ie: lber.h, ldap.h)
		use LDAP_CONST macro.  Normally set to 'const' when
		__STDC__.  Can be set externally to enable/disable
		'constification' of external interface.  Internal
		interface always uses 'const'.  Did not fix warnings
		in -lldif (in lieu of new LDIF parser).

	Added _ext API implementations (excepting search and bind).
		Need to implement ldap_int_get_controls() for reponses
		with controls.

	Added numberous assert() checks.

LDAP_R
	_MT defines HAVE_NT_THREADS
	Added numberous assert() checks.
	Changed ldap_pthread_t back to unsigned long.  Used cast
	to HANDLE in _join().

LDBM
	Replaced _WIN32 with HAVE_SYSLOG

ud
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).

slapd
	Made connection sockbuf field a pointer to a sockbuf.  This
		removed slap.h dependency on lber-int.h.  lber-int.h now only
		included by those files needing to mess with the sockbuf.
	Used ber_* functions/macros to access sockbuf internals whenever
		possible.
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).
	Removed FD_SET unsigned lint

slapd/tools
	Used EXEEXT to added ".exe" to routines.  Need to define EXEEXT
		under UNIX.

ldappasswd
	Added ldappasswd.dsp.  Ported to NT.  Used getpid() to seed rand().

nt_debug
	Minor cleanup.  Added "portable.h" include and used <ac/*.h> where
	appropriate.  Added const to char* format argument.

Added support in liblber and libldap for partial reads, i.e. situations in
which only part of a LDAPMessage is available on a socket.

The server-code seemed to handle this correctly already, so I didn't touch
it.

My apologies for the hack in ber_get_next :-).

The new&improved Sockbuf. This adds the infrastructure on which
support for TLS and SASL will be build.

Please inform me of any problems.

Add simple copyright notice.

getentry.c: LDAP_RES_SEARCH_REFERENCE changes after fixing loop initializer.
references.c: fix same bug here.  need to implement parsing.
Still need to implement chasing in cldap.c/result.c

gcc -W cleanup

Initial LDAP_API_FEATURE_X_OPENLDAP commit:
  configure generates ldap_features.h based from ldap_features.h.in
  LDAP_REFERRALS -> LDAP_API_FEATURE_OPENLDAP_V2_REFERRALS
  LDAP_DNS -> LDAP_API_FEATURE_OPENLDAP_V2_DNS

Split out ldapoptions from struct ldap to facilate global options.
Add openldap_ldap_initialize() call to ldap_init/ldap_open/ldap_get/set_options.

Typo when !LDAP_REFERRALS

Added ldap_msgtype() and ldap_msgid()

Some gcc -W cleanup

struct ldap is now opaque to clients.
updated clients to use ldap_get/set_options
ld_options is renamed ld_booleans.  ldap-int.h has accessor macros.
updated libldap to use new accessor macros.

rename ber_init() to ber_init_w_nullc in preparation of LDAPv3 ber_init()

update ldap/lber headers towards ldapext-ldap-c-api-01

More files that didn't get merged properly.

removed lint

Added support for SLEEPYCAT DB2.
Modified main makefile to support local Make-common.  Builds file
from Make-common.dist.

Merge from LAMBERT branch

Backed up LDAP world P16, causes hang

Merged LDAPworldCurrent (P1-10,13,15,16,19-22)
Cleaned up old rcs keyworld subs

Initial revision

Import of FreeBSD LDAP 3.3 Port

Import of Umich LDAP 3.3

changes from Terry Lambert

LDAPworldP16: Search responses may not be returned properly

LDAPworldP15: Internal LDAP function rename

Merge changes from LDAP_3_3+prerelease into BOOLEAN_LDAP

update locking codes, remove old platform specific defines

The world compiles and links....
Need to sort out remaining ifnames and run testsuite.

SLAPD and tools compile and link!
LTHREAD still needs work.

VC++ Port: round 1

Update copyright of build environment, includes, and liblber/libldap.

Suck in latest changes from -devel.  Besides the usually lint removal,
the patch includes slapd malloc/free fixes in the slapd dn2entry code.

Update with latest from -devel.

ITS#1169, plug -lldap result leaks

s/NULLxxx/NULL
s/xxx/ber_xxx_t/

Introduction of BER types (ber_int_t, ber_tag_t, ber_len_t, ber_socket_t)
and lber_types.h (NT version only, need to write configure support for other
platforms).   Changes to sources are likely incomplete and buggy.
This is a work in progress.

Update copyrights for year 2002

Import multilevel referral chase bug fix from HEAD

Fix chk references bug

Update TLS codes (cert checking, fix crash condition)
Update ref chasing code

Forced commit:
Import latest referral chasing code from devel

Import UTF-8 fixes from devel
ITS#860 and others

Import updated referral handling codes
Fixes ITS#799 & ITS#817

ITS#800: remove ldap_msgfree(NULL) abort

Import latest changes from devel including removal of CLDAP and BDB2 cruft

Import misc changes from devel including client/tools
ldap_result() call fixes

Import from devel

Update to latest devel codes

Merge latest devel codes into releng 2 branch.
Remove back-perl, back-sql, back-tcl from branch as they have yet
to be updated.
Additional changes are needed prior to release of alpha4.

Merge in all devel changes since 2.0-alpha2.
Move OPENLDAP_REL_ENG_2_MP forward.

Import ITS#2982 fix from HEAD

CLDAP fixes
look harder for BDB 4.1

s/leave/exit/

Round 2 of changes from HEAD

Changes
    Updated libldap TLS certificate checking
    Updated client tool argument handling
    Updated test suite
    Updated liblutil detach handling
    Added libldap ldap_whoami routines
    Added liblber ber_flatten2 routine
    Added liblutil passwd sanity checks
    Fixed liblber PROTOS bugs
    Fixed ber_flush debug level
    Fixed libldap NULL cred bug
    Build Environment
        Check back-bdb requirement for BDB 4.1

ITS#2153: try_read1msg()/wait4msg() fix

Add OPLv2.0.1 location note

Sync with HEAD

mostly new logging

updates from HEAD

Suck in latest changes from HEAD

Resync with HEAD

Suck in HEAD changes since 2.1alpha

Backout fast sync patch

sync update
restart fix

Happy new year!

Revert last change

ITS#3359: Crash on recursive rebind following referral

Sync with HEAD

Reflect latest changes

Happy new year

Sync with HEAD

Changes from HEAD for beta

Suck in changes from HEAD

ITS#5580

Happy new year! (belated)

note ITS#4872 (forced commit)

apparently, time_t is unsigned in some systems

happy new year

ITS#4545 fix prev commit

ITS#4545 unchased referral fix from HEAD

ITS#4606 fix from HEAD - use sock_err* macros instead of errno

re-fix ITS#4405 (really start from the first conn)

don't risk using dangling pointers when looping thru connections (ITS#4405)

Misc library fixes from HEAD

Happy new year!

libldap updates from HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD
Ready for release?

Sync with HEAD
Changes needs updating for release...

Sync with HEAD (need to update CHANGES)

Sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD

Build + client side changes from HEAD

Sync with HEAD

ITS#6625,ITS#5421

Happy New Year!

ITS#6744

Fix typo in comment

ITS#6603

ITS#6672

ITS#6569

ITS#6510

happy belated new year

ITS#6388

ITS#5980

Warning fixes

ITS#5853

ITS#5896

Update copyright for next release

Warning cleanup: signed meets unsigned.

Avoid "label at end of compound statement" error of newer gcc

ITS#5580

ITS#5318

Happy new year! (belated)

cleanup

sync with head
ITS#5127

Sync with HEAD for OL 2.4.5

Quick merge: everything from HEAD

Sync with HEAD

sync with HEAD

Sync with HEAD

Sync with HEAD

Sync with HEAD