CVS log for libraries/libldap/os-ip.c

Up to [OpenLDAP] / libraries / libldap

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

do not hijack loop counter (ITS#6813; blind fix)

Happy New Year

ITS#6672 mutex cleanup

happy belated New Year

More for prev commit

Fix prev commit again, IPPROTO_TCP is the documented correct approach

Fix prev commit, it was not Linux-only as it claimed to be.

Introduce options to configure tcp-keepalive settings per connection. These
settings only work on Linux and are ignore when not supported (see
discussion on -devel)

fix misc warnings

ITS#5853 restructure wait4msg / try_read1msg again. Consolidate
the two try_read1msg cases into one, bump refcnts to prevent
lconn's from being freed prematurely.

Update copyright notices

Fixed typo

ITS#5815: Fix typo "#elif defined( MAXHOSTNAMELEN".

ITS#5369 SASL/GSSAPi refactoring from Stefan Metzmacher <metze@samba.org>
and Rafal Szczeniak <mimir@samba.org>, with minor cleanups

Pass LDAPURLDescs to connect functions instead of host/port

Connect callbacks need error recovery checks

Add LDAP_OPT_CONNECT_CB connection callbacks

ITS#5507: Set FD_CLOEXEC (close on exec) flag on LDAP file descriptors

ITS#5436: make htons() port number unsigned

Happy New Year (belated)

int -> ber_socklen_t for getsockopt()

Fix HP-UX crash: Replace socklen_t with ber_socklen_t from configure. ITS#4629.

Timeouts should not be malloc'd

remove unused code

Keep HAVE_POLL functionality inside its #ifdefs

ITS#4799 remove all references to kbind

First cut to truly async connect:
	- after connect(2), if async the connection is in "connecting" state
	- the first time a request is sent, "connecting" conns are polled
		- in case of success, the request is sent
		- in case still connecting, LDAP_X_CONNECTING is returned;
		  clients are expected to retry later
	- the "async" behavior must be explicitly enabled by setting
	  the LDAP_OPT_CONNECT_ASYNC option

"local" connections need work

happy new year

apply slightly revised patch for SO_KEEPALIVE (ITS#4708)

ITS#4606 errno is not per-thread on WIN32, always use WSAGet/SetLastError
(with notable exceptions: ignore tests for EINTR which winsock never sets)

Happy new year!

ITS#3440: (blind) fix for VxWorks inet_ntoa(3) leak,
use inet_ntoa_b(3) instead.

Don't set ndelay on socket connect if no timeout was specified

silence warnings

more on ITS#3808

Omit FD_SETSIZE check for Winsock

ITS#3614: prevent overflow when using result of sysconf(_SC_OPEN_MAX)

ITS#3524 (partial): reinit FDSETs

Happy New Year!

inet_addr cleanup

Avoid trashing client memory when socket is greater than FD_SETSIZE

Fix typo in select call

Move POLL_* macros to <ac/socket.h>

Catch POLLERR and POLLHUP.

Fix bug in last commit

Rough but working poll(2) implementation for -lldap

unifdef -UNEW_LOGGING

Instead of removing AI_ADDRCONFIG, place behind #ifdef (of undefined
macro).  Add comment indicating configure test needed.

Revert rev 1.92, AI_ADDRCONFIG is not a legal flag for getaddrinfo

basic poll(2) implementation for connect(2) (needs work)
Need to deal with selectinfo...

Mark areas needed poll(2) support with HAVE_POLL.

ITS#2992 Windows fixes from Alexey Melnikov

Happy new year

Revert #if 0

Misc cleanup

Updated notices and acknowledgements

use AI_ADDRCONFIG if possible to not lookup AAAA when no IPv6 addresses are configured

Make all debug output macros conditional on defined(LDAP_DEBUG).

Don't do (unsafe) DNS reverse lookups.
HEADS UP: May break some Kerberos deployments.

More ldap_connect_to_host() tweaks.

Fix builds when getaddrinfo is not detected but getnameinfo is.
This does not happen normally.

ITS#2459 (partial) fix.  Eliminate address parameter all together.
Need to look closely at the memcpy.  (It likely can be eliminated
as well.)

Added ldap_pvt_get_hname. Use instead of ldap_pvt_gethostbyaddr_a when
all you want is the hostname. Supports IPv6 addresses.

Remove lint

Happy new year

Fix typo in UDP logmsg

ITS#2221: getaddrinfo(3) not thread-safe on some platforms (namely
due to res_() routines).  Change all res_() dependent routines to
share same mutex.

Some more sockaddr_in v sockaddr_storage cleanup

ITS#2018: use sockaddr_storage
based upon patch provided by <thorild@Update.UU.SE>

Fix up restart code for EINTR

Use AF_INET instead of AF_UNSPEC when IPv6 disabled

Coverted LDAP_LOG macro to use subsystem ID int values instead of string values

Add monitorContext rootDSE attribute

Mostly based on patches provided by Hallvard B. Furuseth

ITS#1677 - cast away const warnings
ITS#1678 - unsigned char args to ctype funcs
ITS#1682 - don't redefine ldap_debug
ITS#1683 - uninitialized vars
ITS#1703 - ldo_debug initialization
ITS#1705 - unsigned testing
ITS#1706 - socklen_t args
ITS#1719 - back-tcl update (other cleanups/fixes/improvements; yet untested)
ITS#1724 - integerNormalize/integerFilter/integerIndexer bugs
ITS#1725 - libdes not required

Implement back-null (/dev/null style backend)
Cleanup some misc warnings ("%lu" format, unused/uninitialized vars,
        ambiguous operator precedence)

Kurt, please regenerate configure

Added LDAP_LOG messages

If port is zero, use default.

Remove lint

For Windows, use getsockopt() to retrieve error if connect() fails.
Don't use ldap_pvt_is_socket_ready() at all on Windows, it is
totally unneeded and getpeername() misbehaves on W2K.

Update copyright statements

Clean up some symbol scoping

Fix ntohs/htons issues

Rework DB_THREAD support.  CDB support needs reimplementation.

Rework getaddrinfo/inet_ntop not to segfault with ai_addr is (bogusly) NULL

Resurrection/rewrite of CLDAP (RFC1798 Connectionless LDAP).

Compile with -DLDAP_CONNECTIONLESS to use this code.
For slapd, use "-h cldap://" to listen on UDP.
For ldapsearch, use "-H cldap://" to query on UDP.
Client-side support is very minimal:
  no automatic timeout/retries
  no basedn wildcard expansion on results
  no support for specifying multiple servers at once.

TLS doesn't need ldap_host_connected_to()

move TLS ctx to lconn struct in prep for supporting TLS with referrals
need to rework cert check to use per lconn host name

Add HAVE_INET_NTOP

This patch replaces gai_strerror with AC_GAI_STRERROR in daemon.c and also
uses AC_GAI_STRERROR to report getaddrinfo failures in os-ip.c
-- Stig Venass

fix SOCKET_ERROR typos

Use SOCKET_ERROR instead of -1

move some vars to where they are actually used to avoid compiler warnings

Fix error in if() statement (==, not =)

Remove CLDAP cruft

Treat INADDR_LOOPBACK (as well as INADDR_ANY) as local host.

s/SAFEMEMCPY/AC_MEMCPY/
Use AC_FMEMCPY where appropriate (-llber)

Update SASL code to reuse context through life of session.
Replace 'negotiated' with 'interactive' bind
Add hooks for SASL/EXTERNAL
Disable SASL security layers
Rework SASL command line and config file parameters

Fix typo in last commit

Add 1st libldap IPv6 patch  (ITS#594) from Stig Venass.

Copyright 2000 Stig Venaas, UNINETT
All rights reserved.

Redistribution and use in source and binary forms are permitted
without restriction or fee of any kind as long as this notice is
preserved. The name of UNINETT may not be used to endorse or promote
products derived from this software without specific prior written
permission. This software is provided ``as is'' without express or
implied warranty.

Misc code cleanup.

Use LDAP_VFREE and friends.  Other misc code cleanup.

ITS#537: lber io rewrite from Gambor Gombas.
Copyright 2000 Gábor Gombás. All rights reserved.
This is free software. You may redistribute and use it under the same
terms as OpenLDAP itself.

Y2k copyright update

Fix error detection for NT

Initial implementation of Kerberos password verification for
simple bind via:
	{KERBEROS}principal
Code is disabled by default (for security reasons).  Use
--enable-kpasswd to enable.  Behind SLAPD_KPASSWD.
Reworked Kerberos detection and split out KBIND as independent
feature (--disable-kbind) (LDAP_API_FEATURE_X_OPENLDAP_V2_KBIND).
KBIND depends upon detection of KRB4 (or KRB425) support.  Detection,
building with eBones (as distributed with FreeBSD 3.4) okay, but
wasn't able to test as I don't have a K4 KDC handy.
--with-kerberos has a number of detection options... most likely
don't work properly.

Merged in preliminary support for Cyrus SASL library;
support for DCE slash-delimited, left-to-right DNs;
support for a domain socket transport (enable with
--enable-ldapi); and extensions to URL parsing to
support the latter transport.

Removed unused local var.

Do not attempt to obtain sizeof(sin_addr.s_addr) or &sin_addr.s_addr
as s_addr member of in_addr may be a bitfield.

Complain if setsockopt TCP_NODELAY fails

Add OpenLDAP RCSid to *.[ch] in clients, libraries, and servers.
Replace old Id as needed (back-tcl).
Leave updating of contribWare to contributors (for now).

Cleanup:
Fix printf formats, remove unused variables, add missing prototypes in slapd,
add static/const, add some return types or change to void return type.

Add const, to fix "cast away from const" warnings

Use -llber set_nonblock implementation.
Use ldap_int_tblsize instead of s+1 in select.
Need to eliminate all to read(2).

non-blocking connect needs special handling under Winsock.

Initial inet_aton() detection.

LDAP_OPT_NETWORK_TIMEOUT feature (ITS#239) from Lars Uffmann.
Needs a bit more work.
	- global net/api timeouts are not inherited on session creation.
	- need configure check for inet_aton() (coming soon)
	- ioctl/fcntl portability issues (should share implementation
		with lber routines)

Remove lint, remove YEAR_PEDANTIC macro, update comment.

Implement TCP_NODELAY on both client and server side.

Pass socklen_t* instead of int* to getsockopt, accept, getpeername, recvfrom

Forced commit to correct previous log, files were not changed:

Create ldap_int_tblsize and ldap_int_ip_init().
Initialize from ldap_int_initialize().

ldap-int.h

ber_int_t, ber_tag_t, ber_socket_t, ber_len_t
added lber_types.h.nt, lber_types.h.in
removal of NULLxxx internal macros (in favor of NULL).
ch_free added to slapd,slurpd/ch_malloc.c
#define free ch_free (should be removed after s/free/ch_free/g) in proto-slap.h
ch_malloc and friends use ber_memalloc and friends

s/<stdlib.h>/<ac/stdlib.h>/

Add ber_strdup(), remove ldap_int_strdup(), add LDAP_STRDUP macro
and ripple change through -lldap.

Add LBER_ and LDAP_ memory allocators/deallocators for internal
library use:
  LBER_ macros expand to system routines.
  LDAP_ macros expand to new ber_ allocators.

Add ber_ and ldap_ memory allocators/deallocator:
  ber_ routines are wrappers of LBER_ macros.
  ldap_ routines are wrappers of ber_ routines.

Removed safe_realloc() macro from various files.  This issue
(if an issue) should be resolved across whole package.

ldapmodify.c now uses ber_ allocators to resolve ber_bvfree()
vs. WIN32 multiple heaps issue.

These changes should facilate implementation of
  ber_set_option( NULL, LBER_OPT_MEMORY_FN, ...)
and
  ldap_set_option( NULL, LDAP_OPT_MEMORY_FN, ...).

ldap.h:
 added comments
 removed LDAP_MAX_ATTR_LEN
 removed LDAP_COMPAT* from <ldap.h> but not code.
 move LDAP_DEFAULT_REFHOPCOUNT to ldap-int.h
 added experimental options macros
 added LDAP_CONTROL_REFERRALS macros
libldap:
 Replace ld_attrbuffer with per use allocated attributed.
 ldap_first/next_attribute attributes now must be freed (as per draft).
 unifdef -DLDAP_API_FEATURE_X_OPENLDAP_V2_REFERRALS

Vienna Bulk Commit
This commit includes many changes.  All changes compile under NT but
have not been tested under UNIX.

A Summary of changes (likely incomplete):

NT changes:
	Removed lint.
	Clean up configuration support for "Debug", "Release", "SDebug",
		and "SRelease" configurations.
	Share output directories for clients, libraries,
		and slapd.  (maybe they should be combined further
		and moved to build/{,S}{Debug,Release}).
	Enable threading when _MT is defined.
	Enable debuging when _DEBUG is defined.
	Disable setting of NDEBUG under Release/SRelease.  Asserts
		are disabled in <ac/assert.h> when LDAP_DEBUG is not
		defined.
	Added 'build/main.dsp' Master project.
	Removed non-slapd projects from slapd.dsp (see main.dsp).
	Removed replaced many uses of _WIN32 macro with feature based
		macros.

ldap_cdefs.h changes
	#define LDAP_CONST const
		(see below)
	#define LDAP_F(type) LDAP_F_PRE type LDAP_F_POST
		To allow specifiers to be added before and after
		the type declaration.  (For DLL handling)

LBER/LDAP changes
	Namespace changes:
		s/lber_/ber_/ for here and there.
		s/NAME_ERROR/LDAP_NAME_ERROR/g
	Deleted NULLMSG and other NULL* macros for namespace reasons.
	"const" libraries.  Installed headers (ie: lber.h, ldap.h)
		use LDAP_CONST macro.  Normally set to 'const' when
		__STDC__.  Can be set externally to enable/disable
		'constification' of external interface.  Internal
		interface always uses 'const'.  Did not fix warnings
		in -lldif (in lieu of new LDIF parser).

	Added _ext API implementations (excepting search and bind).
		Need to implement ldap_int_get_controls() for reponses
		with controls.

	Added numberous assert() checks.

LDAP_R
	_MT defines HAVE_NT_THREADS
	Added numberous assert() checks.
	Changed ldap_pthread_t back to unsigned long.  Used cast
	to HANDLE in _join().

LDBM
	Replaced _WIN32 with HAVE_SYSLOG

ud
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).

slapd
	Made connection sockbuf field a pointer to a sockbuf.  This
		removed slap.h dependency on lber-int.h.  lber-int.h now only
		included by those files needing to mess with the sockbuf.
	Used ber_* functions/macros to access sockbuf internals whenever
		possible.
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).
	Removed FD_SET unsigned lint

slapd/tools
	Used EXEEXT to added ".exe" to routines.  Need to define EXEEXT
		under UNIX.

ldappasswd
	Added ldappasswd.dsp.  Ported to NT.  Used getpid() to seed rand().

nt_debug
	Minor cleanup.  Added "portable.h" include and used <ac/*.h> where
	appropriate.  Added const to char* format argument.

Add ioctl_t for arg type (Unix requires 'int', Winsock requires 'u_long').

The new&improved Sockbuf. This adds the infrastructure on which
support for TLS and SASL will be build.

Please inform me of any problems.

Updates regarding threads and names.

Add simple copyright notice.

-lldap reentrantancy improvements from Bart Hartgers <A.Hartgers@phys.tue.nl>
including use of ctime_r, gethostby*_r, etc..  Also reworked ldap_sort_entries
to be reentrant.
Need to add code to properly set LDAP_API_FEATURE_THREAD_SAFE.

add ldap_strdup and eliminate strdup in libldap

Make sure tblsize in initialized in ldap_new_select_info()
Regenerate configure.

Protoized, moved extern definitions to .h files, fixed related bugs.
Most function and variable definitions are now preceded by its extern
definition, for error checking.  Retyped a number of functions, usually
to return void.  Fixed a number of printf format errors.

API changes (in ldap/include):
  Added avl_dup_ok, avl_prefixapply, removed ber_fatten (probably typo
  for ber_flatten), retyped ldap_sort_strcasecmp, grew lutil.h.

A number of `extern' declarations are left (some added by protoize), to
be cleaned away later.  Mostly strdup(), strcasecmp(), mktemp(), optind,
optarg, errno.

Forced commit to correct previous log, files were not changed.

inet_addr() on OSF1 returns (unsigned int)0xffffffff, not int.
If it had returned int, the old code would have worked.

Check if inet_addr() returns 0xffffffff as well as -1.
It returns (int)0xffffffff on OSF1 which has 64-bit long, so
`unsigned long address; ... if((address = inet_addr(str)) == -1)' fails.

Initial LDAP_API_FEATURE_X_OPENLDAP commit:
  configure generates ldap_features.h based from ldap_features.h.in
  LDAP_REFERRALS -> LDAP_API_FEATURE_OPENLDAP_V2_REFERRALS
  LDAP_DNS -> LDAP_API_FEATURE_OPENLDAP_V2_DNS

Updated MSVC5 workspaces and projects.
Added ac/stdarg.h and updated liblber encode/decode to use it.

Some gcc -W... cleanup

update ldap/lber headers towards ldapext-ldap-c-api-01

replace with ac version

Whoops.

Add in WINSOCK2 ifdefs (ugh).

removed lint

Added support for SLEEPYCAT DB2.
Modified main makefile to support local Make-common.  Builds file
from Make-common.dist.

Merge from LAMBERT branch

Merged LDAPworldCurrent (P1-10,13,15,16,19-22)
Cleaned up old rcs keyworld subs

Initial revision

Import of FreeBSD LDAP 3.3 Port

Import of Umich LDAP 3.3

changes from Terry Lambert

LDAPworldP15: Internal LDAP function rename

Found the really, really stupid bug.  The SAFEMEMCPY macro
in string.h was hosed for memmove/memcpy cases.

Minor changes to support NT.

The world compiles and links....
Need to sort out remaining ifnames and run testsuite.

Modified NT changes to work under UNIX.

VC++ Port: round 1

Everything compiles....  but tests fail...

Update copyright of build environment, includes, and liblber/libldap.

Update 1.1alpha with latest build environment changes from -devel.
	includes libtool support
	includes select yield changes
	headers updates
Apply strdup() -> ldap_strdup() patch.

Update for Alpha3 from -devel as of OPENLDAP_DEVEL_981116.
Includes everything but ldapext & ldap.conf changes.

Update Alpha2 with NT4 changes.

More changes from -devel.

Take address of enclosing structure (in_addr), not member (s_addr).

Add TCP_NODELAY support to client side as well.

Introduction of BER types (ber_int_t, ber_tag_t, ber_len_t, ber_socket_t)
and lber_types.h (NT version only, need to write configure support for other
platforms).   Changes to sources are likely incomplete and buggy.
This is a work in progress.

Updated Winsock codes

Update copyrights for year 2002

Fix -lldap high port bug

Added better handling of getaddrinfo errors

Pull in a variety of bug fixes from HEAD including
	critical client control handling
	tls cert checking
	sasl/tls ref handling
	empty dn handling
Also removed ufn search (normally I would have left it
in but the merge was easier this way).

Import changes from HEAD including
updated MacOS X support
modlist2mods error reporting

Forced commit:
Update getaddrinfo usage

Import UTF-8 fixes from devel
ITS#860 and others

move some vars to where they are actually used to avoid compiler warnings

Import changes from devel including:
+       Fixed -lldap SASL got_max_ssf bug
+       Fixed -lldap TCP_NODELAY bug
+       Fixed -llutil sa_flags never set bug
+       Removed lint
plus
	clients/tools ldap_init() fixes
	-lldap SASL fixes
	binary syntax ";binary" transfer change

Import latest changes from devel including removal of CLDAP and BDB2 cruft

Import latest changes from devel

Import latest from devel

Update to latest devel codes

Merge latest devel codes into releng 2 branch.
Remove back-perl, back-sql, back-tcl from branch as they have yet
to be updated.
Additional changes are needed prior to release of alpha4.

Merge in all devel changes since 2.0-alpha2.
Move OPENLDAP_REL_ENG_2_MP forward.

Merge in all -devel changes made since branch was created.

ldap_connect_to_host portability fix...

Numerous minor fixes from HEAD, see CHANGES

Happy (belated) new year

Remove dead code and lint

Fix typo

updated ldif fixes
libldap getaddrinfo thread safety
ready for release

IPv6 sockaddr_storage bug

ipv6 buffer overflow fix

mostly new logging

Suck in changes from HEAD
    Fix slapd schema error alignment bug
    Update slapd SASL proxy policy code
    Update slapd require "strong" check
    Update back-bdb entry locking
    Add slapd disallow bind_simple_unprotected directive
    Add back-monitor added monitorContext support
    Add slapd IPv4/v6 only options
    Ass slapd SASL setpass support
    Remove lint
    Build Environment
        Add monitor backend test
        Update <ac/socket.h> SHUT_RDWR
        Fix SASL-less build issues
        Fix back-perl build issues

Suck in HEAD changes since 2.1alpha

Sync with HEAD

sync update
restart fix

Happy new year!

+       Fixed ldapsearch paged results size 0 bug
+       Fixed libldap SASL host connected to bug
+       Fixed libldap SASL proper sockbuf bug
+       Fixed libldap getaddrinfo hints portability bug

Sync with HEAD

Happy new year

(Partial) Sync with HEAD

Sync with HEAD

First rounded of changes in prep for 2.2.beta3

Changes from HEAD for beta

ITS#5507

Happy new year! (belated)

Import ber_socklen_t (ITS#4629) from HEAD

happy new year

ITS#4606 fix from HEAD - use sock_err* macros instead of errno

ITS#2708 keepalive patch

Happy new year!

Sync with HEAD

Sync with HEAD

Sync with HEAD
Changes needs updating for release...

Sync with HEAD

Sync with HEAD

Initial round of changes for 2.3 beta

Sync with HEAD
ready for 1alpha release

Sync with HEAD

Sync with HEAD

ITS#6813

Happy New Year!

ITS#6672

happy belated new year

More for prev commit

Fix prev commit again, IPPROTO_TCP is the documented correct approach

Fix prev commit, it was not Linux-only as it claimed to be.

Introduce options to configure tcp-keepalive settings per connection. These
settings only work on Linux and are ignore when not supported (see

Warning fixes

ITS#5853

Update copyright for next release

Fix typo

ITS#5815

ITS#5369

Add LDAP_OPT_CONNECT_CB connection callbacks
Pass LDAPURLDescs to connect functions instead of host/port

ITS#5507

ITS#5436 (really this time)

Revert prev commit, I did something wrong...

ITS#5436

Happy new year! (belated)

Sync with HEAD for OL 2.4.5

Quick merge: everything from HEAD

Sync with HEAD