CVS log for libraries/libldap/getdn.c

Up to [OpenLDAP] / libraries / libldap

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Happy New Year

happy belated New Year

partially revert prev commit

Minor cleanup in strval2str

Update copyright notices

Happy New Year (belated)

Allow utf-8 in AD-Canonical Names

Preliminary GNUtls support. gnutls.c will merge back into tls.c later.

happy new year

ITS#3755 silence strict-aliasing warnings

Fix strval2strlen end-of-string check. Otherwise passing in a string
without string[len] == '\0' causes assert in ldap_dn2bv_x.

More ldapbis cleanup

More LDAPBIS cleanup

Misc LDAPbis comment update
Remove unnecessary ISOC notices

Tone down dn2bv/bv2dn logging

Happy new year!

assert expects int. (int)<nonnull ptr/long> can be 0. Use assert(arg!=0/NULL).

Add missing "static" for functions declared static but defined non-static

fix ITS#3474

Happy New Year!

unifdef -UNEW_LOGGING

Cleanup

allow unescaped equals, according to draft-ietf-ldapbis-dn (ITS#3229)

log error string

always hexpair escape special chars (databases must be rebuilt)

allow LDAPv2 DN to be enclosed in <>

Use BER_BVNULL

'=' must be escaped (and escapable by '\') according to RFC2253 and draft-ietf-ldapbis-dn-XX (ITS#3009; must have slipped thru some changes long time ago...)

improve previous commit

append trailing slash to AD canonical if DN is exactly a domain (ITS#3000)

Happy new year

Updated notices and acknowledgements

Fix assignment of <char/int>* to unsigned <char/int>* and vice versa.

More careful checking of AVA flags

Fix Active Directory canonical name breakage

More memory context tweaks

Happy new year

Added new ldap_get_{dn,attribute,values}_ber functions for linearly
processing a search entry. Avoids O(n^2) ldap_get_values() behavior.

Fix ldap_X509dn2bv, OpenSSL gives us DN attributeTypes in EBCDIC

Coverted LDAP_LOG macro to use subsystem ID int values instead of string values

Cut back on the logging...

Add error handling cleanup

Consistently don't check for NULL session handle and other pointers.
Application is responsible for providing valid session pointers.

ITS#1797 silence uninit'd var warnings

Fix previous commit - must fully init newAVA

Added ldap_ucs_to_utf8s to convert ASN.1 T61STRING, BMPSTRING, and
UNIVERSALSTRING to UTF-8 format.

Rewrote ldap_X509dn2bv to check ASN.1 types and use above function.

  Added ldap_X509dn2bv()
  deleted ldap_pvt_tls_get_peer()
  changed ldap_pvt_tls_get_peer_dn() to use ldap_X509dn2bv()
  added ldap_pvt_tls_get_my_dn()

Mostly based on patches provided by Hallvard B. Furuseth

ITS#1677 - cast away const warnings
ITS#1678 - unsigned char args to ctype funcs
ITS#1682 - don't redefine ldap_debug
ITS#1683 - uninitialized vars
ITS#1703 - ldo_debug initialization
ITS#1705 - unsigned testing
ITS#1706 - socklen_t args
ITS#1719 - back-tcl update (other cleanups/fixes/improvements; yet untested)
ITS#1724 - integerNormalize/integerFilter/integerIndexer bugs
ITS#1725 - libdes not required

Implement back-null (/dev/null style backend)
Cleanup some misc warnings ("%lu" format, unused/uninitialized vars,
        ambiguous operator precedence)

Kurt, please regenerate configure

Added LDAP_LOG messages

C translator portability changes (ITS#1609)

disallow unescaped NULs in UTF-8 string values

Use memchr, not strlen, to look for embedded NULs.

Add embedded NUL check.  This is one case where we don't want to
be liberal in what we accept.

Check for NULs in DNs.

minor cleanup

honor the ber_len field to allow to exploit ldap_bv2[r]dn to handle DNs embedded in longer strings ...

use ldap_bv2[r]dn and turn ldap_str2[r]dn into wrappers

prepare for ldap_bv2dn()

#if 0 RDN debugging

Misc. DN fixes and cleanups, namely don't muck with AVA_BINARY values
Also, pass empty_bv when bv_val is NULL.

fix assertion

don't auto-detect DCE form; assert the UTF-8 charlen is legal

Added LDAP_UTF8_CHARLEN2() to validate shortest possible encoding
of UTF8 string. (Returns charlen if valid, 0 if not.)

make temporary RDN and AVA arrays rescalable if needed

quick fix that in pretty mode escapes with hexpair the specials ',', '+' and '\'

revert previous commit: do accept '\00'

accept '\<special>' anywhere in the string

fix behavior on improperly escaped illegal hexpair; do not accept '\00'

Minor const'ification cleanup

Passes last test (empty value); also passes many of the invalid DN tests if liberal parsing is allowed

fix non-printable flag detection; improve dn test (passes all but last in http://www.openldap.org/ietf/ldapbis/dn.txt)

fix domain generation for UFN

Update copyright statements

Use LDAP_FREE instead of free

Add LBER DN format flag (no code yet).
Return API result codes, not protocol result codes.

Even larger TMP_SLOTS

Renamed parse_numericoid to ldap_int_parse_numericoid since it is
no longer static. Moved declaration to ldap-int.h and removed extern
from getdn.c

Rework filter code
Misc cleanup / lint removal

Fix ldap_str2rdn, make sure to update progress pointer; don't
free attrType since we never allocate it

Minor fix for LDAP_DN_IS_RDN_DC macro

More str2rdn tweaks

Reorganize LDAPAVA allocation layout

remove useless function

Changed LDAP_AVA struct berval * to struct berval.

Fix memory leak in ldap_explode_dn

Made LDAP_UTF8_CHARLEN/ldap_utf8_charlen table-driven.

ldap_str2rdn() can parse without allocating a LDAPRDN* (not very clean, though); used by dn_rdnlen

Added ldap_dn2bv and ldap_rdn2bv

cleanup

More struct berval DN changes
decrease dependency on dn_validate/dn_normalize

hex escape everything requires escape (uncomment #define PRETTY_ESCAPE to revert to previous behavior)

better rdn exploding

bug in explode dn (caused most test failures when requesting client-side sorted results)

Some minor bugs for dntest ""

cannot assert la_private == NULL on free

Delete USE_LDAP_DN_PARSING

Minor cleanup, rename ldapava_free_*() routines and
don't expose symbols of ava helper routines

least escaping in dnPretty (hope my wife doesn't catch me in front of the laptop :)

small bug exploited by malformed DCE format

from jon@symas.com - misc Windows cleanup

reworked internal stuff

now dnValidate loops thru each value; added private member to LDAPAVA to hold the attribute description

liberally accept many LDAPv2/LDAPv3 stuff in DN (quoted parts, ';' as rdn separator and so); enforce exact case match of normalized dn in dnMatch (let's see what happens ...); fix a ldapava_free_rdn bug

reimplement dn_validate/normalize/(match) using the ldap_str2dn/dn2str stuff; need to #define USE_LDAP_DN_PARSING

Minor cleanup

small improvements and fixes; now honors ';' as rdn separator in LDAPv2 mode

fix bug in previous commit

struct berval * instead of char * in ldap_ava struct; minor cleanup

moved rdn parsing in a dedicated routine, ldap_str2rdn(), that can be used directly; now ldap_rdn2str() handles all the formats

More compliant version of str2dn/dn2str;
may need optimization;
uncomment #define USE_LDAP_DN_PARSING in libraries/libldap/getdn.c
to enable its use.
The ava/rdn/dn handling routines (append, insert, free and so) must
be made available thru declaration in some header.

enhanced dn parsing; see libraries/libldap/dntest for a 'demo'. Need to define USE_LDAP_DN_PARSING to override usual ldap_dn2ufn and so, and PARSE_UTF8 to parse attribute values as utf-8

handle lead/trail escape chars in LDAPv2/LDAPv3; change misleading name of AVA type modifier

skeleton of ldap_str2nd/dn2str; works with most of the simple cases, but there's much to do with unicode, I think

honors multiple type/value in rdn when generating ufn

Fix up some free'ing.

modify ldap_dn2ufn() to return completely typeless UFNs
hide rest of UFN code behind #ifdef LDAP_UFN in preparation
for eventual removal.

s/SAFEMEMCPY/AC_MEMCPY/
Use AC_FMEMCPY where appropriate (-llber)

Fix uninitialized var bug.

Remove support for DNS DNs (not to be confused with X.500 DN using
domainComponents (DC)).

Y2k copyright update

fix = vs == bug

Fix bugs in UTF-8 code.  Apply to getdn and charray.

Merged in preliminary support for Cyrus SASL library;
support for DCE slash-delimited, left-to-right DNs;
support for a domain socket transport (enable with
--enable-ldapi); and extensions to URL parsing to
support the latter transport.

Add OpenLDAP RCSid to *.[ch] in clients, libraries, and servers.
Replace old Id as needed (back-tcl).
Leave updating of contribWare to contributors (for now).

Fix last commit.  Should not have deleted assignment to p away.

Implement ldap_dn_normalize and friends.  Should be used by clients
to validate input dn's BEFORE sending dn's to server.
Also fixed getfilter to use REG_EXTENDED|REG_NOSUB.  (and fixed one
case where REG_BASIC was still used).
s/strdup/LDAP_STRDUP/
Added ldap_pvt_str2lower/upper

Fix LDAP_CONST->const in explode_name(), it failed when LDAP_CONST was empty.

ber_int_t, ber_tag_t, ber_socket_t, ber_len_t
added lber_types.h.nt, lber_types.h.in
removal of NULLxxx internal macros (in favor of NULL).
ch_free added to slapd,slurpd/ch_malloc.c
#define free ch_free (should be removed after s/free/ch_free/g) in proto-slap.h
ch_malloc and friends use ber_memalloc and friends

s/<stdlib.h>/<ac/stdlib.h>/

Add ber_strdup(), remove ldap_int_strdup(), add LDAP_STRDUP macro
and ripple change through -lldap.

Add LBER_ and LDAP_ memory allocators/deallocators for internal
library use:
  LBER_ macros expand to system routines.
  LDAP_ macros expand to new ber_ allocators.

Add ber_ and ldap_ memory allocators/deallocator:
  ber_ routines are wrappers of LBER_ macros.
  ldap_ routines are wrappers of ber_ routines.

Removed safe_realloc() macro from various files.  This issue
(if an issue) should be resolved across whole package.

ldapmodify.c now uses ber_ allocators to resolve ber_bvfree()
vs. WIN32 multiple heaps issue.

These changes should facilate implementation of
  ber_set_option( NULL, LBER_OPT_MEMORY_FN, ...)
and
  ldap_set_option( NULL, LDAP_OPT_MEMORY_FN, ...).

Vienna Bulk Commit
This commit includes many changes.  All changes compile under NT but
have not been tested under UNIX.

A Summary of changes (likely incomplete):

NT changes:
	Removed lint.
	Clean up configuration support for "Debug", "Release", "SDebug",
		and "SRelease" configurations.
	Share output directories for clients, libraries,
		and slapd.  (maybe they should be combined further
		and moved to build/{,S}{Debug,Release}).
	Enable threading when _MT is defined.
	Enable debuging when _DEBUG is defined.
	Disable setting of NDEBUG under Release/SRelease.  Asserts
		are disabled in <ac/assert.h> when LDAP_DEBUG is not
		defined.
	Added 'build/main.dsp' Master project.
	Removed non-slapd projects from slapd.dsp (see main.dsp).
	Removed replaced many uses of _WIN32 macro with feature based
		macros.

ldap_cdefs.h changes
	#define LDAP_CONST const
		(see below)
	#define LDAP_F(type) LDAP_F_PRE type LDAP_F_POST
		To allow specifiers to be added before and after
		the type declaration.  (For DLL handling)

LBER/LDAP changes
	Namespace changes:
		s/lber_/ber_/ for here and there.
		s/NAME_ERROR/LDAP_NAME_ERROR/g
	Deleted NULLMSG and other NULL* macros for namespace reasons.
	"const" libraries.  Installed headers (ie: lber.h, ldap.h)
		use LDAP_CONST macro.  Normally set to 'const' when
		__STDC__.  Can be set externally to enable/disable
		'constification' of external interface.  Internal
		interface always uses 'const'.  Did not fix warnings
		in -lldif (in lieu of new LDIF parser).

	Added _ext API implementations (excepting search and bind).
		Need to implement ldap_int_get_controls() for reponses
		with controls.

	Added numberous assert() checks.

LDAP_R
	_MT defines HAVE_NT_THREADS
	Added numberous assert() checks.
	Changed ldap_pthread_t back to unsigned long.  Used cast
	to HANDLE in _join().

LDBM
	Replaced _WIN32 with HAVE_SYSLOG

ud
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).

slapd
	Made connection sockbuf field a pointer to a sockbuf.  This
		removed slap.h dependency on lber-int.h.  lber-int.h now only
		included by those files needing to mess with the sockbuf.
	Used ber_* functions/macros to access sockbuf internals whenever
		possible.
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).
	Removed FD_SET unsigned lint

slapd/tools
	Used EXEEXT to added ".exe" to routines.  Need to define EXEEXT
		under UNIX.

ldappasswd
	Added ldappasswd.dsp.  Ported to NT.  Used getpid() to seed rand().

nt_debug
	Minor cleanup.  Added "portable.h" include and used <ac/*.h> where
	appropriate.  Added const to char* format argument.

Cast `char' arguments to ctype.h functions to `unsigned char'.
These functions require their arguments to be in the range of `unsigned char'.

Updates regarding threads and names.

Add simple copyright notice.

-lldap reentrantancy improvements from Bart Hartgers <A.Hartgers@phys.tue.nl>
including use of ctime_r, gethostby*_r, etc..  Also reworked ldap_sort_entries
to be reentrant.
Need to add code to properly set LDAP_API_FEATURE_THREAD_SAFE.

add ldap_strdup and eliminate strdup in libldap

Remove extern declarations of library functions from source.c.
  This could cause problems on odd systems.  The generic
  headers should be extended as needed to include necessary
  system headers or, if necessary, make explicit declarations.
Extended ac/string.h header to look for string.h/strings.h if
  STDC_HEADERS is not defined.  Also provide basic declarations for
  str*() functions.  This could cause problems on odd systems.
Extended ac/unistd.h header to define basic declaration for misc
  functions that might be missing from headers.   This includes
  externs for getenv(), getopt(), mktemp(), tempname().
Protect fax500.h from multiple inclusion.  Moved includes of
  system/generic headers back to source files.
Made mail500 helper functions static.
Fixed includes of ctype.h, signal.h, etc. to use generics.
lutil/tempname.c: was including stdlib.h twice, one should stdio.h.
Wrapped <sys/resource.h> with HAVE_SYS_RESOURCE_H.
lber/io.c/ber_get_next(): Changed noctets back to signed.
  Used with BerRead which expects signed int as second arg and
  returns signed int.

Protoized, moved extern definitions to .h files, fixed related bugs.
Most function and variable definitions are now preceded by its extern
definition, for error checking.  Retyped a number of functions, usually
to return void.  Fixed a number of printf format errors.

API changes (in ldap/include):
  Added avl_dup_ok, avl_prefixapply, removed ber_fatten (probably typo
  for ber_flatten), retyped ldap_sort_strcasecmp, grew lutil.h.

A number of `extern' declarations are left (some added by protoize), to
be cleaned away later.  Mostly strdup(), strcasecmp(), mktemp(), optind,
optarg, errno.

Added ldap_explode_rdn()

update ldap/lber headers towards ldapext-ldap-c-api-01

merged with autoconf branch

removed lint

Initial revision

Import of FreeBSD LDAP 3.3 Port

Import of Umich LDAP 3.3

clean up includes

The world compiles and links....
Need to sort out remaining ifnames and run testsuite.

Modified NT changes to work under UNIX.

VC++ Port: round 1

Everything compiles....  but tests fail...

Update copyright of build environment, includes, and liblber/libldap.

Update 1.1alpha with latest build environment changes from -devel.
	includes libtool support
	includes select yield changes
	headers updates
Apply strdup() -> ldap_strdup() patch.

Apply Hallvard's ctype 'unsigned char' fix from -devel.

Introduction of BER types (ber_int_t, ber_tag_t, ber_len_t, ber_socket_t)
and lber_types.h (NT version only, need to write configure support for other
platforms).   Changes to sources are likely incomplete and buggy.
This is a work in progress.

Update copyrights for year 2002

Pull in a variety of bug fixes from HEAD including
	critical client control handling
	tls cert checking
	sasl/tls ref handling
	empty dn handling
Also removed ufn search (normally I would have left it
in but the merge was easier this way).

Import latest from devel

Merge latest devel codes into releng 2 branch.
Remove back-perl, back-sql, back-tcl from branch as they have yet
to be updated.
Additional changes are needed prior to release of alpha4.

Merge in all devel changes since 2.0-alpha2.
Move OPENLDAP_REL_ENG_2_MP forward.

fix '=' escape in DN (ITS#3009)

Happy (belated) new year

New and improved response parsing

mostly new logging

silence excessive logging

updates from HEAD

Suck in latest changes from HEAD

More resyncing with HEAD

Suck in HEAD changes since 2.1alpha

C portability from HEAD

Happy new year!

Changes from HEAD, namely back-bdb updates
but also SASL, DN, matchedValues, and misc other fixes

Sync with HEAD

fix '=' escape in DN (ITS#3009)

improve previous commit

append trailing slash to AD canonical if DN is exactly a domain (ITS#3000)

Happy new year

Sync with HEAD

Happy new year! (belated)

happy new year

strval2strlen fix from HEAD

Updates from HEAD

Happy new year!

Sync with HEAD

Sync with HEAD

Happy New Year!

happy belated new year

Minor cleanup in strval2str

Update copyright for next release

Happy new year! (belated)

Sync with HEAD for OL 2.4.5

Quick merge: everything from HEAD