CVS log for libraries/liblber/decode.c

Up to [OpenLDAP] / libraries / liblber

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Happy New Year

happy belated New Year

More ITS#6353 - relent a bit: accept terminating NUL byte, which AD can send

For ITS#6353: Catch embedded NULs in BerValues converted to char* strings

ITS#6215 cleanup: Export ber_skip_element() to complement ber_peek_element()

More ITS#6215: Catch malformed elements in ber_get_stringbvl().
Do not use ber_<first/next>_element(), which have no error return.

More ITS#6215: Define and use ber_tag_and_rest() and ber_<peek/skip>_element()

More ITS#6215: Fix wrong fix in rev 1.121

Simplify struct bgbvr and ber_get_stringbvl(), preserving behavior.

More ITS#6215: Fix va_arg integer types for ber_scanf "bei" & ber_printf "BX"

More ITS#6215: Fix ber_scanf(,"mMvVW",) cleanup on error:
Parse args correctly and free up memory.
Also set some lengths=0 and remove unneeded ptr==NULL tests before frees.

More ITS#6215: Free data to the memory context used to allocate it

More ITS#6215:
Reject indefinite-length format in ber_skip_tag().  localize *len.
Reject broken and too large bitstrings in ber_get_bitstringa().
Simplify a number of functions somewhat - no functionality changes.
Remove unnecessary tests and ber_tag updates after ber_skip_tag().

Remove useless asserts that will be re-assert()ed before the variable is used

Revert prev commit

partially addresses an issue with ITS#5931

Update copyright notices

ber_decode_oid(): Fix typo in comment

Happy New Year (belated)

Cleanup debug calls

ITS#5105 from Alexey Melnikov @ isode

ITS#5010: OID encode/decode fixes and paranoia. #define LBER_OID_COMPONENT_MAX.

ber_decode_oid(), ber_encode_oid(): cast bv_val to unsigned char*

Add options for ber_get_stringbv() to omit NUL-terminator, to allow
non-destructive in-place parsing

Add DER OID encoder/decoder

happy new year

unifdef -DLDAP_NULL_IS_NULL

Happy new year!

don't malloc empty strings for matched, error

Happy New Year!

unifdef -UNEW_LOGGING

Happy new year

acknowledgements and notices

Notice updates

code cleanup

Fix assignment of <char/int>* to unsigned <char/int>* and vice versa.

ITS#2458 fix array decoding

Extended API for ber_mem functions, add context argument.
Must always use ber_mem funcs, even if CSRIMALLOC is present.

Add comment to previous

ITS#2365 - preserve internal ber_tag as well as ber_ptr for rewinding.

silence warning

Replace recursive get_stringbvr with iterative get_stringbvl to avoid
stack overrun when parsing large groups

Fix ITS#2280, reject sequences with invalid lengths

Remove pointless `unsigned < 0' test.

Happy new year

proxy authz control (client only)
Misc control cleanups (client only)

Coverted LDAP_LOG macro to use subsystem ID int values instead of string values

Renamed BVarray to BerVarray. Moved slapd:bvarray_{add,free} to
liblber:ber_bvarray_{add,free}.

Fix struct initialization in ber_scanf() for ANSI C conformance

Remove lint.

Changed 'w' format character to 'M': 'm' and 'M' for "memory" ?

Added doalloc flag to ber_get_stringbv. Added 'm' type to ber_scanf
to scan a berval in-place.

Cleanup lint in previous commit

Prep for in-place parsing. Cache a ber_tag byte.
No visible impact from these changes.

Update copyright statements

Remove lint.

One more hack to ber_get_stringbvr for do_search

Fix previous commit

Cleanup, added some explanation/comments

Safety checks for bvec's in previous patch

New ber_get_stringbvr recursively decodes a vector, to avoid
hard-coded TMP_SLOTS limitation.

Rework filter code
Misc cleanup / lint removal

Added 'W' fmt char for BVarrays

Added ber_get_stringbv

from jon@symas.com - misc Windows cleanup

Remove lint and misc MSVC updates

Remove lint

Slight memfree cleanup

Fix typo in last commit

Fix realloc bug (ITS#1410)

Make some additional UTF8 public
Remove lint

Add a bit of hardening

new logging

try new logging routines (behind NEW_LOGGING)

update logging

first try at logging improvements

Remove max buffer constraint!
and general cleanup

Rework stringal decode to return { NULL, 0 } bv's instead of { "", 0 }
when len is 0.

Revert ber_peek_tag to older, more efficient implementation.

remove old STR_TRANSLATION feature.  The use of this feature
was only of limited use with LDAPv2 (worked okay if no non-T.61
values existed) but downright dangerous in the face of LDAPv3.
Any translation must be schema aware and the BER isn't.

Forget return in last commit

Update lber-encode/decode man pages
Add ber_get_enum() for symmetry

Y2k copyright update

Fix typo in last commit (fixing multiple byte tags)

Fix typo in multbyte tag code

Apply experimental multibyte tag fix

Remove lint
Add copyrights

Modify password code such that backend end routine calls into
frontend to complete parsing of extended op reqdata.
Modify password extended operation to allow optional id (DN)
entry to change (not tested).  Also, provide room to allow
server side password generation (not implemented).  Added optional old
password field to support proxying (not implemented).
Need to implement replog() support.

Remove LBER_{TAG,INT,LEN}_{NTOH,HTON} macros.  Rewrite code to
manual push bytes about.  Allows ber_*_t to be any 32-bit or
larger type.  Reworked AC_{HTON,NTOH}{L,S} macros to care only
about 32-bit (netlong) and 16-bit (netshort) reordering as
needed for BSD socket interface.

Backout premature commit.

Last commit contained cleanups and optimizations allowed by latest IETF C API draft.

*** empty log message ***

Minor adjustments based upon initial read of draft-ietf-ldapext-ldap-c-api-04.txt.

Add OpenLDAP RCSid to *.[ch] in clients, libraries, and servers.
Replace old Id as needed (back-tcl).
Leave updating of contribWare to contributors (for now).

Axe <varargs.h> support.  Assume STDC C translator is available
to build OpenLDAP.

Remove unsigned long:  Change to ber_len_t or ber_tag_t.
Remove sizeof(long).
Change ber_getnint to return ber_len_t instead of ber_tag_t.

Cast ber_read() arg to char*

ber_int_t, ber_tag_t, ber_socket_t, ber_len_t
added lber_types.h.nt, lber_types.h.in
removal of NULLxxx internal macros (in favor of NULL).
ch_free added to slapd,slurpd/ch_malloc.c
#define free ch_free (should be removed after s/free/ch_free/g) in proto-slap.h
ch_malloc and friends use ber_memalloc and friends

Enable browsing info in MSVC debugging configurations.
Toy with dllimport/dllexport stuff (think I'll leave the real dll work to
somebody else).
Added ldap_strdup() wrapper of ber_strdup().

s/<stdlib.h>/<ac/stdlib.h>/

move berval memory routines to memory.c
Add ber_memvfree(void** vector)

First cut at ber_set_option(NULL,LBER_OPT_MEMORY_FN, myrealloc) where
myrealloc is pointer to a realloc() wrapper.
Must be first library call or else.

Add LBER_ and LDAP_ memory allocators/deallocators for internal
library use:
  LBER_ macros expand to system routines.
  LDAP_ macros expand to new ber_ allocators.

Add ber_ and ldap_ memory allocators/deallocator:
  ber_ routines are wrappers of LBER_ macros.
  ldap_ routines are wrappers of ber_ routines.

Removed safe_realloc() macro from various files.  This issue
(if an issue) should be resolved across whole package.

ldapmodify.c now uses ber_ allocators to resolve ber_bvfree()
vs. WIN32 multiple heaps issue.

These changes should facilate implementation of
  ber_set_option( NULL, LBER_OPT_MEMORY_FN, ...)
and
  ldap_set_option( NULL, LDAP_OPT_MEMORY_FN, ...).

Changed lc_conn to be a pointer to a BerElement to aid in state management.
Added validation to exposed opaque data structures (BerElement, Sockbuf,
and LDAP).  Added macros BER_VALID, SOCKBUF_VALID, LDAP_VALID.
Added ber_pvt_ber_bytes() and ber_pvt_ber_remaining() macros to hide
some ber internals.  These really should be handled by ber_get_option().

Death to LBER_END_SEQORSET.

found my lber bug... ber_buf should have been freed in ber_peek_tag.  Ugh!

Fix initialization bug in ber_init_w_nullc()
Added assert(), additional comments, and a few minor adjustments.

Version.c deprecated in favor of mkversion.
Minor cleanup to lber files.

Improving e/d test (until I find the my damn bug)

Add UL to more BER tags.

Add UL to LBER tags.

Vienna Bulk Commit
This commit includes many changes.  All changes compile under NT but
have not been tested under UNIX.

A Summary of changes (likely incomplete):

NT changes:
	Removed lint.
	Clean up configuration support for "Debug", "Release", "SDebug",
		and "SRelease" configurations.
	Share output directories for clients, libraries,
		and slapd.  (maybe they should be combined further
		and moved to build/{,S}{Debug,Release}).
	Enable threading when _MT is defined.
	Enable debuging when _DEBUG is defined.
	Disable setting of NDEBUG under Release/SRelease.  Asserts
		are disabled in <ac/assert.h> when LDAP_DEBUG is not
		defined.
	Added 'build/main.dsp' Master project.
	Removed non-slapd projects from slapd.dsp (see main.dsp).
	Removed replaced many uses of _WIN32 macro with feature based
		macros.

ldap_cdefs.h changes
	#define LDAP_CONST const
		(see below)
	#define LDAP_F(type) LDAP_F_PRE type LDAP_F_POST
		To allow specifiers to be added before and after
		the type declaration.  (For DLL handling)

LBER/LDAP changes
	Namespace changes:
		s/lber_/ber_/ for here and there.
		s/NAME_ERROR/LDAP_NAME_ERROR/g
	Deleted NULLMSG and other NULL* macros for namespace reasons.
	"const" libraries.  Installed headers (ie: lber.h, ldap.h)
		use LDAP_CONST macro.  Normally set to 'const' when
		__STDC__.  Can be set externally to enable/disable
		'constification' of external interface.  Internal
		interface always uses 'const'.  Did not fix warnings
		in -lldif (in lieu of new LDIF parser).

	Added _ext API implementations (excepting search and bind).
		Need to implement ldap_int_get_controls() for reponses
		with controls.

	Added numberous assert() checks.

LDAP_R
	_MT defines HAVE_NT_THREADS
	Added numberous assert() checks.
	Changed ldap_pthread_t back to unsigned long.  Used cast
	to HANDLE in _join().

LDBM
	Replaced _WIN32 with HAVE_SYSLOG

ud
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).

slapd
	Made connection sockbuf field a pointer to a sockbuf.  This
		removed slap.h dependency on lber-int.h.  lber-int.h now only
		included by those files needing to mess with the sockbuf.
	Used ber_* functions/macros to access sockbuf internals whenever
		possible.
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).
	Removed FD_SET unsigned lint

slapd/tools
	Used EXEEXT to added ".exe" to routines.  Need to define EXEEXT
		under UNIX.

ldappasswd
	Added ldappasswd.dsp.  Ported to NT.  Used getpid() to seed rand().

nt_debug
	Minor cleanup.  Added "portable.h" include and used <ac/*.h> where
	appropriate.  Added const to char* format argument.

Fix typo LDAP_END_SEQORSET -> LBER_END_SEQORSET

Lint removal:  signed i < unsigned j

function pointers are incompatible with `void *'; remove `!= NULL' from tests.

Back out previous change; it was an accidental commit

Declare lber_pvt_sb_* functions from io.c in lber-int.h

Add simple copyright notice

Plug memory leaks when ber input fails:  Let ber_scanf & co set the
free the memory they have allocated, and set the arguments to NULL.

Added lber_get/set_option.  Removed lber_debug/ldap_debug.
Updated other codes as needed.

Add draft-ietf-ldapext-ldap-c-api-01 routines ber_init()
and ber_flatten() to the -llber.

Protoized, moved extern definitions to .h files, fixed related bugs.
Most function and variable definitions are now preceded by its extern
definition, for error checking.  Retyped a number of functions, usually
to return void.  Fixed a number of printf format errors.

API changes (in ldap/include):
  Added avl_dup_ok, avl_prefixapply, removed ber_fatten (probably typo
  for ber_flatten), retyped ldap_sort_strcasecmp, grew lutil.h.

A number of `extern' declarations are left (some added by protoize), to
be cleaned away later.  Mostly strdup(), strcasecmp(), mktemp(), optind,
optarg, errno.

Updated MSVC5 workspaces and projects.
Added ac/stdarg.h and updated liblber encode/decode to use it.

Some gcc -W cleanup

struct ldap is now opaque to clients.
updated clients to use ldap_get/set_options
ld_options is renamed ld_booleans.  ldap-int.h has accessor macros.
updated libldap to use new accessor macros.

update ldap/lber headers towards ldapext-ldap-c-api-01

merged with autoconf branch

Merge from LAMBERT branch

Merged LDAPworldCurrent (P1-10,13,15,16,19-22)
Cleaned up old rcs keyworld subs

apply FreeBSD changes to main branch

Initial revision

Import of FreeBSD LDAP 3.3 Port

Import of Umich LDAP 3.3

changes from Terry Lambert

LDAPworldP22: problem with msgids greater than 32767 on 64bit architectures

more autoconf changes

remove some lint...

clean up includes

HTONL -> AC_HTONL

VC++ Port: round 1

Clean up sh commands in Makefiles (incorrect use of ';').
Fix make install problems.

Everything compiles....  but tests fail...

Use ldap_cdefs.h more.  Use bridge.h less.

Added acconfig.h defines.  started to clean up -llber.

Update copyright of build environment, includes, and liblber/libldap.

Update for Alpha3 from -devel as of OPENLDAP_DEVEL_981116.
Includes everything but ldapext & ldap.conf changes.

Update Alpha2 with NT4 changes.

Update with latest from -devel.

lber hardening

lber_debug/ldap_debug are always defined and provided by the implementation.

Apply Hallvard's ber_scanf bug fix.

s/NULLxxx/NULL
s/xxx/ber_xxx_t/

Introduction of BER types (ber_int_t, ber_tag_t, ber_len_t, ber_socket_t)
and lber_types.h (NT version only, need to write configure support for other
platforms).   Changes to sources are likely incomplete and buggy.
This is a work in progress.

Update copyrights for year 2002

Import latest leak fix from HEAD.

Fix realloc bug

Import -llber hardening

Import latest BER library changes

Import stringal change to return {NULL,0} when len is 0

Import latest from devel

Merge latest devel codes into releng 2 branch.
Remove back-perl, back-sql, back-tcl from branch as they have yet
to be updated.
Additional changes are needed prior to release of alpha4.

Merge in all devel changes since 2.0-alpha2.
Move OPENLDAP_REL_ENG_2_MP forward.

Merge in all -devel changes made since branch was created.

Fixed SASL interactive free bug (ITS#2423)
Fixed liblber multi-value decode bug (ITS#2458)
Fixed liblber over read bug (ITS#2465)

fix ber decoding error (ITS#2365)

Happy (belated) new year

Changes:
    Fixed liblutil getpeereid replacement function
    Fixed liblber 64bit len/tag bug
    Updated liblber ber_get_stringbv handling
    Build Environment
        Updated NT build environment w/ slurpd support
        Updated test suite

Misc -llber fixes, lint removal, etc.

Sync with HEAD

cleanup

mostly logging

Happy new year!

Happy new year

Sync with HEAD

Changes from HEAD for beta

Happy new year! (belated)

ITS#5105 fix from HEAD

happy new year

Happy new year!

Sync with HEAD

Sync with HEAD

Happy New Year!

happy belated new year

More for ITS#6353

ITS#6353

More for ITS#6215

ITS#6215

Update copyright for next release

ber_decode_oid(): Fix typo in comment

Happy new year! (belated)

Cleanup debug calls

Sync with HEAD for OL 2.4.5

Quick merge: everything from HEAD