[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: syncrepl's "retry" option



> Quanah Gibson-Mount wrote:
>> --On Tuesday, April 20, 2010 5:34 PM -0400 Ryan Steele
>> <ryans@aweber.com> wrote:
>>
>>> The FAQ indicates that the 'retry' option should be a comma-separated
>>> list: http://www.openldap.org/faq/data/cache/1118.html
>>>
>>>
>>> However, all of the examples from the section on replication in the
>>> Admin
>>> Guide seem to show them as being space-delimited values:
>>> http://www.openldap.org/doc/admin24/replication.html#Syncrepl
>>>
>>>
>>> Which is correct?
>>
>> Both.
>>
>> If you examine the source, you find:
>>
>>        slap_str2clist( &retry_list, val, " ,\t" );
>>
>> i.e., it accepts a space, a comma, or a tab, as delimiters.
>>
>> --Quanah
>>
>
>
> Ah, thanks for clearing that up, Quanah.  Gavin, should the documentation
> be updated to reflect this?

The docs only present the "," because that's the preferred way.  The other
forms are supported mainly for historical reasons.  You should stick with
the documentation.  The tests should use the documented form.

> I checked several
> sources, but none seemed to definitively identify all of the acceptable
> delimiters.  I'm happy to submit a patch for the
> Admin Guide, if you like?

A patch for the tests would be preferable.

p.