Re: ITS review 6/4/2019

[Ondřej Kuzník <ondra@mistotebe.net>]

On Tue, Jun 04, 2019 at 02:05:13PM -0700, Quanah Gibson-Mount wrote:
> All of the following have patches and need review/approval.  Any with **** I
> consider desired for the next releases of LMDB & OpenLDAP:

For the ones I had a look at this week (others are written by me or
wasn't sure):

> LMDB related ITSes
> ----------------------
> **** ITS#8986 - Fix LMDB for FreeBSD12 (has patch, IPR OK)
> ITS#8739 - liblmdb - Fixes fsync check on FreeBSD (has patch, IPR not
> needed)
> 
> 
> OpenLDAP related ITSes for RE24
> -------------------------------
> ITS#7042 - slapd/syncrepl - Allow disconfiguring TLS settings (has patch,
> IPR OK)

Pushed to master with a followup patch, should be ok for 2.4

> ITS#7721 - contrib/lastbind - allow authtimestamp forwarding with updateref
> (44e9bda0e42f40e0baf0a2c0ef733eb757abd366)
> 
> ITS#7770 - back-monitor - Add mdb_stat info
> (e19c683c41e14365d28e82278eec1d8b12c71d4c ,
> 6e2bac6465bb81a8c1aeb083b6dc497eb4187264 )
> 
> **** ITS#7996, ITS#8450 - libldap - Fix race condition (has patch, IPR OK)

ITS#7996 is in master now, ok for 2.4

Will look at ITS#8450 soon

> **** ITS#8037 - slapd - Fix delta-syncrepl with relax
> (cb9a4d01bc1ecf1eeb3fb7ef39067b2b30b6c545)

I'd say this looks ok, but check with Howard whether to backport this.

> **** ITS#8167 - libldap - fix non-blocking TLS
> (46c93e41f43da7f16270179c6eff75e450617329)

Looks ok for 2.4

> ITS#8349 - Fix ppolicy behavior with pwdHistory
> 
> **** ITS#8427 - slapd/syncrepl - Fix broken behavor for TLS options (has
> patch, IPR OK)

Pushed to master with a followup patch, should be ok for 2.4

> ITS#8508 - liblunicode - Fix ucgendat
> (cc99da182f53d3d4f3874703643b277773717af3)
> 
> **** ITS#8637 - slapd-ldap - Correctly reject invalid config with
> slapd-config (has patch, IPR OK)
> 
> **** ITS#8671 - libldap - ldap_init_fd() in ldap.h (has patch, for Samba
> project, IPR OK)

Will create openldap.h and deal with this soon.

> **** ITS#8674 - libldap - Fix leak (has patch, IPR not needed)

In master, ok for 2.4

> ITS#8695 - slapd - "sleep" is deprecated (WINDOWS ONLY) (has patch, IPR OK)
> 
> ITS#8754 - libldap - Correctly ignore IPv6 if IPv6 is disabled (has patch)

In master, ok for 2.4

> **** ITS#8755 - libldap - leaking file descriptor when closing connection
> (has patch, IPR OK)
> 
> ITS#8794 - libraries/libldap - Fix implicit declaration (has minor patch)
> 
> **** ITS#8841 - back-meta - Fix assertion if the network interface goes down
> (17f1e32b65c332f7a33b77ebe6e20b47188a88aa)

That looks fine for 2.4

> **** ITS#8864 - liblber - fix ber_flush
> (fb49d486a35fd4b2e993398c1eea0c8f7bc6ac40)
> 
> **** ITS#8997 - slapd-ldap - Fix segfault (Howard already wrote the patch,
> just needs to be committed)
> 
> **** ITS#9001 - libraries/libldap - Use new Tavl bits to reduce search time
> (has patch, IPR OK)

This one isn't ready yet, might not belong to 2.4 anyway, also pending
answer on https://www.openldap.org/lists/openldap-devel/201903/msg00011.html

> OpenLDAP related ITSes for RE25
> -------------------------------
> ITS#8875 - back-mdb - fix performance problems with large DIT and many
> aliases (has patch)

-- 
Ondřej Kuzník
Senior Software Engineer
Symas Corporation                       http://www.symas.com
Packaged, certified, and supported LDAP solutions powered by OpenLDAP