[Date Prev][Date Next]
Re: commit: ldap/servers/slapd sl_malloc.c zn_malloc.c
--On Friday, January 15, 2010 5:53 PM +0000 hallvard@OpenLDAP.org wrote:
Update of /repo/OpenLDAP/pkg/ldap/servers/slapd
sl_malloc.c 1.67 -> 1.68
zn_malloc.c 1.14 -> 1.15
Gentler message when falling back to ch_malloc
CVS Web URLs:
Changes are generally available on cvs.openldap.org (and CVSweb)
within 30 minutes of being committed.
The new error message doesn't make sense, English wise. It doesn't even
- "slap_sl_malloc of %lu bytes failed, using ch_malloc\n",
+ "slap_sl_malloc of %lu bytes falling back to ch_malloc\n",
I.e., what would get logged is:
slap_sl_malloc of 700 bytes falling back to ch_malloc
Which really gives the end user no idea what is wrong.
I would suggest something like:
+ "slap_sl_malloc of %lu bytes failed, falling back to
Similar with the slap_zn_malloc error message.
Principal Software Engineer
Zimbra :: the leader in open source messaging and collaboration