[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd backend.c

To: masarati@aero.polimi.it
Subject: Re: commit: ldap/servers/slapd backend.c
From: Howard Chu <hyc@symas.com>
Date: Sat, 21 Nov 2009 12:30:41 -0800
Cc: OpenLDAP Commit <openldap-commit2devel@openldap.org>, Hallvard B Furuseth <h.b.furuseth@usit.uio.no>
In-reply-to: <60581.93.32.159.34.1258835151.squirrel@www.aero.polimi.it>
References: <200911211922.nALJMISY061915@cantor.openldap.org> <hbf.20091121fakw@bombur.uio.no> <60581.93.32.159.34.1258835151.squirrel@www.aero.polimi.it>
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.9.1.5pre) Gecko/20091025 Lightning/1.0pre SeaMonkey/2.0a1pre Firefox/3.0.3

masarati@aero.polimi.it wrote:
>> hyc@OpenLDAP.org writes:
>>> 	backend.c  1.412 -> 1.413
>>> ITS#6393 syncrepl internal connids are now <= -1000
>>
>> backend.c: 'op->o_connid <= -1000' is wrong. o_connid is unsigned long,
>> so this is compiled as 'op->o_connid <= (unsigned long) -1000'.
> 
> Right.  Also, since o_connid is unsigned long, -1000-rid is a valid connid.
> 
> Perhaps, a char in the Connection structure, or yet another value in some
> bitmask would be better.

Except that doesn't help the issue with syncrepl and slap_graduate_commit_csn().

Another suggestion is to reserve connids 0-999 for syncrepl, and start the
real connections at 1000.

-- 
  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/

Follow-Ups:
- Re: commit: ldap/servers/slapd backend.c
  - From: Hallvard B Furuseth <h.b.furuseth@usit.uio.no>

References:
- Re: commit: ldap/servers/slapd backend.c
  - From: Hallvard B Furuseth <h.b.furuseth@usit.uio.no>
- Re: commit: ldap/servers/slapd backend.c
  - From: masarati@aero.polimi.it

Prev by Date: Re: commit: ldap/servers/slapd backend.c
Next by Date: Re: commit: ldap/servers/slapd backend.c
Index(es):
- Chronological
- Thread