[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd connection.c slap.h

Hallvard B Furuseth wrote:
> hyc@OpenLDAP.org writes:
>> 	slap.h  1.881 -> 1.882
>> -	int			c_struct_state; /* structure management state */
>> -	int			c_conn_state;	/* connection state */
>> +	enum sc_struct_state	c_struct_state; /* structure management state */
>> +	enum sc_conn_state	c_conn_state;	/* connection state */
> Note that this is potentially a binary incompatible change.
> I'm never clear on how hard we try to avoid those in slapd...
> These enum types need not take more than 1 byte each.
> (OTOH enum constants declared _in_ the enum have type int.)

Yes, but I think the change is worth it. Of course, I have some concerns about
whether it's important to ensure that these remain atomic. We could always add
a dummy value XX=1<<25 to force a 4 byte size.

  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/