[Date Prev][Date Next]
> email@example.com writes:
>> The code is littered with tests like #ifdef HAVE_GMTIME_R, but there's
>> longer tests for gmtime_r() in configure. Is it time to cleanup a bit?
> Grepping some OpenLDAP versions, I'm not sure there ever was a test for
> it. #Define it if everything protected by gmtime_mutex can be avoided.
> (gmtime_r, localtime_r, anything else?) After checking that the #ifdef
> HAVE_GMTIME_R branches (still) work, of course. Should probably also
> check that the prototype is as expected, in case there have been
> multiple versions as with 'int strerror_r()' vs 'char *strerror_r()'.
Builds fine with -DHAVE_GMTIME_R=1; on my Linux gmtime_r() is defined
according to its use in OpenLDAP, but I have no means to check for
conformance in other systems.