[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd/overlays pcache.c

> ando@OpenLDAP.org wrote:
>> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/overlays
>> Modified Files:
>> 	pcache.c  1.184 ->  1.185
>> Log Message:
>> expose cachedQueryURL in overlay's monitor entry (partial fulfilment of
> ITS#5178; needs new register_overlay() code in back-monitor)
> Hmmm, not sure exposing the actual URLs is a good idea. Why not just the
> counts?
> Also, if there are thousands of cached queries, this could get to
> be an expensive lookup.

I know.  I wanted to expose the queries because they represent an
effective means to determine the queryUUID in order to manage queries
(e.g. manually delete one when expired).  Moreover, the cachedQueryURL has
a well defined structure and is already available.  What's missing right
now is a general "stats" output (number of cached queries, number of
entries, perhaps some performance index).  I'll work at that later.