[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd/overlays ppolicy.c

hyc@OpenLDAP.org wrote:
Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/overlays

Modified Files:
	ppolicy.c  1.125 ->  1.126

Log Message:
Fix check_password with {cleartext} passwords

As I note in the added comment, the check_password interface kinda sucks here. Instead of making the external module malloc its error message string, we should have passed in a struct berval with a buffer and length(buffer) already set. I'd like to change this for 2.5, it will also simplify ITS#6082.

  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/