[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/libraries/libldap deref.c Makefile.in

--On Tuesday, November 11, 2008 12:26 AM +0100 Pierangelo Masarati <ando@sys-net.it> wrote:

quanah@OpenLDAP.org wrote:
Update of /repo/OpenLDAP/pkg/ldap/libraries/libldap

Modified Files:
      Tag: OPENLDAP_REL_ENG_2_4
	Makefile.in ->
Added Files:
      Tag: OPENLDAP_REL_ENG_2_4
	deref.c  NONE ->

Log Message:

This commit breaks 2.4 because LDAP_CONTROL_X_DEREF is only defined when LDAP_DEVEL is, but it is used in libldap/deref.c without #ifdef. Probably, the macro declaration should be moved outside #ifdef LDAP_DEVEL. I don't want to intervene while you're consolidating 2.4, though.

Feel free to fix it, I've caught up on 2.4 commits, and am currently looking at the diff between HEAD/RE24.



Quanah Gibson-Mount
Principal Software Engineer
Zimbra, Inc
Zimbra ::  the leader in open source messaging and collaboration