Re: commit: ldap/libraries/liblber io.c

[Howard Chu <hyc@symas.com>]

Hallvard B Furuseth wrote:
> hyc@OpenLDAP.org writes:
> > Modified Files:
> > 	io.c  1.120 ->  1.121
> > ITS#5580 fix length decoding, verified with PROTOS
>
> Keep the sock_errset() if returning LBER_DEFAULT and sblen<  0?

No. ber_int_sb_read() will cause errno to already be set if it cannot fulfill 
the request.

> And maybe the variable used like i in the changed code must be
> ber_slen_t instead of int

Why?

--
  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/