[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: test008 failed in HEAD

Howard Chu wrote:
Howard Chu wrote:
I'm seeing this failure with both BDB 4.2.52 and BDB 4.6.21, and no failure in
RE23, so it must be something changed between RE23 and RE24, but so far
looking at the diffs I don't see anything that could have caused this change
in behavior.

Looking back at 2.4.5 and 2.4.6, I got the same failure in 2.4.6. That means it's not a new regression in 2.4.7 at least. I'm still testing 2.4.5 (using the tests in 2.4.6) to see if it fails. At this point, since it's not new in 2.4.7, we should track it in the ITS. I may just hack up a quick workaround for this until I can isolate the real problem.

The back-bdb diffs between 2.4.5 and 2.4.6 look totally trivial to me. However, reverting one change seems to have cured the problems in my 2.4.6 and 2.4.7 trees. Why it makes any difference is completely beyond me.

I'll let my 2.4.7 build keep running test008 for a few more hours. I'd appreciate if you could test this as well.
-- Howard Chu
Chief Architect, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
Index: back-bdb.h
RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/back-bdb/back-bdb.h,v
retrieving revision
diff -u -r1.141.2.8 back-bdb.h
--- back-bdb.h	26 Nov 2007 00:33:12 -0000
+++ back-bdb.h	5 Dec 2007 01:01:30 -0000
@@ -151,10 +151,10 @@
 	EntryInfo	*c_lruhead;	/* lru - add accessed entries here */
 	EntryInfo	*c_lrutail;	/* lru - rem lru entries from here */
 	EntryInfo	c_dntree;
-	unsigned	c_maxsize;
+	int	c_maxsize;
 	int		c_cursize;
-	unsigned	c_minfree;
-	unsigned	c_eimax;
+	int	c_minfree;
+	int	c_eimax;
 	int		c_eiused;	/* EntryInfo's in use */
 	int		c_leaves;	/* EntryInfo leaf nodes */
 	int		c_purging;
@@ -223,7 +223,7 @@
 	ID			bi_lastid;
 	ldap_pvt_thread_mutex_t	bi_lastid_mutex;
-	unsigned	bi_idl_cache_max_size;
+	int	bi_idl_cache_max_size;
 	int		bi_idl_cache_size;
 	Avlnode		*bi_idl_tree;
 	bdb_idl_cache_entry_t	*bi_idl_lru_head;