[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd bconfig.c



On Friday 30 March 2007 13:09, Ralf Haferkamp wrote:
[..]
> > Most of the code in this checkin is a duplicate of slap_add_opattrs().
>
> Actually I was looking at the slapadd() function in slapadd.c while
> implementing this. Didn't really have slap_add_opattrs() in mind then :|.
>
> > Any reason you didn't use that?
>
> While looking at slap_add_opattrs() I am bit unsure if that can really be
> used in that place (during slapadd). It would at least need a correctly
> initialized Operation* and Connection* structure. But I can give it a try.
Committed.

> If that works. I guess it would make sense to also change the code in
> slapadd() to use slap_add_opattrs() as well?

-- 
Ralf