[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd result.c value.c



At 01:14 PM 4/6/2006, Pierangelo Masarati wrote:
>On Thu, 2006-04-06 at 19:09 +0000, kurt@OpenLDAP.org wrote:
>
>>       value.c  1.79.2.11 -> 1.79.2.12
>> 
>> Log Message:
>> Code which doesn't hanlding allocation failure should use
>> ch_ routines, not SLAP_ macros
>
>I believe the change in value.c is incorrect; if you use ch_realloc()
>you shouldn't check the return value, as ch_realloc() will cause an
>assert failure; or you handle the failure.

Yes, it was a quick commit...