[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd/back-ldbm compare.c

On Sat, 2006-01-07 at 02:56 -0800, Howard Chu wrote:
> ando@OpenLDAP.org wrote:
> > Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/back-ldbm
> >
> > Modified Files:
> > 	compare.c  1.51 -> 1.52
> >
> > Log Message:
> > release entry before sending results (ITS#4313)
> >
> >   
> Most of the other ops could use similar restructuring. I never bothered 
> because it didn't seem worthwhile to invest the time in back-ldbm. 
> There's not much we can do about send_search_entry of course, short of 
> dup'ing each entry that gets sent so that the cached copy can be released.

Releasing the cacke before sending result is mandatory if we want to be
able to use overlays (or revitalize Luke's idea of allowing code
insertion when entries are already (pre) or still (post) locked; this
would allow many features that require atomicity to be introduced by
means of overlays.

Also, note that most of the backends could give up the compare op; if
it's not available, the frontend provides a safe replacement.  I only
fixed this because it was making the test fail...


Ing. Pierangelo Masarati
Responsabile Open Solution
OpenLDAP Core Team

SysNet s.n.c.
Via Dossi, 8 - 27100 Pavia - ITALIA
Office:   +39.02.23998309          
Mobile:   +39.333.4963172
Email:    pierangelo.masarati@sys-net.it