[Date Prev][Date Next]
Re: commit: ldap/servers/slapd result.c slap.h
On Fri, 2005-11-25 at 11:54 -0800, Howard Chu wrote:
> ando@OpenLDAP.org wrote:
> > Update of /repo/OpenLDAP/pkg/ldap/servers/slapd
> > Modified Files:
> > result.c 1.276 -> 1.277
> > slap.h 1.731 -> 1.732
> > Log Message:
> > check sizelimit in frontend (ITS#4213)
> > CVS Web URLs:
> > http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/
> > http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/result.c
> > http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/slap.h
> > Changes are generally available on cvs.openldap.org (and CVSweb)
> > within 30 minutes of being committed.
> Is there any reason why we need a special SLAPD_SIZELIMIT result code,
> instead of just returning LDAP_SIZELIMIT_EXCEEDED?
I had the same idea initially, but I was afraid it could be misleading
to have specific error codes returned by a function that's not supposed
to return protocol error codes; it seems reasonable, though.
I'd rather change those -1, 0, 1 that are currently returned by
send_search_entry(), to make them a bit more readable and ready to be
used by the caller. Something like LDAP_UNAVAILABLE, LDAP_SUCCESS,