[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd backglue.c

jongchoi@OpenLDAP.org wrote:
Update of /repo/OpenLDAP/pkg/ldap/servers/slapd

Modified Files:
	backglue.c  1.81 -> 1.82

Log Message:
Fixing backglue behaviors
1) Return NO_SUCH_OBJECT if base object cannot be located
2) Does not search databases that are superior to the base object of the search

The patch for (2) looks wrong; the if/else block from 327-344 would fix this just by adding else { continue; } at the end. This problem seems to be because the if/else block used rs->sr_err but the following switch() now uses gs.err to detect errors, so there was a logical disconnect there.