[Date Prev][Date Next] [Chronological] [Thread] [Top]

RE: commit: ldap/servers/slapd connection.c

At 03:07 PM 2/9/2004, Howard Chu wrote:
>re: Abandon with pending ops - it seemed to me that it was better to let the
>Abandon proceed, because one way or the other that will free up resources for
>the pending ops to get thru. If a running op is abandoned, that's fine. If a
>pending op is abandoned, that's even better, because it can be removed from
>the pending list without any other overhead...

I agree that Abandons should not be deferred due to pending

The closing case doesn't matter too much.  All the operations
will be abandoned anyways and starting thread to abandon one
in particular is a bit of a waste, but I left that exception
in place.

The bind case is similar to the closing case, but here I worry
about operations ordering issues.  We treat all request arriving
during the bind as if they arrived after the bind.  I don't
think abandon requests should be excepted here.

And regarding thread shortage, I'm concerned that it excepting
abandon requests might be unwise.  It could be too many abandon
requests is the cause the shortage.

>  -- Howard Chu
>  Chief Architect, Symas Corp.       Director, Highland Sun
>  http://www.symas.com               http://highlandsun.com/hyc
>  Symas: Premier OpenSource Development and Support
>> -----Original Message-----
>> From: owner-openldap-commit@OpenLDAP.org
>> [mailto:owner-openldap-commit@OpenLDAP.org]On Behalf Of
>> kurt@OpenLDAP.org
>> Sent: Monday, February 09, 2004 12:33 PM
>> To: OpenLDAP Commit
>> Subject: commit: ldap/servers/slapd connection.c
>> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd
>> Modified Files:
>>       connection.c  1.264 -> 1.265
>> Log Message:
>> ITS#2959: provide reason for deferring operation in log message
>> Also, took away abandon operations blank check against deferment.
>> Abandon must be deferred in some cases (such as when other operations
>> are pending) and should be deferred in some other cases (such as too
>> many threads).
>> CVS Web URLs:
>>   http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/
>> http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/connection.c
>> Changes are generally available on cvs.openldap.org (and CVSweb)
>> within 30 minutes of being committed.