[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd daemon.c

* kurt@OpenLDAP.org (kurt@OpenLDAP.org) wrote:
> Modified Files:
> 	daemon.c  1.275 -> 1.276
> Log Message:
> ITS#2607: improve socket() error logging with AF info

Thanks for doing this, something for the bind() errors would be nice but
I realize it's more difficult.  One thing that might help though is that
gcc 3.0 (and I think C99...) support variable length macros.  An example

  #define DEBUGP(level, ...) if(debug > level) printk(__VA_ARGS__)

I havn't looked at how complex the LDAP_LOG macro is but I'd expect this
would work for things that support it.  Of course, I realize you support
alot of different systems so I know it might not be possible to use it
if those systems don't have compilers which support variable number
argument macros.



Attachment: pgpHxIyuZvnWs.pgp
Description: PGP signature