[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: ACL Performance (caching on object basis) (ITS#1523)

In reviewing these patches, it looks like acl_check_modlist ought to be
checking for any value-dependent ACLs as well, but currently isn't. Yes?

Also, since the caching is only performed on a per-entry basis, the entire
ACLCache structure looks unnecessary. It also seems to me that nothing is
gained from making the ACLCacheEntry a doubly linked list, a single link would
be enough since the list is only traversed in one direction.

  -- Howard Chu
  Chief Architect, Symas Corp.       Director, Highland Sun
  http://www.symas.com               http://highlandsun.com/hyc
  Symas: Premier OpenSource Development and Support