[Date Prev][Date Next] [Chronological] [Thread] [Top]

Bug in ldap_controls_free



Kurt, I now understand your comment about moving the assert instead of removing it.

	ldap_controls_free( LDAPControl **controls )
	{
	#ifdef LDAP_MEMORY_DEBUG
	        assert( controls != NULL );
	#endif
	...

For what it's worth, doing it this way means valid LDAP programs can still crash here.
Some programs are written relying on the NOP behavior for NULL input as described in the draft.
You would not be able to debug these programs with LDAP_MEMORY_DEBUG on.