Re: (ITS#9125) [regression] back-ldap does not respect --without-tls

[hyc@symas.com]

grapvar@gmail.com wrote:
> Full_Name: Konstantin Andreev
> Version: git/master/1dbf0e9/20191129
> OS: Solaris 11.3 x64
> URL: 
> Submission from: (NULL) (79.135.238.172)
> 
> 
> I have configured the tip of the master branch like so:
> 
> | $ ../configure ...  --without-tls ...
> | ...
> | configure: WARNING: TLS data protection not supported!
> 
> and then compilation has failed:

Fixed now in git master.
> 
> | cc -g -m64 -I../../../include -I../../../../include -I..
> -I../../../../servers/slapd/back-ldap/.. -DSLAPD_IMPORT -c
> ../../../../servers/slapd/back-ldap/config.c  -KPIC -DPIC -o .libs/config.o
> | "../../../../servers/slapd/back-ldap/config.c", line 87: warning:
> initialization type mismatch
> | ...
> | "../../../../servers/slapd/back-ldap/config.c", line 992: undefined
> struct/union member: sb_tls_ctx
> | "../../../../servers/slapd/back-ldap/config.c", line 993: improper member use:
> sb_tls_ctx
> | ...
> | cc: acomp failed for ../../../../servers/slapd/back-ldap/config.c
> 
> ... because slapd.h guards sb_tls_* members of the [struct slap_bindconf]:
> 
> | servers/slapd/slap.h:
> | typedef struct slap_bindconf {
> | ...
> | #ifdef HAVE_TLS
> |     void *sb_tls_ctx;
> |     char *sb_tls_cert;
> |     ...
> | #endif
> | } slap_bindconf;
> 
> but back-ldap/config.c apparently does not respect HAVE_TLS.
> 
> This is a regression, because latest release 2.4.48 compiles without TLS
> succeessfully.
> 
> 


-- 
  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/