[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#9119) back-monitor can miscount monitorOpCompleted

quanah@openldap.org wrote:
> Full_Name: Quanah Gibson-Mount
> Version: 2.4.43
> OS: N/A
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (47.208.143.26)
> 
> 
> When querying the monitor backend for monitorOpCompleted, the results are
> inconsistent.  The code that calculates this value is also inefficient, as there
> is already a global counter of completed operations, but back-monitor doesn't
> use this and instead queries all the per-operation counters and then sums them
> together for the result, causing unnecessary work.

Fixed in git master.
> 
> These are the results of a series of queries:
> 
> monitorOpCompleted: 326801
> monitorOpCompleted: 326733
> monitorOpCompleted: 326830
> monitorOpCompleted: 326830
> monitorOpCompleted: 326752
> monitorOpCompleted: 326855
> monitorOpCompleted: 326777

Unable to reproduce. Please test the patch and report back if the problem still shows up.

-- 
  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/