[Date Prev][Date Next]
Re: (ITS#8976) LMDB > use posix_madvise(3) instead of madvise(3) for SmartOS
- To: openldap-its@OpenLDAP.org
- Subject: Re: (ITS#8976) LMDB > use posix_madvise(3) instead of madvise(3) for SmartOS
- From: email@example.com
- Date: Fri, 15 Feb 2019 15:33:51 +0000
- Auto-submitted: auto-generated (OpenLDAP-ITS)
Matthieu GUEGAN wrote:
> On Fri, Feb 15, 2019 at 3:56 PM Howard Chu <firstname.lastname@example.org> wrote:
>> email@example.com wrote:
>>> Full_Name: Matthieu Guegan
>>> Version: current
>>> OS: SmartOS
>>> Submission from: (NULL) (188.8.131.52)
>>> In order to compile knot on SmartOS, I have done a series of little patches.
>>> One of them is linked to the LMDB project, which redirects me here.
>>> The idea is to tell SmartOS (and I think the SunOS family) to make use of
>>> posix_madvise(3), instead of madvise(3) as implementation on this OS is
>>> different than, for example, the Linux one.
>>> So, I kindly ask you to take a look at the merge request of the knot project,
>>> in particular the `src/contrib/lmdb/mdb.c` patch (that's just a ifdef
>>> modification) : would it be possible to apply this patch directly in this
>>> repository ?
>> I see no functional difference between your references  and .
>> What is the benefit of this patch?
> Well, the Solaris/SunOS's madvise(3) is defined with an old `caddr_t`
> type whereas Linux (and *BSD OSes too) use a more modern approach with
> `void *`.
> On the `knot` project, which embed the lmdb part of openldap,
> compilation failed when using madvise(3) on SmartOS, so I did a
> replacement with posix_madvise(3) which uses the `void *` argument
> I don't know what's the best way to handle this case, that's why I ask here.
A caddr_t is just a typedef of "char *". It should always be legal to
pass a void * to such a parameter. What is your compile error message?
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/