Re: (ITS#8890) Bug fix patches unbreaking the build on x32 systems

[tg@debian.org]

Howard Chu dixit:

>The remaining format patches for debug statements will have no impact
>on the correctness of execution or output. This and all of the
>following patches are being rejected.

There are multiple systems on which sizeof(time_t) > sizeof(long),
with more expected as 2038 dawns.

Are you saying you want to prohibit users on these platforms from
debugging OpenLDAP?

>> --- a/contrib/slapd-modules/smbk5pwd/smbk5pwd.c
>> +++ b/contrib/slapd-modules/smbk5pwd/smbk5pwd.c
>> @@ -605,7 +605,7 @@ static int smbk5pwd_exop_passwd(
>>  =09=09keys[0].bv_val =3D ch_malloc( LDAP_PVT_INTTYPE_CHARS(long) );
>>  =09=09keys[0].bv_len =3D snprintf(keys[0].bv_val,
>>  =09=09=09LDAP_PVT_INTTYPE_CHARS(long),
>> -=09=09=09"%ld", slap_get_time());
>> +=09=09=09"%lld", (long long)slap_get_time());
>>  =09=09BER_BVZERO( &keys[1] );

This doesn=E2=80=99t look like debugging output to me.

bye,
//mirabilos
--=20
Yes, I hate users and I want them to suffer.
=09-- Marco d'Itri on gmane.linux.debian.devel.general