[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
Re: (ITS#8928) Reproducibility: Remove user, hostname, pwd from version string
On 17/11/18 11:42 AM, Howard Chu wrote:
> douglas.royds@taitradio.com wrote:
>> URL: ftp://ftp.openldap.org/incoming/douglas-royds-181026.patch
>>
>> This updated patch also sets the date and time strings to the
>> SOURCE_DATE_EPOCH.
> Are you intending a SOURCE_DATE_EPOCH to be a Unix time value? I.e., an integer?
> This value format needs to be documented.
>
> Unfortunately, your use of date -d is nonportable, it appears that only the GNU tools
> understand this option. It will fail on other platforms like *BSD, Solaris, that aren't
> using a GNU userland.
>
> Why can't you simply provide an already formatted date & time that can be used
> directly, instead of needing to be reformatted here?
URL: ftp://ftp.openldap.org/incoming/douglas-royds-181119.patch
Good point about BSD, my mistake. I have modified the patch to support
BSD platforms as well, though I don't have access to a BSD platform to
test it.
I have added a code comment with a link to the SOURCE_DATE_EPOCH
specification: https://reproducible-builds.org/specs/source-date-epoch/
A more human-readable description and tips for its use can be found
here: https://reproducible-builds.org/docs/source-date-epoch/