(ITS#8840) domainScope control is not properly implemented

[elecharny@symas.com]

Full_Name: Emmanuel Lecharny
Version: 2.4.45
OS: 
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (82.123.98.139)


There has been a change back in 2011 in the controls.c code :

https://github.com/Symas/openldap/commit/4e32148ac59ba6b4f3acc79a3b782cd3556f941a#diff-8237ff8d4da3d46fed54a93482b3a908

Line 1460 was :
if ( ctrl->ldctl_value.bv_len ) {

and was transformed to line 1516 :
if ( BER_BVISNULL( &ctrl->ldctl_value )) {

when it was expected to be :

if ( !BER_BVISNULL( &ctrl->ldctl_value )) {

as this control is not expecting any value.

The consequence is that using this control in ldapsearch leads to an error being
generated :

"domainScope control value not empty"