[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8830) build hardcodes gcc



vcunat@gmail.com wrote:
> On 04/01/2018 11:53 AM, Howard Chu wrote:
>> The coverage flags have only been tested with gcc. What compiler are you
>> using that also provides code coverage with these flags?
> 
> This is clang on osx, kind of.
> 
> NixOS.org is packaging lmdb for various "platforms", including osx.  And
> we run `make test` to be more confident about the result.  That's what
> now broke when we attempt lmdb: 0.9.21 -> 0.9.22 - and this patch fixed
> the build (though I didn't really check anything; I don't really have
> any osx machine myself).
> 
> My experience in general is that clang tries to be compatible with gcc.

The rules you patched are only for generating gcov-compatible binaries. They 
aren't even invoked by "make test" so I don't see why this has any impact on 
your build at all.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/