[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
(ITS#8824) openldap-2.4.46/libraries/liblmdb/mdb_dump.c:136]: (style) Suspicious condition
- To: openldap-its@OpenLDAP.org
- Subject: (ITS#8824) openldap-2.4.46/libraries/liblmdb/mdb_dump.c:136]: (style) Suspicious condition
- From: dcb314@hotmail.com
- Date: Mon, 26 Mar 2018 18:32:23 +0000
- Auto-submitted: auto-generated (OpenLDAP-ITS)
Full_Name: David Binderman
Version: 2.4.46
OS: Linux
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (79.65.172.203)
openldap-2.4.46/libraries/liblmdb/mdb_dump.c:136]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.
Source code is
while ((rc = mdb_cursor_get(mc, &key, &data, MDB_NEXT) == MDB_SUCCESS)) {
maybe better code
while ((rc = mdb_cursor_get(mc, &key, &data, MDB_NEXT)) == MDB_SUCCESS) {