[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8805) Documentation for LDAP_OPT_X_TLS_NEWCTX is wrong



cheimes@redhat.com wrote:
> Full_Name: Christian Heimes
> Version: 2.4.45
> OS: Fedora
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (2001:16b8:607e:f300:6312:6da:8e63:dfa2)
> 
> 
> The documentation for ldap_set_option LDAP_OPT_X_TLS_NEWCTX is wrong or at least
> misleading. The man page https://linux.die.net/man/3/ldap_set_option describes
> the option as:
> 
>> Instructs the library to create a new TLS library context. invalue must be
> const int *. A non-zero value pointed to by invalue tells the library to create
> a context for a server.
> 
> However tls2 creates a new context for any non-NULL argument, even for
> ldap_set_option(l, LDAP_OPT_X_TLS_NEWCTX, 0). See
> https://github.com/openldap/openldap/blob/OPENLDAP_REL_ENG_2_4_45/libraries/libldap/tls2.c#L799-L804

I see no disagreement between the code and the documentation. Please 
elaborate, otherwise this ITS will be closed.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/