[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8732) LDAP_CIRCLEQ improvements

ondra@openldap.org wrote:
> Full_Name: Ondrej Kuznik
> Version: master
> OS:
> URL: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170913-LDAP_CIRCLEQ.patch
> Submission from: (NULL) (
> The CIRCLEQ macros are incomplete and not very useful on their
> own, but when providing a few more that allow rotating it, they
> are. Patch to that effect is attached.
> They could probably be made a bit more efficient as well, though.

Nothing in this patch says "rotate" anywhere. Please add some more descriptive 
comments describing the purpose of each new macro.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/