[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8707) slapd: Add systemd service notification support

On Thu, 10 Aug 2017 02:16:56 +0900,
Ryan Tandy wrote:
> > I've revised the patch for master to check if the listener initialization
> > suceeds or not. With this patch, `slapd -d0` can return non-zero exit code
> > if the listener initialization fails, thus systemd can detect slapd.service
> > startup failure.
> Nice catch! That change looks correct to me, but I hope Howard will check it too. Actually it's probably relevant for any init system; possibly worth splitting out as its own commit?

This patch does NOT affect SysV-init system because an init script
for slapd normally does NOT use the -d option.

> Just checking, do you plan to add the service file and its installation (conditional on enabled systemd support) in this branch as well, or should I work on that myself if I want it?

Yes, I'll do that later.

Thank you.

-- Name: SATOH Fumiyasu @ OSS Technology Corp. (fumiyas @ osstech co jp)
-- Business Home: http://www.OSSTech.co.jp/
-- GitHub Home: https://GitHub.com/fumiyas/
-- PGP Fingerprint: BBE1 A1C9 525A 292E 6729  CDEC ADC2 9DCA 5E1C CBCA