[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8692) back-sock does not create LDAP_MOD_INCREMENT message (unsigned)



(Re-sent without S/MIME sign. for better readability in ITS)

This seems really trivial to fix - even for me. ;-)

I've successfully tested it with Python module slapdsock (and ldif module in python-ldap
2.4.41+).

I, Michael Ströder, hereby place the following modifications to OpenLDAP Software (and
only these modifications) into the public domain. Hence, these modifications may be
freely used and/or redistributed for any purpose with or without attribution and/or other
notice.

https://www.stroeder.com/temp/0001-ITS-8692-let-back-sock-generate-increment-line.patch

---------------------------------------------------------------------------------------
>From 6c37844c5c52b95aff5e4e547cda8a7258e92a35 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michael=20Str=C3=B6der?= <michael@stroeder.com>
Date: Wed, 12 Jul 2017 20:18:22 +0200
Subject: [PATCH] ITS#8692 let back-sock generate increment: line in case of
 LDAP_MOD_INCREMENT (see RFC 4525, section 3)

---
 servers/slapd/back-sock/modify.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/servers/slapd/back-sock/modify.c b/servers/slapd/back-sock/modify.c
index c35d31bc6..9342d2702 100644
--- a/servers/slapd/back-sock/modify.c
+++ b/servers/slapd/back-sock/modify.c
@@ -85,6 +85,10 @@ sock_back_modify(
 		case LDAP_MOD_REPLACE:
 			fprintf( fp, "replace: %s\n", mod->sm_desc->ad_cname.bv_val );
 			break;
+
+		case LDAP_MOD_INCREMENT:
+			fprintf( fp, "increment: %s\n", mod->sm_desc->ad_cname.bv_val );
+			break;
 		}

 		if( mod->sm_values != NULL ) {
-- 
2.13.2