[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8676) openldap source uses implicit functoin declarations

On 19. juni 2017 23:19, slyfox@gentoo.org wrote:
> Why those are problems? implicit function declarations mean the
> function type will be defaulted to int(int, int). > For functions like
>      int slap_sasl_cbinding( Connection *conn, struct berval *cbv );
> it might cause pointer-to-int truncation on 64-bit platforms.

No, implicit declarations are defaulted to int(), and function call
args are not converted other than integer promotions.  So it's not a
problem when the function are called with args of the correct types.
But yeah, it won't hurt to clean up.