[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8623) test022-ppolicy can fail due to timing dependency between lockout and expiration tests

subbarao@computer.org wrote:
> On 03/22/2017 03:19 PM, Quanah Gibson-Mount wrote:
>> Even better is to use the SLEEP variables instead of hard coded
>> values. Then they can be overridden in the test environment if
>> necessary for specific VMs.
>> At the moment we have:
>> quanah@ub16:~/git/openldap/openldap-head/tests/scripts$ grep SLEEP
>> defines.sh
>> SLEEP0=${SLEEP0-1}
>> SLEEP1=${SLEEP1-7}
>> SLEEP2=${SLEEP2-15}
>> It may be useful to add things like SLEEP10, SLEEP20, etc, and rebase
>> tests off of that.  1/7/15 seem rather odd increments (no pun intended!).
> This could well be a very good idea for broader reasons, but it probably
> would be less desirable as a sole solution for this particular
> situation, at least for my use case. In this case, I'm backporting
> 2.4.44 for zesty to 14.04 LTS. Ideally, I want this to be a clean
> rebuild, without any code changes.

Overriding shell variables doesn't require any code changes. It only requires 
that you set their values in whatever build script you use that issues the 
"make test" command. That is the whole reason why we defined these variables.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/