Re: (ITS#8623) test022-ppolicy can fail due to timing dependency between lockout and expiration tests

[quanah@symas.com]

--On Wednesday, March 22, 2017 8:11 PM +0000 hyc@symas.com wrote:

> subbarao@computer.org wrote:
>> Full_Name: Kartik Subbarao
>> Version: 2.4.44
>> OS: Linux
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (108.52.86.252)
>>
>>
>> A recent 2.4.44 package build failed on a VM due to the following timing
>> dependency between the lockout and expiration tests in test022-ppolicy.
>
> Clocks on VMs are notoriously unstable, which is why we have always used
> such  large margins in these tests. Shaving things down to "1 second more
> than  needed" will probably break in multiple build environments.

Even better is to use the SLEEP variables instead of hard coded values. 
Then they can be overridden in the test environment if necessary for 
specific VMs.

At the moment we have:

quanah@ub16:~/git/openldap/openldap-head/tests/scripts$ grep SLEEP 
defines.sh
SLEEP0=${SLEEP0-1}
SLEEP1=${SLEEP1-7}
SLEEP2=${SLEEP2-15}


It may be useful to add things like SLEEP10, SLEEP20, etc, and rebase tests 
off of that.  1/7/15 seem rather odd increments (no pun intended!).

--Quanah



--

Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>